You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/05/10 13:22:53 UTC
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2323
Tested and overall it's great improvement!
Here's few feedbacks.
1. Table does not refreshed after height / width of paragraph change.
2. How about remove 'type' in column table option?
I guess user will be okay without knowing it.
3. showColumnFilter
Following is screenshot with 'showColumnFilter' on. I don't know what this option supposed to do except for adding empty sticky row in the bottom.
4. pagenation
`defaultPaginationSize ` size can be only changed after the Table is displayed with `defaultPaginationSize ` applied. So changing default does not mean too much in this case. Isn't it?
`availablePaginationSizes` - It's minor opinion, I think it is okay with hardcoded value and not make user configurable.
5. Header bar in the option
Two buttons - 'Save', 'Delete' icon - on right little bit confuses me. It was difficult to guess what those button supposed to do. And figured out
'save' - apply option to the table.
'delete' - restore to default options
While option change applies immediately, how about hide 'Save' button? And change 'delete' icon to something more appropriate? For example "Restore the default values" text would be more intuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---