You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/28 21:29:43 UTC
[GitHub] [cloudstack] SadiJr opened a new pull request, #6582: [Veeam] Find VBRViDatastore and VBRServer by name
SadiJr opened a new pull request, #6582:
URL: https://github.com/apache/cloudstack/pull/6582
### Description
Using the VMWare hypervisor, with the Veeam plugin active, ACS tries to find, in Veeam, VBRViDatastore using the UUID of this storage in ACS, and VBRServer using the IP of the host in ACS. But, in some scenarios, the VBRViDatastore/VBRServer, in Veeam, can use the name of this component, which causes an exception in ACS. This PR aims to fix this behavior, improving the search of VBRViDatastore and VBRServer by using the name.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It was tested in a local lab:
1. I added new storage and host in my lab, and make sure the component, in Veeam, are identified by their names;
2. I created a VM (the volume is in the new storage, and VM is in the new host) and added this VM to a backup offering;
3. I make some manual backups;
4. I tried to restore a backed-up volume of this VM;
5. Before, an exception occurs because ACS can't find both VBRViDatastore/VBRServer in Veeam;
6. Now, ACS can restore volume with no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1198688443
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6582)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6582&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6582&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6582&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6582&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6582&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6582&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6582&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6582&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201142474
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201214853
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201066865
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201067267
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201214343
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1201893582
<b>Trillian test result (tid-4588)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6582-t4588-vmware-67u3.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582#issuecomment-1202100787
As this requires a veeam augmented installation, I'm going to trust the submitter's testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6582: [Veeam] Find VBRViDatastore and VBRServer by name
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6582:
URL: https://github.com/apache/cloudstack/pull/6582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org