You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Kollegov ivan (JIRA)" <ji...@apache.org> on 2006/10/27 12:27:16 UTC
[jira] Created: (HARMONY-1986) fix for bug in simplifier
fix for bug in simplifier
-------------------------
Key: HARMONY-1986
URL: http://issues.apache.org/jira/browse/HARMONY-1986
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Kollegov ivan
Priority: Minor
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1986) fix for bug in simplifier
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=all ]
Gregory Shimansky reassigned HARMONY-1986:
------------------------------------------
Assignee: Gregory Shimansky
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Assigned To: Gregory Shimansky
> Priority: Minor
> Attachments: test.patch, test_2.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1986) fix for bug in simplifier
Posted by "Egor Pasko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=comments#action_12445151 ]
Egor Pasko commented on HARMONY-1986:
-------------------------------------
Ivan,
please, look at the issues I found in your test.patch:
* it changes the license message incorrectly in FlowGraph.cpp
* it changes the svn_version_tag.h (which is bad)
just remove the file, make 'svn up .../svn_version_tag.h', 'svn diff' again
or edit the patch manually
* do not see the point in changes within jitrino.xml (it has nothing in common with any fix in simplifier)
probably you need them in the JIT testing framework, clean them up here too (another JIRA issue is eager to see them:)
Is there any test that failed before your patch and passes after applying? It would be nice to see it here too.
Plese, also explain the bug and the basic idea of your changes (Some assertions are commented out, these should be clarified)
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Priority: Minor
> Attachments: test.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1986) fix for bug in simplifier
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=comments#action_12450927 ]
Gregory Shimansky commented on HARMONY-1986:
--------------------------------------------
Any news?
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Assigned To: Gregory Shimansky
> Priority: Minor
> Attachments: test.patch, test_2.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1986) fix for bug in simplifier
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=comments#action_12448623 ]
Gregory Shimansky commented on HARMONY-1986:
--------------------------------------------
It is funny to call patches to fix the problem as "test".
It not funny to submit JIRA with no description of a bug and no apparent "test".
I think Egor should answer the comments by Ivan and then I'll be ready to commit this patch.
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Assigned To: Gregory Shimansky
> Priority: Minor
> Attachments: test.patch, test_2.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1986) fix for bug in simplifier
Posted by "Kollegov ivan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=all ]
Kollegov ivan updated HARMONY-1986:
-----------------------------------
Attachment: test_2.patch
>>* it changes the license message incorrectly in FlowGraph.cpp
Sorry, it was my mistake. fixed.
>>* it changes the svn_version_tag.h (which is bad)
>> just remove the file, make 'svn up .../svn_version_tag.h', 'svn diff' again
>> or edit the patch manually
now it is ok?
>>* do not see the point in changes within jitrino.xml
done
>>Is there any test that failed before your patch and passes after applying? It would be nice to see it here too.
These test are in JIRA-1586
(test\testcase\optimizer\simplifier_test.cpp )
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Priority: Minor
> Attachments: test.patch, test_2.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1986) fix for bug in simplifier
Posted by "Kollegov ivan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1986?page=all ]
Kollegov ivan updated HARMONY-1986:
-----------------------------------
Attachment: test.patch
patch for simplifier
> fix for bug in simplifier
> -------------------------
>
> Key: HARMONY-1986
> URL: http://issues.apache.org/jira/browse/HARMONY-1986
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Kollegov ivan
> Priority: Minor
> Attachments: test.patch
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira