You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Stefan Groschupf (JIRA)" <ji...@apache.org> on 2005/11/24 16:12:55 UTC

[jira] Created: (NUTCH-128) second configuration nodes overwrites first node

second configuration nodes overwrites first node
------------------------------------------------

         Key: NUTCH-128
         URL: http://issues.apache.org/jira/browse/NUTCH-128
     Project: Nutch
        Type: Bug
    Versions: 0.7.1    
    Reporter: Stefan Groschupf
    Priority: Trivial


It could happen that there are two identically key definitions in one nutch-default.xml or nutch-site.xml, in such a case the second values overwrites the first value of the same (!) configuration file. May we can at least log a warning. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (NUTCH-128) second configuration nodes overwrites first node

Posted by Andrzej Bialecki <ab...@getopt.org>.
Stefan Groschupf wrote:

> Sorry for me terrible english.
> Sure I know the concept of nutch-default.xml and nutch-site.xml.
> I tried to say that in case you have a setup for plugin.inlcude in  
> nutch-site.xml in the beginning of the file and may since you made a  
> mistake a second time in the end of the same file, the last  
> definition overwrites the first.
> So sure multi values for one key in multi files, but we should warn  
> in case a key is defined two times in the same file.
> Could I clarify my suggestion?
> Stefan


Ok, now I get it - yes, that would be useful, nobody would do this on 
purpose, so if it's not too complicated we should warn the user.

-- 
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com



Re: [jira] Created: (NUTCH-128) second configuration nodes overwrites first node

Posted by Stefan Groschupf <sg...@media-style.com>.
Sorry for me terrible english.
Sure I know the concept of nutch-default.xml and nutch-site.xml.
I tried to say that in case you have a setup for plugin.inlcude in  
nutch-site.xml in the beginning of the file and may since you made a  
mistake a second time in the end of the same file, the last  
definition overwrites the first.
So sure multi values for one key in multi files, but we should warn  
in case a key is defined two times in the same file.
Could I clarify my suggestion?
Stefan


Am 24.11.2005 um 18:30 schrieb Andrzej Bialecki:

> Stefan Groschupf (JIRA) wrote:
>
>> second configuration nodes overwrites first node
>> ------------------------------------------------
>>
>>         Key: NUTCH-128
>>         URL: http://issues.apache.org/jira/browse/NUTCH-128
>>     Project: Nutch
>>        Type: Bug
>>    Versions: 0.7.1       Reporter: Stefan Groschupf
>>    Priority: Trivial
>>
>>
>> It could happen that there are two identically key definitions in  
>> one nutch-default.xml or nutch-site.xml, in such a case the second  
>> values overwrites the first value of the same (!) configuration  
>> file. May we can at least log a warning.
>
> Erhm... I think that's the whole point of having multiple files. In  
> the end you only have one instance of Properties in NutchConf, and  
> the values are those, who were last seen on the last config file;  
> that's how overriding the defaults works ...
>
> -- 
> Best regards,
> Andrzej Bialecki     <><
> ___. ___ ___ ___ _ _   __________________________________
> [__ || __|__/|__||\/|  Information Retrieval, Semantic Web
> ___|||__||  \|  ||  |  Embedded Unix, System Integration
> http://www.sigram.com  Contact: info at sigram dot com
>
>
>


Re: [jira] Created: (NUTCH-128) second configuration nodes overwrites first node

Posted by Andrzej Bialecki <ab...@getopt.org>.
Stefan Groschupf (JIRA) wrote:

>second configuration nodes overwrites first node
>------------------------------------------------
>
>         Key: NUTCH-128
>         URL: http://issues.apache.org/jira/browse/NUTCH-128
>     Project: Nutch
>        Type: Bug
>    Versions: 0.7.1    
>    Reporter: Stefan Groschupf
>    Priority: Trivial
>
>
>It could happen that there are two identically key definitions in one nutch-default.xml or nutch-site.xml, in such a case the second values overwrites the first value of the same (!) configuration file. May we can at least log a warning. 
>  
>

Erhm... I think that's the whole point of having multiple files. In the 
end you only have one instance of Properties in NutchConf, and the 
values are those, who were last seen on the last config file; that's how 
overriding the defaults works ...

-- 
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com



[jira] Commented: (NUTCH-128) second configuration nodes overwrites first node

Posted by "Paul Baclace (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/NUTCH-128?page=comments#action_12361254 ] 

Paul Baclace commented on NUTCH-128:
------------------------------------

In general, it might be helpful to issue an INFO level log msg whenever a configuration attribute is overridden.   If the override occurs in the same file, it should be WARN level.


> second configuration nodes overwrites first node
> ------------------------------------------------
>
>          Key: NUTCH-128
>          URL: http://issues.apache.org/jira/browse/NUTCH-128
>      Project: Nutch
>         Type: Bug
>     Versions: 0.7.1
>     Reporter: Stefan Groschupf
>     Priority: Trivial

>
> It could happen that there are two identically key definitions in one nutch-default.xml or nutch-site.xml, in such a case the second values overwrites the first value of the same (!) configuration file. May we can at least log a warning. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira