[GitHub] nwangtw commented on a change in pull request #3005: fix building problem with source tarball

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3005: fix building problem with source tarball
URL: https://github.com/apache/incubator-heron/pull/3005#discussion_r212175444
 
 

 ##########
 File path: scripts/release/status.sh
 ##########
 @@ -42,28 +42,37 @@ function disable_e_and_execute {
 }
 
 # get the release tag version or the branch name
-if [ -z ${HERON_BUILD_VERSION+x} ];
-then
-  cmd="git rev-parse --abbrev-ref HEAD"
-  build_version=$($cmd) || die "Failed to run command to check head: $cmd"
-
-  if [ "${build_version}" = "HEAD" ];
+if [ -d .git ]; then
 
 Review comment:
   suggest to follow the convention in this file, put "then" in the next line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services