You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/28 05:01:44 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #973: Fix/consul unreg
LaurenceLiZhixin opened a new pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
fix consul unregister bug.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #749
**Special notes for your reviewer**:
I record the *copy* of every registry url, and make sure the unregistry url is we wanted.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on a change in pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on a change in pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#discussion_r549228069
##########
File path: registry/consul/registry.go
##########
@@ -91,6 +95,7 @@ func (r *consulRegistry) Register(url *common.URL) error {
// register actually register the @url
func (r *consulRegistry) register(url *common.URL) error {
+ r.registeredURLs = append(r.registeredURLs, url.Clone())
Review comment:
问一个问题，在还没有注册consul之前就应该添加上去吗？
但是如果在注册成功之后，因为buildService(url)因为传进去的是url的引用，会修改掉url的参数，所以也会注册不掉.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on a change in pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on a change in pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#discussion_r549228069
##########
File path: registry/consul/registry.go
##########
@@ -91,6 +95,7 @@ func (r *consulRegistry) Register(url *common.URL) error {
// register actually register the @url
func (r *consulRegistry) register(url *common.URL) error {
+ r.registeredURLs = append(r.registeredURLs, url.Clone())
Review comment:
问一个问题，在还没有注册consul之前就应该添加上去吗？
但是如果在注册成功之后，因为buildService(url)因为传进去的是url的引用，会修改掉url的参数，所以也会问题.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#issuecomment-751577782
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=h1) Report
> Merging [#973](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=desc) (56f23ed) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e308e19ad2c0c61738cd496d834bb322b0a0e626?el=desc) (e308e19) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #973 +/- ##
========================================
Coverage 59.91% 59.92%
========================================
Files 261 261
Lines 12912 12912
========================================
+ Hits 7736 7737 +1
+ Misses 4224 4222 -2
- Partials 952 953 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <57.14%> (ø)` | |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `67.96% <0.00%> (-3.13%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `81.52% <0.00%> (+2.17%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (+3.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=footer). Last update [9ae3c90...56f23ed](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#issuecomment-751577782
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=h1) Report
> Merging [#973](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=desc) (56f23ed) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e308e19ad2c0c61738cd496d834bb322b0a0e626?el=desc) (e308e19) will **decrease** coverage by `0.13%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #973 +/- ##
===========================================
- Coverage 59.91% 59.78% -0.14%
===========================================
Files 261 261
Lines 12912 12912
===========================================
- Hits 7736 7719 -17
- Misses 4224 4234 +10
- Partials 952 959 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <57.14%> (ø)` | |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `75.00% <0.00%> (-4.35%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `67.96% <0.00%> (-3.13%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `73.13% <0.00%> (-2.99%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=footer). Last update [e308e19...56f23ed](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#discussion_r553751139
##########
File path: registry/consul/registry.go
##########
@@ -188,25 +193,26 @@ func (r *consulRegistry) IsAvailable() bool {
// Destroy consul registry center
func (r *consulRegistry) Destroy() {
- if r.URL != nil {
- done := make(chan struct{}, 1)
- go func() {
- defer func() {
- if e := recover(); e != nil {
- logger.Errorf("consulRegistry destroy with panic: %v", e)
- }
- done <- struct{}{}
- }()
- if err := r.UnRegister(r.URL); err != nil {
- logger.Errorf("consul registry unregister with err: %s", err.Error())
+ done := make(chan struct{}, 1)
+ go func() {
+ defer func() {
+ if e := recover(); e != nil {
+ logger.Errorf("consulRegistry destory with panic: %v", e)
}
+ done <- struct{}{}
}()
- select {
- case <-done:
- logger.Infof("consulRegistry unregister done")
- case <-time.After(registryDestroyDefaultTimeout):
- logger.Errorf("consul unregister timeout")
+ for _, url := range r.registeredURLs {
+ if err := r.UnRegister(url); err != nil {
+ logger.Errorf("consul registry unregister with err: %s", err.Error())
+ }
}
+ }()
+ select {
+ case <-done:
+ logger.Infof("consulRegistry unregister done")
+ case <-time.After(registryDestroyDefaultTimeout):
Review comment:
fixed！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#discussion_r549727012
##########
File path: registry/consul/registry.go
##########
@@ -188,25 +193,26 @@ func (r *consulRegistry) IsAvailable() bool {
// Destroy consul registry center
func (r *consulRegistry) Destroy() {
- if r.URL != nil {
- done := make(chan struct{}, 1)
- go func() {
- defer func() {
- if e := recover(); e != nil {
- logger.Errorf("consulRegistry destroy with panic: %v", e)
- }
- done <- struct{}{}
- }()
- if err := r.UnRegister(r.URL); err != nil {
- logger.Errorf("consul registry unregister with err: %s", err.Error())
+ done := make(chan struct{}, 1)
+ go func() {
+ defer func() {
+ if e := recover(); e != nil {
+ logger.Errorf("consulRegistry destory with panic: %v", e)
}
+ done <- struct{}{}
}()
- select {
- case <-done:
- logger.Infof("consulRegistry unregister done")
- case <-time.After(registryDestroyDefaultTimeout):
- logger.Errorf("consul unregister timeout")
+ for _, url := range r.registeredURLs {
+ if err := r.UnRegister(url); err != nil {
+ logger.Errorf("consul registry unregister with err: %s", err.Error())
+ }
}
+ }()
+ select {
+ case <-done:
+ logger.Infof("consulRegistry unregister done")
+ case <-time.After(registryDestroyDefaultTimeout):
Review comment:
using `getty.GetTimeWheel().After(registryDestroyDefaultTimeout)` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#issuecomment-751577782
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=h1) Report
> Merging [#973](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=desc) (66b5283) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c145691a579e7203bbef2e2891fd8421f2acd3b4?el=desc) (c145691) will **decrease** coverage by `0.11%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #973 +/- ##
===========================================
- Coverage 59.97% 59.86% -0.12%
===========================================
Files 261 261
Lines 12915 12915
===========================================
- Hits 7746 7731 -15
- Misses 4214 4233 +19
+ Partials 955 951 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <57.14%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-9.33%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `49.79% <0.00%> (-1.64%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=footer). Last update [c145691...66b5283](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#discussion_r549268672
##########
File path: registry/consul/registry.go
##########
@@ -91,6 +95,7 @@ func (r *consulRegistry) Register(url *common.URL) error {
// register actually register the @url
func (r *consulRegistry) register(url *common.URL) error {
+ r.registeredURLs = append(r.registeredURLs, url.Clone())
Review comment:
1. 我认为在注册前把url添加进数组没有问题。
因为最终destroy的时候，即使unregister不存在的url也无妨。
2. 因为buildServicce会对url进行修改，而其中buildid函数是根据修改前的url生成的id，在unregister的时候，也必须严格使用修改前的url来生成id，所以这里临时把修改前的拷贝了出来，用于unregister。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #973: Fix/consul unreg
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #973:
URL: https://github.com/apache/dubbo-go/pull/973#issuecomment-751577782
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=h1) Report
> Merging [#973](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=desc) (082a0bd) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a976cf48c615c23430d0a4b01af58de605d13909?el=desc) (a976cf4) will **decrease** coverage by `0.33%`.
> The diff coverage is `54.83%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #973 +/- ##
===========================================
- Coverage 59.92% 59.59% -0.34%
===========================================
Files 261 261
Lines 12915 12903 -12
===========================================
- Hits 7739 7689 -50
- Misses 4223 4247 +24
- Partials 953 967 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `67.96% <0.00%> (-2.67%)` | :arrow_down: |
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `78.91% <0.00%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+1.73%)` | :arrow_up: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.41% <ø> (-0.70%)` | :arrow_down: |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `44.30% <ø> (+2.32%)` | :arrow_up: |
| [remoting/getty/getty\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfc2VydmVyLmdv) | `45.83% <0.00%> (+3.86%)` | :arrow_up: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| ... and [47 more](https://codecov.io/gh/apache/dubbo-go/pull/973/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=footer). Last update [9ae3c90...082a0bd](https://codecov.io/gh/apache/dubbo-go/pull/973?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org