You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/27 19:38:01 UTC

[GitHub] [arrow] HashidaTKS edited a comment on pull request #10990: ARROW-13704: [C#] Add support for reading streaming format delta dictionaries

HashidaTKS edited a comment on pull request #10990:
URL: https://github.com/apache/arrow/pull/10990#issuecomment-928209072


   The internal `ListArray.Builder` ctor was called instead of the public ctor in `ArrayBuilderTests.NestedListArrayBuilder()`. 
   Because of adding `InternalsVisibleTo` into `AssemblyInfo.cs`, `Arrow.Array.Test` could see the internal ctor and it had higher overload priority than the public ctor.
   
   ```
   public Builder(IArrowType valueDataType) ...
   internal Builder(ListType dataType) ...
   ```
   
   For the above reasons, I changed to use Reflection instead of InternalsVisibleTo in tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org