You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by mbalassi <gi...@git.apache.org> on 2016/05/10 21:47:10 UTC
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
GitHub user mbalassi opened a pull request:
https://github.com/apache/bigtop/pull/109
BIGTOP-2426. Flink patch quickfix
Just a missing whitespace and line number updates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/bigtop BIGTOP-2426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit a09c8572b4db21b395c4b5f8c56d81f0a083269e
Author: Marton Balassi <mb...@apache.org>
Date: 2016-05-10T21:44:34Z
BIGTOP-2426. Flink patch quickfix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Bump Flink version to 1.0.3
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bigtop/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Bump Flink version to 1.0.3
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218995452
+1 to merge
I tested the build and the final artifact on debian and it works!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218758100
I am still testing the change, will let you know when I can confirm the builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by oflebbe <gi...@git.apache.org>.
Github user oflebbe commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218722301
@rmetzger : No problem. Just rename JIRA and patch subject.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218719650
The Flink project just released version 1.0.3, which contains a fix for the issue we are patching here.
By bumping the Flink version to 1.0.3 in bigtop, we can get rid of the patch entirely.
Do you agree to rename the JIRA to "Bump Flink to 1.0.3" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218749517
Thanks, @rmetzger & @oflebbe. I am renaming the JIRA and updating the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218537961
Are you changing the source code of the project during the build time? That's what the error message implies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Bump Flink version to 1.0.3
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218976424
Both of the builds finished fine. \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218303803
Unfortunately the build still fails, I will continue investigating tomorrow.
```
dpkg-source: info: building flink using existing ./flink_1.0.0.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
flink-1.0.0/docs/setup/config.md
flink-1.0.0/flink-dist/src/main/flink-bin/bin/config.sh
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/flink_1.0.0-1.diff.uU9FvM
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-buildpackage: error: dpkg-source -b flink-1.0.0 gave error exit status 2
:flink-sdeb FAILED
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2426. Flink patch quickfix
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/bigtop/pull/109#issuecomment-218450926
I have checked in the meantime, the rpm package builds successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---