You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by "liaosunny123 (via GitHub)" <gi...@apache.org> on 2023/08/14 08:38:01 UTC
[GitHub] [inlong] liaosunny123 opened a new issue, #8716: [Bug] set error code 0 when it works
liaosunny123 opened a new issue, #8716:
URL: https://github.com/apache/inlong/issues/8716
### What happened
TubeMQ Master will respond error code 200 in the retValue when it works, however the wrapped error code is 0.
The two is not consistent and I think making error code 0 both will be a good idea.
### What you expected to happen
Set both 0 means ok.
### How to reproduce
every api may carrys these problems.
### Environment
_No response_
### InLong version
master
### InLong Component
InLong TubeMQ
### Are you willing to submit PR?
- [ ] Yes, I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liaosunny123 commented on issue #8716: [Bug][TubeMQ] set error code 0 when it works
Posted by "liaosunny123 (via GitHub)" <gi...@apache.org>.
liaosunny123 commented on issue #8716:
URL: https://github.com/apache/inlong/issues/8716#issuecomment-1678341380
> @liaosunny123, please adjust the implementation of [8722 ](https://github.com/apache/inlong/pull/8722) according to the above content, thanks!
solved in https://github.com/apache/inlong/pull/8722/commits/a6f1a237ebeb9c86297afd4d647e035236f9fb63, however it seems that it has been fixed in https://github.com/apache/inlong/pull/8724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #8716: [Bug] set error code 0 when it works
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on issue #8716:
URL: https://github.com/apache/inlong/issues/8716#issuecomment-1678330025
Analyze the return of the error code, the modification of this part involves the return result of RPC. In order to avoid compatibility problems caused by hasty modification, the current practice is temporarily maintained here: if the operation of the API returns successfully, it returns 0, and the others fail; the operation sub-item The return of 200 or 0 is success, and the others are failure
Subsequent versions will improve the implementation of this area, and the final desired effect: 0 means success, and other non-zero values are abnormal
Analyzing the return of the API, there is a point that does not meet the above requirements, and a PR needs to be submitted for modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #8716: [Bug] set error code 0 when it works
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on issue #8716:
URL: https://github.com/apache/inlong/issues/8716#issuecomment-1678330768
@liaosunny123, please adjust the implementation of 8722 according to the above content, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang closed issue #8716: [Bug][TubeMQ] set error code 0 when it works
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang closed issue #8716: [Bug][TubeMQ] set error code 0 when it works
URL: https://github.com/apache/inlong/issues/8716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #8716: [Bug] set error code 0 when it works
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on issue #8716:
URL: https://github.com/apache/inlong/issues/8716#issuecomment-1676926122
It is indeed a bug, and it is a very hidden problem!
@liaosunny123, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org