You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 16:03:52 UTC
[GitHub] [airflow] jbampton opened a new pull request #12956: Fix case of JavaScript
jbampton opened a new pull request #12956:
URL: https://github.com/apache/airflow/pull/12956
Changed `javascript` to `JavaScript`
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jbampton commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-741904801
Hey @potiuk thanks for the interest 👍
I run a spell checker across the codebase and it finds most of the spelling mistakes but it also does find a lot of false positives so then then manual work starts sifting through them.
For fixing the case of words like `javascript` to `JavaScript` I use a find and replace function in my code editor and it does also involve manual work since the term `javascript` comes up in places where it does not need to be changed.
I will have a look at some of the `good first issues` when I get some time. Thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #12956:
URL: https://github.com/apache/airflow/pull/12956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-742009149
I think you can do this as part of https://github.com/apache/airflow/pull/12963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-741970007
[The Workflow run](https://github.com/apache/airflow/actions/runs/411236858) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-787209757
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-741917949
Maybe also remove `javascript` word from the spelling list. https://github.com/apache/airflow/blob/master/docs/spelling_wordlist.txt#L861
This will hopefully make the CI job fail when someone uses wrong case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-741969591
[The Workflow run](https://github.com/apache/airflow/actions/runs/411305222) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12956: Fix case of JavaScript
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12956:
URL: https://github.com/apache/airflow/pull/12956#issuecomment-741923943
> [#12956 (comment)](https://github.com/apache/airflow/pull/12956#issuecomment-741917949)
>
> ^^ If that is addressed, we won't have the same issue again. Can you also do it for the other cases you have identified
Might be the "good first issue" :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org