[GitHub] [plc4x] chrisdutz commented on pull request #711: fix(protocols/modbus): fix write requests for coils always set to false (#710)

[GitBox <gi...@apache.org>]

chrisdutz commented on PR #711:
URL: https://github.com/apache/plc4x/pull/711#issuecomment-1363879345

   I think in this case it would then work for the coils, but break for the registers, as these are 16 bit units.
   
   I think a better solution would be to have either a dedicated DataIo for coil data (However this would have very few cases) or to not use the DataIo component for parsing the coil data, but to implement it manually (which shouldn't be much work) for this case (One could argue, that reading 8 coils and having that interpreted as a signed 8-bit integer would no longer be supported by that, but that's probably something I would be able to live with)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org