You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 13:15:51 UTC
[GitHub] [flink] pnowojski commented on a diff in pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint
pnowojski commented on code in PR #21131:
URL: https://github.com/apache/flink/pull/21131#discussion_r1008052894
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java:
##########
@@ -98,18 +120,19 @@ private ChannelStateCheckpointWriter buildWriter(CheckpointStartRequest request)
streamFactoryResolver.resolveCheckpointStorageLocation(
request.getCheckpointId(), request.getLocationReference()),
serializer,
- () -> writers.remove(request.getCheckpointId()));
+ () -> this.writer = null);
Review Comment:
shouldn't you check here if this is the correct writer? Could it happen that the `this.writer` got reseted for a newer checkpoint but this callback happens later, reseting the field back to `null`? If this can not happen, it would be nice to at least have a `checkState` to make sure it's not happening?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org