You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David Chen <dc...@linkedin.com> on 2014/09/19 01:21:55 UTC
Re: Review Request 23797: HIVE-7420: Parameterize tests for HCatalog
Pig interfaces for testing against all storage formats.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23797/
-----------------------------------------------------------
(Updated Sept. 18, 2014, 11:21 p.m.)
Review request for hive.
Changes
-------
Rebasing on trunk.
Summary (updated)
-----------------
HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.
Bugs: HIVE-7420
https://issues.apache.org/jira/browse/HIVE-7420
Repository: hive-git
Description
-------
HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.
Diffs (updated)
-----
hcatalog/hcatalog-pig-adapter/pom.xml 4d2ca519d413b7de0a6a8b50f9a099c3539fc432
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java ee3e75066082ac3b98f87e76687fc0bd3a1fe67d
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java 40ec5976da72e4a0919721278a0941cf12b52741
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java 763af9fab176eb2784ac05e081d06dafd6ca5494
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 9679d3c02520d605f7f22106c616011f44f6c0a3
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java 82eb0d72b4f885184c094113f775415c06bdce98
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoaderComplexSchema.java 05387711289279cab743f51aee791069609b904a
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 65769b41c921299d37c0db36f8a7a2410babe433
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorerMulti.java 77c79791cf150ff195486065f712b0e20b4fd758
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestUtil.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java 19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9
Diff: https://reviews.apache.org/r/23797/diff/
Testing
-------
Thanks,
David Chen
Re: Review Request 23797: HIVE-7420: Parameterize tests for HCatalog
Pig interfaces for testing against all storage formats.
Posted by David Chen <dc...@linkedin.com>.
> On Sept. 20, 2014, 12:35 a.m., Jason Dere wrote:
> > hcatalog/hcatalog-pig-adapter/pom.xml, line 56
> > <https://reviews.apache.org/r/23797/diff/5/?file=694145#file694145line56>
> >
> > What is needed from the test classes in hive-exec here? I believe that doing ends up having some bad effects for downstream users of this package, as a package that depends on hcatalog-pig-adapter will now try to pull in hive-exec-test.jar as a dependency (and fail since I don't think this is published). This is something we noticed at my company when we made a similar change in another hcatalog package.
What I really need is the test jar from hive-ql because these tests use org.apache.hadoop.hive.ql.io.StorageFormats in order to enumerate and test against all Hive storage formats. This is specified as a test dependency. As a result, I do not think that packages that depend on hcatalog-pig-adapter would try to pull in hive-exec-test.jar unless the package is depending on hcatalog-pig-adapater as a test dependency. Please correct me if I'm mistaken.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23797/#review54061
-----------------------------------------------------------
On Sept. 18, 2014, 11:21 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23797/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 11:21 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7420
> https://issues.apache.org/jira/browse/HIVE-7420
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.
>
>
> Diffs
> -----
>
> hcatalog/hcatalog-pig-adapter/pom.xml 4d2ca519d413b7de0a6a8b50f9a099c3539fc432
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java ee3e75066082ac3b98f87e76687fc0bd3a1fe67d
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java 40ec5976da72e4a0919721278a0941cf12b52741
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java 763af9fab176eb2784ac05e081d06dafd6ca5494
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 9679d3c02520d605f7f22106c616011f44f6c0a3
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java 82eb0d72b4f885184c094113f775415c06bdce98
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoaderComplexSchema.java 05387711289279cab743f51aee791069609b904a
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 65769b41c921299d37c0db36f8a7a2410babe433
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorerMulti.java 77c79791cf150ff195486065f712b0e20b4fd758
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestUtil.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java 19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9
>
> Diff: https://reviews.apache.org/r/23797/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 23797: HIVE-7420: Parameterize tests for HCatalog
Pig interfaces for testing against all storage formats.
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23797/#review54061
-----------------------------------------------------------
hcatalog/hcatalog-pig-adapter/pom.xml
<https://reviews.apache.org/r/23797/#comment94009>
What is needed from the test classes in hive-exec here? I believe that doing ends up having some bad effects for downstream users of this package, as a package that depends on hcatalog-pig-adapter will now try to pull in hive-exec-test.jar as a dependency (and fail since I don't think this is published). This is something we noticed at my company when we made a similar change in another hcatalog package.
- Jason Dere
On Sept. 18, 2014, 11:21 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23797/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 11:21 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7420
> https://issues.apache.org/jira/browse/HIVE-7420
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.
>
>
> Diffs
> -----
>
> hcatalog/hcatalog-pig-adapter/pom.xml 4d2ca519d413b7de0a6a8b50f9a099c3539fc432
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java ee3e75066082ac3b98f87e76687fc0bd3a1fe67d
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java 40ec5976da72e4a0919721278a0941cf12b52741
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java 763af9fab176eb2784ac05e081d06dafd6ca5494
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 9679d3c02520d605f7f22106c616011f44f6c0a3
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java 82eb0d72b4f885184c094113f775415c06bdce98
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoaderComplexSchema.java 05387711289279cab743f51aee791069609b904a
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 65769b41c921299d37c0db36f8a7a2410babe433
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorerMulti.java 77c79791cf150ff195486065f712b0e20b4fd758
> hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestUtil.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java 19fdeb5ed3dba7a3bcba71fb285d92d3f6aabea9
>
> Diff: https://reviews.apache.org/r/23797/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Chen
>
>