You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matt Brictson (JIRA)" <ji...@apache.org> on 2009/11/06 00:41:32 UTC

[jira] Created: (WICKET-2564) Modify wicket-devutils DebugBar so it emits valid XHTML

Modify wicket-devutils DebugBar so it emits valid XHTML
-------------------------------------------------------

                 Key: WICKET-2564
                 URL: https://issues.apache.org/jira/browse/WICKET-2564
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4.3
            Reporter: Matt Brictson
            Priority: Minor


It would be nice if the DebugBar would emit valid XHTML.

In its current form, it emits img elements that lack the necessary alt attribute. This means that when you include a DebugBar on your page, it will cause XHTML validation of that page to fail.

This is a minor issue, but the fix is also very simple: just add alt attributes to the DebugBar img elements.

I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-2564) Modify wicket-devutils DebugBar so it emits valid XHTML

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-2564:
-------------------------------------

    Fix Version/s: 1.5-M1
                   1.4.4
         Assignee: Jeremy Thomerson

Thanks for the patch!

> Modify wicket-devutils DebugBar so it emits valid XHTML
> -------------------------------------------------------
>
>                 Key: WICKET-2564
>                 URL: https://issues.apache.org/jira/browse/WICKET-2564
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.3
>            Reporter: Matt Brictson
>            Assignee: Jeremy Thomerson
>            Priority: Minor
>             Fix For: 1.4.4, 1.5-M1
>
>         Attachments: WICKET-2564-devutils-xhtml-patch.txt
>
>
> It would be nice if the DebugBar would emit valid XHTML.
> In its current form, it emits img elements that lack the necessary alt attribute. This means that when you include a DebugBar on your page, it will cause XHTML validation of that page to fail.
> This is a minor issue, but the fix is also very simple: just add alt attributes to the DebugBar img elements.
> I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-2564) Modify wicket-devutils DebugBar so it emits valid XHTML

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson resolved WICKET-2564.
--------------------------------------

    Resolution: Fixed

Applied to trunk and 1.4.x

> Modify wicket-devutils DebugBar so it emits valid XHTML
> -------------------------------------------------------
>
>                 Key: WICKET-2564
>                 URL: https://issues.apache.org/jira/browse/WICKET-2564
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.3
>            Reporter: Matt Brictson
>            Assignee: Jeremy Thomerson
>            Priority: Minor
>             Fix For: 1.4.4, 1.5-M1
>
>         Attachments: WICKET-2564-devutils-xhtml-patch.txt
>
>
> It would be nice if the DebugBar would emit valid XHTML.
> In its current form, it emits img elements that lack the necessary alt attribute. This means that when you include a DebugBar on your page, it will cause XHTML validation of that page to fail.
> This is a minor issue, but the fix is also very simple: just add alt attributes to the DebugBar img elements.
> I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-2564) Modify wicket-devutils DebugBar so it emits valid XHTML

Posted by "Matt Brictson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Brictson updated WICKET-2564:
----------------------------------

    Attachment: WICKET-2564-devutils-xhtml-patch.txt

Patch against trunk @832323. Fixes XHTML issue and unit tests pass.

> Modify wicket-devutils DebugBar so it emits valid XHTML
> -------------------------------------------------------
>
>                 Key: WICKET-2564
>                 URL: https://issues.apache.org/jira/browse/WICKET-2564
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.3
>            Reporter: Matt Brictson
>            Priority: Minor
>         Attachments: WICKET-2564-devutils-xhtml-patch.txt
>
>
> It would be nice if the DebugBar would emit valid XHTML.
> In its current form, it emits img elements that lack the necessary alt attribute. This means that when you include a DebugBar on your page, it will cause XHTML validation of that page to fail.
> This is a minor issue, but the fix is also very simple: just add alt attributes to the DebugBar img elements.
> I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.