[GitHub] [ignite] alex-plekhanov commented on a change in pull request #7990: IGNITE-13192 Java thin client: Fix binary type schema registration for already cached typeId

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #7990:
URL: https://github.com/apache/ignite/pull/7990#discussion_r450067606



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -378,6 +362,49 @@ private String readString(BinaryInputStream in) throws BinaryObjectException {
             return cache.metadata();
         }
 
+        /**
+         * Request binary metadata from server and add binary type to cache.
+         *
+         * @param typeId Type id.
+         */
+        private BinaryType requestAndCacheBinaryType(int typeId) throws BinaryObjectException {

Review comment:
       I've refactored `metadata` method, so there is only one cast now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org