You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/06 05:23:40 UTC

[GitHub] [tvm] f2013519 opened a new pull request, #13556: Mark base64.h encode and decode API's as inline

f2013519 opened a new pull request, #13556:
URL: https://github.com/apache/tvm/pull/13556

   The b64strlen & b64decode API's are defined in a header and will cause linker issues if included in multiple files. We ran into this issue while attempting to use this file in our project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
masahi merged PR #13556:
URL: https://github.com/apache/tvm/pull/13556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13556:
URL: https://github.com/apache/tvm/pull/13556#issuecomment-1339853101

   @f2013519 Good catch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] f2013519 commented on pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
f2013519 commented on PR #13556:
URL: https://github.com/apache/tvm/pull/13556#issuecomment-1339284692

   @masahi Could you pls. take a look? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13556:
URL: https://github.com/apache/tvm/pull/13556#issuecomment-1338781359

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] f2013519 commented on pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
f2013519 commented on PR #13556:
URL: https://github.com/apache/tvm/pull/13556#issuecomment-1339293253

   cc @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] f2013519 commented on pull request #13556: Mark base64.h encode and decode API's as inline

Posted by GitBox <gi...@apache.org>.
f2013519 commented on PR #13556:
URL: https://github.com/apache/tvm/pull/13556#issuecomment-1340408488

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org