You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jduo (via GitHub)" <gi...@apache.org> on 2023/11/30 20:03:34 UTC
[PR] [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
jduo opened a new pull request, #39011:
URL: https://github.com/apache/arrow/pull/39011
Depends on #38997
### Rationale for this change
Part of modularizing Arrow. Allows these components to be used by tools that require JPMS modules such as jlink.
### What changes are included in this PR?
- Refactor memory modules so that all netty code is in netty-memory.
- All code being injected into Netty packages and have dependencies on Netty's package-private code go into a new module memory-netty-buffer-patch.
- The surefire command line has been changed to allow reflection on unsafe to be used by arrow-memory-core
- Add module-info files for arrow-memory-core and arrow-memory-unsafe
### Are these changes tested?
Yes, existing tests work when run with modules.
### Are there any user-facing changes?
Yes, users now need to put --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED on their java command line instead of --add-opens=java.base/java.nio=ALL-UNNAMED since memory-core is now a named module instead of unnamed.
**This PR includes breaking changes to public APIs.**
Yes, users now need to put --add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED on their java command line instead of --add-opens=java.base/java.nio=ALL-UNNAMED since memory-core is now a named module instead of unnamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881886959
Revision: 7743b44540f71e15fb9960d9a58793804c136235
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dcf20e3dee](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dcf20e3dee)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629309/job/20279423285)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628810/job/20279418291)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629015/job/20279419334)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630116/job/20279447317)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629126/job/20279419760)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628922/job/20279418931)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629988/job/20279447170)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630011/job/20279447258)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629756/job/20279422978)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629071/job/20279419535)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629071/job/20279419535)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629217/job/20279420230)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629552/job/20279422138)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628962/job/20279419042)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629621/job/20279422654)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628896/job/20279418721)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629978/job/20279447040)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629587/job/20279422512)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629270/job/20279420402)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629722/job/20279422894)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628928/job/20279418867)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629508/job/20279421977)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629146/job/20279419827)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628825/job/20279418529)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630146/job/20279447452)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629073/job/20279419570)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629540/job/20279422123)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629485/job/20279421637)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629503/job/20279421827)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628795/job/20279418297)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628821/job/20279418420)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629572/job/20279422311)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630182/job/20279447534)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629611/job/20279422780)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629123/job/20279419609)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629323/job/20279420786)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629928/job/20279446991)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628793/job/20279418365)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629406/job/20279420990)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629122/job/20279419653)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628924/job/20279418925)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628982/job/20279419197)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629588/job/20279422515)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629752/job/20279422947)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629340/job/20279420839)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629283/job/20279420514)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629948/job/20279447026)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629468/job/20279421502)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629432/job/20279421291)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629184/job/20279419956)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629835/job/20279423088)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628791/job/20279418234)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628868/job/20279418729)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628843/job/20279418587)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629902/job/20279447011)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629306/job/20279420626)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629519/job/20279422088)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628870/job/20279418777)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630154/job/20279447395)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453628800/job/20279418261)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629846/job/20279423116)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629228/job/20279420281)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629202/job/20279420055)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629594/job/20279422580)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629206/job/20279420059)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453630041/job/20279447268)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7453629177/job/20279419957)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1879296034
> If we're going to include this with Arrow 15, we should get on the doc changes immediately.
OK, I have added the doc change to this PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1882088910
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1882282564
@lidavidm , the javadoc generation failure is now fixed. I updated the maven-javadoc-plugin to a newer version that properly let you exclude files and excluded the module-info.java files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881745373
@github-actions crossbow submit *java verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1426097297
##########
java/maven/module-info-compiler-maven-plugin/src/main/java/org/apache/arrow/maven/plugins/BaseModuleInfoCompilerPlugin.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.maven.plugins;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.Reader;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+import java.util.Optional;
+
+import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.glavo.mic.ModuleInfoCompiler;
+
+/**
+ * Compiles the first module-info.java file in the project purely syntactically.
+ */
+public abstract class BaseModuleInfoCompilerPlugin extends AbstractMojo {
+ protected abstract List<String> getSourceRoots();
+
+ protected abstract boolean skip();
+
+ protected abstract String getOutputDirectory();
+
+ @Override
+ public void execute() throws MojoExecutionException {
+ if (skip()) {
+ getLog().info("Skipping module-info-compiler-maven-plugin");
+ return;
+ }
+
+ Optional<File> moduleInfoFile = findFirstModuleInfo(getSourceRoots());
+ if (moduleInfoFile.isPresent()) {
+ // The compiled module-info.class file goes into target/classes/module-info/main
+ Path outputDir = Paths.get(getOutputDirectory());
+
+ outputDir.toFile().mkdirs();
+ Path targetPath = outputDir.resolve("module-info.class");
+
+ // Invoke the compiler,
+ ModuleInfoCompiler compiler = new ModuleInfoCompiler();
+ try (Reader reader = new InputStreamReader(Files.newInputStream(moduleInfoFile.get().toPath()),
+ StandardCharsets.UTF_8);
+ OutputStream output = Files.newOutputStream(targetPath)) {
+ compiler.compile(reader, output);
+ getLog().info("Successfully wrote module-info.class file.");
+ } catch (IOException ex) {
+ throw new MojoExecutionException("Error compiling module-info.java", ex);
+ }
+ } else {
+ getLog().info("No module-info.java file found. module-info.class file was not generated.");
+ }
+ }
+
+ /**
+ * Finds the first module-info.java file in the set of source directories.
Review Comment:
Noted, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1446149141
##########
java/pom.xml:
##########
@@ -776,6 +787,11 @@
</reports>
</reportSet>
</reportSets>
+ <configuration>
+ <sourceFileExcludes>
+ <sourceFileExclude>**/module-info.java</sourceFileExclude>
+ </sourceFileExcludes>
+ </configuration>
Review Comment:
We may want to document module-info.java in Java 9+ right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881166762
Sorry, I didn't get around to this and the code freeze is today...this might have to slip to arrow 16 since I realized we never checked the other Java builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881763149
Revision: 179cac16b0ad40ad15792fe9a91b41453e581021
Submitted crossbow builds: [ursacomputing/crossbow @ actions-02a1925321](https://github.com/ursacomputing/crossbow/branches/all?query=actions-02a1925321)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719018/job/20276591732)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718945/job/20276588072)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718625/job/20276586416)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720201/job/20276620578)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719051/job/20276588776)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718746/job/20276587097)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718746/job/20276587097)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719660/job/20276592408)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720205/job/20276620580)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719723/job/20276592612)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719723/job/20276592612)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719368/job/20276590956)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718666/job/20276586379)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719253/job/20276590180)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718868/job/20276587490)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718718/job/20276586833)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719632/job/20276592207)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718624/job/20276586308)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719898/job/20276619914)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720369/job/20276620837)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719230/job/20276590058)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719152/job/20276590033)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718961/job/20276588308)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719354/job/20276590819)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718932/job/20276588101)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720241/job/20276620873)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720328/job/20276620883)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718784/job/20276587107)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719375/job/20276590998)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718565/job/20276585882)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718628/job/20276586348)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719716/job/20276592451)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718921/job/20276588092)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720105/job/20276620169)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720066/job/20276620198)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719955/job/20276619906)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719595/job/20276592173)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719369/job/20276591017)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718757/job/20276587108)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719671/job/20276592402)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719144/job/20276590011)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718568/job/20276585875)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719539/job/20276592174)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718884/job/20276587773)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718742/job/20276587110)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718821/job/20276587263)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719135/job/20276589462)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718611/job/20276586254)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719337/job/20276590826)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718731/job/20276586819)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719607/job/20276592192)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719310/job/20276590319)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720178/job/20276620281)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718622/job/20276586464)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718602/job/20276586187)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719697/job/20276592467)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719783/job/20276619904)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719292/job/20276590223)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452720228/job/20276620598)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718555/job/20276585900)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719115/job/20276589391)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719257/job/20276590203)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718927/job/20276588089)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452718954/job/20276588301)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719457/job/20276591173)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719316/job/20276590373)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7452719020/job/20276588747)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425686243
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -142,7 +142,7 @@ public Object run() {
// the static fields above get initialized
final RuntimeException failure = new RuntimeException(
"Failed to initialize MemoryUtil. You must start Java with " +
- "`--add-opens=java.base/java.nio=ALL-UNNAMED` " +
+ "`--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` " +
Review Comment:
Yes, this would be a doc update. A similar change would be necessary for flight-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1426097065
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -142,7 +142,7 @@ public Object run() {
// the static fields above get initialized
final RuntimeException failure = new RuntimeException(
"Failed to initialize MemoryUtil. You must start Java with " +
- "`--add-opens=java.base/java.nio=ALL-UNNAMED` " +
+ "`--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` " +
Review Comment:
should we include it to this PR or file a separate issue for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881164917
@github-actions crossbow submit *java* *verification*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881747284
```
Unable to match any tasks for `*java`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7452605855
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1882096523
Revision: d03c221661afd87bf3e451de3e069bb8b6c7f87a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0cf308b364](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0cf308b364)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117447/job/20283677659)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117348/job/20283675659)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117860/job/20283697450)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117217/job/20283674953)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117382/job/20283675771)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117294/job/20283675214)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116729/job/20283673449)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117694/job/20283677107)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116953/job/20283674102)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455118042/job/20283697795)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116826/job/20283673638)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117923/job/20283697706)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116989/job/20283674249)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116774/job/20283673470)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117147/job/20283674627)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116687/job/20283673261)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117117/job/20283674504)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117863/job/20283697449)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117008/job/20283674301)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117908/job/20283697675)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117554/job/20283676559)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117059/job/20283674427)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455118071/job/20283697853)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117759/job/20283677226)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116965/job/20283674114)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116842/job/20283673702)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117869/job/20283697533)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117392/job/20283675821)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116788/job/20283673475)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117174/job/20283674734)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117204/job/20283674790)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116728/job/20283673364)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117943/job/20283697694)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117335/job/20283675647)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455118291/job/20283697815)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117299/job/20283675257)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117324/job/20283675427)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117300/job/20283675364)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117956/job/20283697845)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117253/job/20283675034)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116998/job/20283674266)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117750/job/20283677248)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117588/job/20283676730)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117832/job/20283697437)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116720/job/20283673324)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117549/job/20283676628)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117764/job/20283677281)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117536/job/20283676422)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116933/job/20283673945)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117439/job/20283675954)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117182/job/20283674695)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116684/job/20283673196)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117322/job/20283675442)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116782/job/20283673468)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116706/job/20283673193)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117871/job/20283697606)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117437/job/20283675957)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116888/job/20283673907)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117654/job/20283677011)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117526/job/20283676346)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117139/job/20283674597)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116857/job/20283673778)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116853/job/20283673734)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117272/job/20283675144)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117582/job/20283676741)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7455117801/job/20283677288)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7455116956/job/20283674036)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881743466
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881182430
Revision: 703f9ef0be268b06ef18a76a00930cb30e65c595
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a825fc1395](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a825fc1395)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188205/job/20265265495)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188369/job/20265264357)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188731/job/20265267375)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188767/job/20265267365)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189487/job/20265271914)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189447/job/20265270833)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189447/job/20265270833)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189454/job/20265271019)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189358/job/20265270463)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189531/job/20265312367)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189696/job/20265313352)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189503/job/20265312094)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188439/job/20265264910)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189191/job/20265269024)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189738/job/20265313892)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188093/job/20265262670)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189662/job/20265313317)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189120/job/20265268753)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189607/job/20265312879)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189520/job/20265312070)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188968/job/20265268463)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188362/job/20265264377)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189706/job/20265313920)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189553/job/20265312449)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188548/job/20265265530)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189407/job/20265270737)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188307/job/20265263935)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188303/job/20265263552)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189366/job/20265270711)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189577/job/20265312790)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188696/job/20265266650)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189681/job/20265313331)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188163/job/20265263212)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188872/job/20265268412)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189281/job/20265270325)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188568/job/20265265757)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189444/job/20265270774)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188558/job/20265265533)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189183/job/20265268856)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189582/job/20265312828)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189208/job/20265269193)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188861/job/20265268316)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188888/job/20265268444)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188661/job/20265266663)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188392/job/20265264762)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188542/job/20265265513)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188436/job/20265265015)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189624/job/20265313323)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189184/job/20265268858)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188079/job/20265262717)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189254/job/20265270067)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189206/job/20265269282)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189241/job/20265270140)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188744/job/20265267377)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188619/job/20265265799)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188119/job/20265263074)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189701/job/20265313888)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189483/job/20265271894)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189499/job/20265312043)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189008/job/20265268591)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189329/job/20265270415)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188394/job/20265265091)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188245/job/20265263497)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188841/job/20265268189)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188419/job/20265264725)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7449188126/job/20265263076)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7449189266/job/20265270064)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1446789010
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/CountingAllocationListener.java:
##########
@@ -58,6 +64,10 @@ public void onAllocation(long size) {
@Override
public boolean onFailedAllocation(long size, AllocationOutcome outcome) {
if (expandOnFail) {
+ if (expandAlloc == null) {
Review Comment:
Could possibly use Preconditions.checkState for this (since it's been annotated such that CheckerFramework should understand it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425684826
##########
java/maven/module-info-compiler-maven-plugin/src/main/java/org/apache/arrow/maven/plugins/BaseModuleInfoCompilerPlugin.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.maven.plugins;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.Reader;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+import java.util.Optional;
+
+import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.glavo.mic.ModuleInfoCompiler;
+
+/**
+ * Compiles the first module-info.java file in the project purely syntactically.
+ */
+public abstract class BaseModuleInfoCompilerPlugin extends AbstractMojo {
+ protected abstract List<String> getSourceRoots();
+
+ protected abstract boolean skip();
+
+ protected abstract String getOutputDirectory();
+
+ @Override
+ public void execute() throws MojoExecutionException {
+ if (skip()) {
+ getLog().info("Skipping module-info-compiler-maven-plugin");
+ return;
+ }
+
+ Optional<File> moduleInfoFile = findFirstModuleInfo(getSourceRoots());
+ if (moduleInfoFile.isPresent()) {
+ // The compiled module-info.class file goes into target/classes/module-info/main
+ Path outputDir = Paths.get(getOutputDirectory());
+
+ outputDir.toFile().mkdirs();
+ Path targetPath = outputDir.resolve("module-info.class");
+
+ // Invoke the compiler,
+ ModuleInfoCompiler compiler = new ModuleInfoCompiler();
+ try (Reader reader = new InputStreamReader(Files.newInputStream(moduleInfoFile.get().toPath()),
+ StandardCharsets.UTF_8);
+ OutputStream output = Files.newOutputStream(targetPath)) {
+ compiler.compile(reader, output);
+ getLog().info("Successfully wrote module-info.class file.");
+ } catch (IOException ex) {
+ throw new MojoExecutionException("Error compiling module-info.java", ex);
+ }
+ } else {
+ getLog().info("No module-info.java file found. module-info.class file was not generated.");
+ }
+ }
+
+ /**
+ * Finds the first module-info.java file in the set of source directories.
Review Comment:
A JAR can only have one module-info file. We are arbitrarily taking the first. I haven't checked if the maven-compiler-plugin has the same behavior or if it errors out when there are multiple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425852873
##########
java/pom.xml:
##########
@@ -870,7 +897,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ <argLine>--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED</argLine>
Review Comment:
Just to be sure, do we still need ALL-UNNAMED?
##########
java/memory/memory-core/pom.xml:
##########
@@ -54,6 +53,30 @@
</build>
<profiles>
+ <profile>
+ <id>error-prone-jdk11+</id>
Review Comment:
how is this profile related to ErrorProne?
##########
java/memory/memory-unsafe/src/test/java/org/apache/arrow/memory/unsafe/TestUnsafeAllocationManager.java:
##########
@@ -15,20 +15,25 @@
* limitations under the License.
*/
-package org.apache.arrow.memory;
+package org.apache.arrow.memory.unsafe;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import org.apache.arrow.memory.AllocationManager;
+import org.apache.arrow.memory.ArrowBuf;
+import org.apache.arrow.memory.BufferLedger;
+import org.apache.arrow.memory.RootAllocator;
+import org.apache.arrow.memory.unsafe.UnsafeAllocationManager;
import org.junit.Test;
/**
* Test cases for {@link UnsafeAllocationManager}.
*/
public class TestUnsafeAllocationManager {
- private BaseAllocator createUnsafeAllocator() {
- return new RootAllocator(BaseAllocator.configBuilder().allocationManagerFactory(UnsafeAllocationManager.FACTORY)
+ private RootAllocator createUnsafeAllocator() {
Review Comment:
Ideally we never refer to RootAllocator (or BaseAllocator) as a type, only BufferAllocator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881167831
```
Unable to match any tasks for `*verification*`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7449130434
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881824605
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425061578
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestForeignAllocation.java:
##########
@@ -23,6 +23,13 @@
import java.util.ArrayList;
import java.util.List;
+import org.apache.arrow.memory.AllocationListener;
+import org.apache.arrow.memory.AllocationOutcome;
+import org.apache.arrow.memory.ArrowBuf;
+import org.apache.arrow.memory.BufferAllocator;
+import org.apache.arrow.memory.ForeignAllocation;
+import org.apache.arrow.memory.OutOfMemoryException;
+import org.apache.arrow.memory.RootAllocator;
Review Comment:
seems like these are not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425054730
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -142,7 +142,7 @@ public Object run() {
// the static fields above get initialized
final RuntimeException failure = new RuntimeException(
"Failed to initialize MemoryUtil. You must start Java with " +
- "`--add-opens=java.base/java.nio=ALL-UNNAMED` " +
+ "`--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` " +
Review Comment:
would this require a documentation update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1834464821
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1887209452
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e7ab540ed9901d19ebde81f43e8417562ef8a334.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20386998628) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1442372645
##########
java/memory/memory-core/pom.xml:
##########
@@ -54,6 +53,30 @@
</build>
<profiles>
+ <profile>
+ <id>error-prone-jdk11+</id>
Review Comment:
Changed the profile to be jdk11+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881830464
Revision: 7743b44540f71e15fb9960d9a58793804c136235
Submitted crossbow builds: [ursacomputing/crossbow @ actions-86e96e8e6e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-86e96e8e6e)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228038/job/20278159887)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228507/job/20278187289)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226918/job/20278154440)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227814/job/20278157910)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226772/job/20278154012)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226428/job/20278152648)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228228/job/20278186948)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226240/job/20278152000)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227263/job/20278155688)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226208/job/20278152355)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226267/job/20278152277)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227528/job/20278156704)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226648/job/20278153553)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228449/job/20278187139)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226978/job/20278154389)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226538/job/20278153092)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227745/job/20278157541)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226687/job/20278153381)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227749/job/20278157606)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226322/job/20278152584)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226595/job/20278153405)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226233/job/20278152128)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228219/job/20278186797)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228109/job/20278158503)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228136/job/20278186725)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226713/job/20278153616)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228233/job/20278186895)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226387/job/20278152640)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227605/job/20278156902)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227419/job/20278156340)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227282/job/20278155567)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227098/job/20278154765)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226288/job/20278152387)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226209/job/20278151943)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228504/job/20278187210)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228041/job/20278158353)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227149/job/20278154929)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226514/job/20278153127)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228445/job/20278187187)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227400/job/20278156078)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226696/job/20278153519)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226724/job/20278153678)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227670/job/20278157168)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228562/job/20278187322)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227968/job/20278158037)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226392/job/20278152647)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227793/job/20278157810)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228192/job/20278186767)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228595/job/20278187475)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226242/job/20278151939)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228112/job/20278158568)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227678/job/20278157002)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227281/job/20278155611)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227514/job/20278156375)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227200/job/20278155400)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227924/job/20278158035)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227719/job/20278157439)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226813/job/20278153971)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453228304/job/20278187106)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227164/job/20278154882)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226916/job/20278154025)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226503/job/20278153072)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226424/job/20278152804)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453226245/job/20278151984)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227254/job/20278155735)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227649/job/20278156905)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7453227019/job/20278154593)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881970682
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1839493249
It seems these changes are not usable without modularizing memory-core. arrow-vector makes use of Preconditions and BufferAllocator heavily. Since these are declared in an unnamed module (memory-core), the user has to add --open-reads=org.apache.arrow.vector=ALL-UNNAMED. This doesn't fail when running arrow-vector tests because surefire adds this automatically for this module but fails any other test that depends on arrow-vector.
The Preconditions class could be moved to a new utils module, but that doesn't deal with BufferAllocator which is very much part of memory-core out of necessity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1424874147
##########
java/maven/module-info-compiler-maven-plugin/pom.xml:
##########
@@ -0,0 +1,130 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.arrow.maven.plugins</groupId>
+ <artifactId>arrow-maven-plugins</artifactId>
+ <version>15.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>module-info-compiler-maven-plugin</artifactId>
+ <packaging>maven-plugin</packaging>
+
+ <name>Module Info Compiler Maven Plugin</name>
+
+ <url>https://arrow.apache.org</url>
+
+ <prerequisites>
+ <maven>${maven.version}</maven>
+ </prerequisites>
+
+ <properties>
+ <maven.version>3.3.9</maven.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.glavo</groupId>
+ <artifactId>module-info-compiler</artifactId>
+ <version>2.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-plugin-api</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-core</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-artifact</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugin-tools</groupId>
+ <artifactId>maven-plugin-annotations</artifactId>
+ <version>3.6.0</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <pluginManagement><!-- lock down plugins versions to avoid using Maven defaults (may be moved to parent pom) -->
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>3.6.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>3.0.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <version>2.5.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-deploy-plugin</artifactId>
+ <version>2.8.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-invoker-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>3.6.0</version>
+ <configuration>
+ <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
+ </configuration>
+ <executions>
+ <execution>
+ <id>mojo-descriptor</id>
+ <goals>
+ <goal>descriptor</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>help-goal</id>
+ <goals>
+ <goal>helpmojo</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+
+</project>
Review Comment:
new line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1834465332
:warning: GitHub issue #38998 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1442372257
##########
java/maven/module-info-compiler-maven-plugin/pom.xml:
##########
@@ -0,0 +1,130 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.arrow.maven.plugins</groupId>
+ <artifactId>arrow-maven-plugins</artifactId>
+ <version>15.0.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>module-info-compiler-maven-plugin</artifactId>
+ <packaging>maven-plugin</packaging>
+
+ <name>Module Info Compiler Maven Plugin</name>
+
+ <url>https://arrow.apache.org</url>
+
+ <prerequisites>
+ <maven>${maven.version}</maven>
+ </prerequisites>
+
+ <properties>
+ <maven.version>3.3.9</maven.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.glavo</groupId>
+ <artifactId>module-info-compiler</artifactId>
+ <version>2.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-plugin-api</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-core</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-artifact</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${maven.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugin-tools</groupId>
+ <artifactId>maven-plugin-annotations</artifactId>
+ <version>3.6.0</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <pluginManagement><!-- lock down plugins versions to avoid using Maven defaults (may be moved to parent pom) -->
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>3.6.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>3.0.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <version>2.5.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-deploy-plugin</artifactId>
+ <version>2.8.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-invoker-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>3.6.0</version>
+ <configuration>
+ <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
+ </configuration>
+ <executions>
+ <execution>
+ <id>mojo-descriptor</id>
+ <goals>
+ <goal>descriptor</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>help-goal</id>
+ <goals>
+ <goal>helpmojo</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+
+</project>
Review Comment:
Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1424951574
##########
java/maven/module-info-compiler-maven-plugin/src/main/java/org/apache/arrow/maven/plugins/BaseModuleInfoCompilerPlugin.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.maven.plugins;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStream;
+import java.io.Reader;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.List;
+import java.util.Optional;
+
+import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.glavo.mic.ModuleInfoCompiler;
+
+/**
+ * Compiles the first module-info.java file in the project purely syntactically.
+ */
+public abstract class BaseModuleInfoCompilerPlugin extends AbstractMojo {
+ protected abstract List<String> getSourceRoots();
+
+ protected abstract boolean skip();
+
+ protected abstract String getOutputDirectory();
+
+ @Override
+ public void execute() throws MojoExecutionException {
+ if (skip()) {
+ getLog().info("Skipping module-info-compiler-maven-plugin");
+ return;
+ }
+
+ Optional<File> moduleInfoFile = findFirstModuleInfo(getSourceRoots());
+ if (moduleInfoFile.isPresent()) {
+ // The compiled module-info.class file goes into target/classes/module-info/main
+ Path outputDir = Paths.get(getOutputDirectory());
+
+ outputDir.toFile().mkdirs();
+ Path targetPath = outputDir.resolve("module-info.class");
+
+ // Invoke the compiler,
+ ModuleInfoCompiler compiler = new ModuleInfoCompiler();
+ try (Reader reader = new InputStreamReader(Files.newInputStream(moduleInfoFile.get().toPath()),
+ StandardCharsets.UTF_8);
+ OutputStream output = Files.newOutputStream(targetPath)) {
+ compiler.compile(reader, output);
+ getLog().info("Successfully wrote module-info.class file.");
+ } catch (IOException ex) {
+ throw new MojoExecutionException("Error compiling module-info.java", ex);
+ }
+ } else {
+ getLog().info("No module-info.java file found. module-info.class file was not generated.");
+ }
+ }
+
+ /**
+ * Finds the first module-info.java file in the set of source directories.
Review Comment:
@jduo Just for the curiosity, why are we just checking the first `module-info.java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881448117
> Sorry, I didn't get around to this and the code freeze is today...this might have to slip to arrow 16 since I realized we never checked the other Java builds
No problem. It is probably best this gets completed in the same release as #39001 too so this gives a bit more time to examine that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1882284311
> It appears Javadocs builds fail:
>
> ```
> Error: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar (attach-javadocs) on project arrow-memory-core: MavenReportException: Error while generating Javadoc:
> Error: Exit code: 1 - /Users/runner/work/crossbow/crossbow/arrow/java/memory/memory-core/src/main/java/module-info.java:18: error: class, interface, or enum expected
> Error: module org.apache.arrow.memory.core {
> Error: ^
> ```
This issue is now fixed by updating maven-javadoc-plugin to a version that allows source exclusions properly and excluding module-info.java files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #39011:
URL: https://github.com/apache/arrow/pull/39011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425059595
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java:
##########
@@ -448,73 +443,73 @@ public ArrowBuf empty() {
@Test
public void testRootAllocator_listeners() throws Exception {
CountingAllocationListener l1 = new CountingAllocationListener();
- assertEquals(0, l1.getNumPreCalls());
- assertEquals(0, l1.getNumCalls());
- assertEquals(0, l1.getNumReleaseCalls());
- assertEquals(0, l1.getNumChildren());
- assertEquals(0, l1.getTotalMem());
+ Assert.assertEquals(0, l1.getNumPreCalls());
Review Comment:
nit: should we make `l1` -> `listner1`. I know it is not related to this PR `11` vs `l1`, just for the readability. And may be the following names too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425985991
##########
java/pom.xml:
##########
@@ -870,7 +897,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
- <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ <argLine>--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED</argLine>
Review Comment:
Yes, it's still needed. Netty utilizes it for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425986472
##########
java/memory/memory-core/pom.xml:
##########
@@ -54,6 +53,30 @@
</build>
<profiles>
+ <profile>
+ <id>error-prone-jdk11+</id>
Review Comment:
This profile is really the "default" build profile for JDK9+. It doesn't relate to error-prone specifically. Would it be better to have a separate profile with the same activation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1442367738
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:
##########
@@ -142,7 +142,7 @@ public Object run() {
// the static fields above get initialized
final RuntimeException failure = new RuntimeException(
"Failed to initialize MemoryUtil. You must start Java with " +
- "`--add-opens=java.base/java.nio=ALL-UNNAMED` " +
+ "`--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` " +
Review Comment:
I think it's best to do a separate PR for doc updates around this since there are a few of these across multiple PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1879144262
If we're going to include this with Arrow 15, we should get on the doc changes immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881882109
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881746600
Revision: 179cac16b0ad40ad15792fe9a91b41453e581021
Submitted crossbow builds: [ursacomputing/crossbow @ actions-89a755d1ef](https://github.com/ursacomputing/crossbow/branches/all?query=actions-89a755d1ef)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604642/job/20276242682)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604669/job/20276241237)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604704/job/20276241480)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604681/job/20276241225)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604694/job/20276241443)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7452604683/job/20276241240)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881300654
It appears Javadocs builds fail:
```
Error: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar (attach-javadocs) on project arrow-memory-core: MavenReportException: Error while generating Javadoc:
Error: Exit code: 1 - /Users/runner/work/crossbow/crossbow/arrow/java/memory/memory-core/src/main/java/module-info.java:18: error: class, interface, or enum expected
Error: module org.apache.arrow.memory.core {
Error: ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881757756
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881974267
Revision: a557361fb104c7cfb38aef0c5fe147ea91010117
Submitted crossbow builds: [ursacomputing/crossbow @ actions-901262bcb8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-901262bcb8)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367141/job/20281557410)|
|verify-rc-binaries-apt-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366967/job/20281555768)|
|verify-rc-binaries-binary-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367174/job/20281556632)|
|verify-rc-binaries-jars-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454368026/job/20281582737)|
|verify-rc-binaries-jars-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367518/job/20281558712)|
|verify-rc-binaries-jars-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367351/job/20281557633)|
|verify-rc-binaries-jars-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367378/job/20281557695)|
|verify-rc-binaries-wheels-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366932/job/20281555257)|
|verify-rc-binaries-wheels-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367827/job/20281560094)|
|verify-rc-binaries-wheels-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366995/job/20281555721)|
|verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367928/job/20281560777)|
|verify-rc-binaries-wheels-macos-11-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367615/job/20281559285)|
|verify-rc-binaries-wheels-macos-11-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367830/job/20281560017)|
|verify-rc-binaries-wheels-macos-12-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367564/job/20281559132)|
|verify-rc-binaries-wheels-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367130/job/20281556193)|
|verify-rc-binaries-yum-linux-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367405/job/20281558130)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367489/job/20281558603)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367840/job/20281560102)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367387/job/20281557703)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367616/job/20281559271)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367496/job/20281558691)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366978/job/20281555637)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367401/job/20281557998)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367087/job/20281556128)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367295/job/20281557497)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367329/job/20281557557)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367813/job/20281559939)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367030/job/20281555946)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366925/job/20281555264)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366930/job/20281555256)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367693/job/20281559784)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367134/job/20281556364)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367354/job/20281557647)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367252/job/20281557482)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367397/job/20281557993)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367266/job/20281557106)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367305/job/20281557181)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367712/job/20281559793)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367989/job/20281560857)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367396/job/20281557985)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366981/job/20281555683)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367502/job/20281558694)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454368024/job/20281560870)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367080/job/20281556038)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367242/job/20281557415)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367160/job/20281556362)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367473/job/20281558543)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454368053/job/20281582745)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367824/job/20281559951)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367831/job/20281559954)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367877/job/20281560114)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367964/job/20281560799)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367166/job/20281556640)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367301/job/20281557561)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367732/job/20281559809)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366950/job/20281555502)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367096/job/20281556171)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367596/job/20281559261)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367685/job/20281559794)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367176/job/20281556862)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367406/job/20281557986)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367534/job/20281558800)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454368029/job/20281582752)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367591/job/20281559149)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367085/job/20281556161)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7454366928/job/20281555263)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/7454367055/job/20281555940)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1446504865
##########
java/pom.xml:
##########
@@ -776,6 +787,11 @@
</reports>
</reportSet>
</reportSets>
+ <configuration>
+ <sourceFileExcludes>
+ <sourceFileExclude>**/module-info.java</sourceFileExclude>
+ </sourceFileExcludes>
+ </configuration>
Review Comment:
Yes, I think we should wait until JDK8 support is dropped to do this though. We run into similar issues as we ran into while compiling (need to set release to 9, but that breaks how we utilize Unsafe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1425061578
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestForeignAllocation.java:
##########
@@ -23,6 +23,13 @@
import java.util.ArrayList;
import java.util.List;
+import org.apache.arrow.memory.AllocationListener;
+import org.apache.arrow.memory.AllocationOutcome;
+import org.apache.arrow.memory.ArrowBuf;
+import org.apache.arrow.memory.BufferAllocator;
+import org.apache.arrow.memory.ForeignAllocation;
+import org.apache.arrow.memory.OutOfMemoryException;
+import org.apache.arrow.memory.RootAllocator;
Review Comment:
seems like these are not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1426895563
##########
java/memory/memory-core/pom.xml:
##########
@@ -54,6 +53,30 @@
</build>
<profiles>
+ <profile>
+ <id>error-prone-jdk11+</id>
Review Comment:
Ah, then just rename it so it's clear - the "error-prone" profiles we have are meant for running the ErrorProne static analyzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1442372526
##########
java/memory/memory-unsafe/src/test/java/org/apache/arrow/memory/unsafe/TestUnsafeAllocationManager.java:
##########
@@ -15,20 +15,25 @@
* limitations under the License.
*/
-package org.apache.arrow.memory;
+package org.apache.arrow.memory.unsafe;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import org.apache.arrow.memory.AllocationManager;
+import org.apache.arrow.memory.ArrowBuf;
+import org.apache.arrow.memory.BufferLedger;
+import org.apache.arrow.memory.RootAllocator;
+import org.apache.arrow.memory.unsafe.UnsafeAllocationManager;
import org.junit.Test;
/**
* Test cases for {@link UnsafeAllocationManager}.
*/
public class TestUnsafeAllocationManager {
- private BaseAllocator createUnsafeAllocator() {
- return new RootAllocator(BaseAllocator.configBuilder().allocationManagerFactory(UnsafeAllocationManager.FACTORY)
+ private RootAllocator createUnsafeAllocator() {
Review Comment:
Changed to return BufferAllocator instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #39011:
URL: https://github.com/apache/arrow/pull/39011#discussion_r1442372410
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java:
##########
@@ -448,73 +443,73 @@ public ArrowBuf empty() {
@Test
public void testRootAllocator_listeners() throws Exception {
CountingAllocationListener l1 = new CountingAllocationListener();
- assertEquals(0, l1.getNumPreCalls());
- assertEquals(0, l1.getNumCalls());
- assertEquals(0, l1.getNumReleaseCalls());
- assertEquals(0, l1.getNumChildren());
- assertEquals(0, l1.getTotalMem());
+ Assert.assertEquals(0, l1.getNumPreCalls());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38998: [Java] Build memory-core and memory-unsafe as JPMS modules [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #39011:
URL: https://github.com/apache/arrow/pull/39011#issuecomment-1881174158
@github-actions crossbow submit *java* *verify*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org