You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/28 13:42:21 UTC
[GitHub] [flink] ferenc-csaky opened a new pull request, #19606: [FLINK-27441] fix "nzScroll" calculations
ferenc-csaky opened a new pull request, #19606:
URL: https://github.com/apache/flink/pull/19606
## What is the purpose of the change
Fixes hidden scrollbar for some UI elements, where CSS calculate was based on a percentage. The current Angular version has a bug, so in those cases the scrollbar is hidden and scrolling is not possible.
## Brief change log
Changed `calc ( X% ...)` to `calc( Xvh ...)`, which solves this problem.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113034912
The change looks good basically but I've some minor comments.
1.
> The current Angular version has a bug
Do we have a link for the bug?
2.
I would mention manual testing steps in the "Verifying this change" area. Namely on which page which UI element needs to be checked (I know it but it would be good to let others know).
3.
Could you attach a before and after picture just to double check that we see the same thing?
I've started the manual testing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi merged pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #19606:
URL: https://github.com/apache/flink/pull/19606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ferenc-csaky commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
ferenc-csaky commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113086239
Tanks for the comments.
1. Yes, I linked it to the corresponding Jira, but here it is: https://github.com/NG-ZORRO/ng-zorro-antd/issues/3090
2. I tested this with Accumulators. I prepared a dummy Flink job and I added 50 dummy `IntCounter` accumulators to it, so it would not fit to the screen. After I started the job, the "Accumulators" tab has no scrollbar. The CSS can be changed in the browser, so it is easy to test this on the fly.
3.
Original state:
Fixed state:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113144117
@mbalassi @gyfora could you have a look plz?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113053431
Oh and almost forgot, please add component to the title of the PR like `[FLINK-27441][webfrontend]...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1112225509
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdcfcdb311970e9d97472b9ffa478ee56c931e75",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdcfcdb311970e9d97472b9ffa478ee56c931e75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdcfcdb311970e9d97472b9ffa478ee56c931e75 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ferenc-csaky commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
ferenc-csaky commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113023162
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #19606:
URL: https://github.com/apache/flink/pull/19606#issuecomment-1113531337
Thanks @ferenc-csaky and @gaborgsomogyi. Will merge on Monday after a quick test unless anyone raises an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org