[GitHub] [incubator-mxnet] nswamy edited a comment on issue #14629: [MXNET-1333] Estimator and Fit API

[GitBox <gi...@apache.org>]

nswamy edited a comment on issue #14629: [MXNET-1333] Estimator and Fit API
URL: https://github.com/apache/incubator-mxnet/pull/14629#issuecomment-480440884
 
 
   I am not sure I understand the concerns, 
   
   What is the problem with 1) ?
   
   For 2), the user can create custom event Handler taking objects whatever it needs to keep track of. 
   ```
   MyEventHandler
   def __init__(self, whatever1, whatever2):
        self.whatever1 = whatever1, ...
   
   def train_begin():
        # dowhatever using self.whatever1
   ``` 
   
   Given that the fit API is targeted at novice users, I think 3) is going to make it unnecessarily cumbersome. 
   
   What is the benefit of using the Forward Hook approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services