[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4981: [Relay, Topi, TF Frontend] Isfinite operator

[GitBox <gi...@apache.org>]

jwfromm commented on a change in pull request #4981: [Relay, Topi, TF Frontend] Isfinite operator
URL: https://github.com/apache/incubator-tvm/pull/4981#discussion_r392545741
 
 

 ##########
 File path: include/tvm/tir/expr.h
 ##########
 @@ -829,6 +829,7 @@ class CallNode : public PrimExprNode {
   static constexpr const char* glsl_texture_store = "glsl_texture_store";
   static constexpr const char* prefetch = "prefetch";
   static constexpr const char* isnan = "isnan";
 
 Review comment:
   Is it worth adding an `isinf` operator to this PR? That way we can check for both halves of isfinite separately if needed. I'm not sure if you'd ever need to check for just infinity rather than both nan and infinity though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services