[GitHub] [netbeans] eirikbakke commented on a change in pull request #1846: [NETBEANS-3428] FlatLaf: fixes for form designer

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #1846: [NETBEANS-3428] FlatLaf: fixes for form designer
URL: https://github.com/apache/netbeans/pull/1846#discussion_r363101929
 
 

 ##########
 File path: java/form/src/org/netbeans/modules/form/FormLoaderSettings.java
 ##########
 @@ -472,12 +472,13 @@ public void setPaletteInToolBar(boolean value) {
      * @return background color of the designer.
      */
     public java.awt.Color getFormDesignerBackgroundColor() {
-        Color defaultBackground = UIManager.getColor( "Tree.background" ); //NOI18N
-        if( null == defaultBackground )
+        Color defaultBackground = UIManager.getColor("nb.formdesigner.designer.background"); //NOI18N
+        if (defaultBackground == null)
+            defaultBackground = UIManager.getColor("Tree.background"); //NOI18N
+        if (defaultBackground == null)
 
 Review comment:
   Which LAF is used in the form designer? Is it the same as the IDE? In that case, should the background color not be taken from the LAF rather than from a special constant? (Also, I wonder why "Tree.background" was used previously instead of the default JPanel background.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists