You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/04/21 17:55:15 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #576: [YUNIKORN-1704] Allow application FSM transition from Recovering to Rejected
craigcondit opened a new pull request, #576:
URL: https://github.com/apache/yunikorn-k8shim/pull/576
The application state machine in the shim does not allow Rejected as a transition from the Recovering state, resulting in the application being stuck in Recovering.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1704
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #576: [YUNIKORN-1704] Allow application FSM transition from Recovering to Rejected
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #576:
URL: https://github.com/apache/yunikorn-k8shim/pull/576#issuecomment-1518175513
## [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#576](https://codecov.io/gh/apache/yunikorn-k8shim/pull/576?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abf3565) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/36040b40c50776e2200f51a85acbfc80aecd99f1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36040b4) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 47 47
Lines 7928 7928
=======================================
Hits 5544 5544
Misses 2177 2177
Partials 207 207
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/application\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `90.18% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #576: [YUNIKORN-1704] Allow application FSM transition from Recovering to Rejected
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #576: [YUNIKORN-1704] Allow application FSM transition from Recovering to Rejected
URL: https://github.com/apache/yunikorn-k8shim/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org