You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/01 23:49:18 UTC
[jira] [Commented] (TS-4248) assertions triggered by metric type
changes
[ https://issues.apache.org/jira/browse/TS-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174557#comment-15174557 ]
ASF GitHub Bot commented on TS-4248:
------------------------------------
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/509
TS-4248: allow metrics to change type on upgrade
New software versions can alter the type of metrics, but when that
happens, the metric from the previous software version has already
been restored from persistence. In this case, we can allow the type
of the metric to change to match the new registration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver TS-4248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit 59de7b3becc431a27d1c69993917165fe1eab922
Author: James Peach <jp...@apache.org>
Date: 2016-02-23T05:43:41Z
TS-4248: allow metrics to change type on upgrade
New software versions can alter the type of metrics, but when that
happens, the metric from the previous software version has already
been restored from persistence. In this case, we can allow the type
of the metric to change to match the new registration.
----
> assertions triggered by metric type changes
> -------------------------------------------
>
> Key: TS-4248
> URL: https://issues.apache.org/jira/browse/TS-4248
> Project: Traffic Server
> Issue Type: Bug
> Components: Metrics
> Reporter: James Peach
>
> If we alter the data type of a metric, the records layer asserts because the data type of the previously restored metric is not the same. In this case, we should allow the registration and just update the metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)