[GitHub] [airflow] hussein-awala commented on a diff in pull request #32630: Improve getting the query count in Airflow API endpoints

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #32630:
URL: https://github.com/apache/airflow/pull/32630#discussion_r1264651918


##########
airflow/api_connexion/parameters.py:
##########
@@ -125,3 +126,9 @@ def apply_sorting(
     else:
         order_by = f"{lstriped_orderby} asc"
     return query.order_by(text(order_by))
+
+
+def get_query_count(query_stmt: sqlalchemy.sql.selectable.Select, session: sqlalchemy.orm.Session) -> int:

Review Comment:
   > May be a good idea to put this in airflow.utils.db instead? Importing this in airflow.www.views feels wrong.
   
   I agree, I just moved it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org