You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "HuangZhenQiu (via GitHub)" <gi...@apache.org> on 2026/03/21 00:48:50 UTC
[PR] feat: add Flink source reader function for cdc splits [hudi]
HuangZhenQiu opened a new pull request, #18361:
URL: https://github.com/apache/hudi/pull/18361
### Describe the issue this Pull Request addresses
Support read from cdc splits in Hudi Flink Source V2
### Summary and Changelog
1. Add HoodieCdcSourceSplit
2. Add HoodieCdcSplitReaderFunction for read from HoodieCdcSourceSplit with Hudi APIs
3. Integrate CDC mode in HoodieTableSource for flink source v2
4. Add test cases for new classes
### Impact
none
### Risk Level
none
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101886721
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.19%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 59.19% -9.28%
+ Complexity 27472 23381 -4091
============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
============================================
- Hits 90820 77246 -13574
- Misses 34784 46890 +12106
+ Partials 7051 6363 -688
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.03% <ø> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108220382
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|4|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.24% -20.14%
+ Complexity 27505 16297 -11208
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 53296 -37604
- Misses 34966 51650 +16684
+ Partials 7060 5524 -1536
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123863361
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.13859%` with `398 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.98% | [381 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.24% -1.14%
+ Complexity 27505 27211 -294
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 89865 -1037
- Misses 34964 36634 +1670
- Partials 7060 7133 +73
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <15.13%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <ø> (-3.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.58% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.98% <3.98%> (ø)` | |
... and [196 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123767159
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.29% -20.09%
+ Complexity 27505 16332 -11173
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53400 -37502
- Misses 34964 51636 +16672
+ Partials 7060 5524 -1536
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129197379
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.17%
+ Complexity 27505 24749 -2756
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 81856 -9046
- Misses 34964 44993 +10029
+ Partials 7060 6864 -196
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129281692
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.37%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.37% -1.01%
+ Complexity 27505 27270 -235
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 90090 -812
- Misses 34964 36499 +1535
- Partials 7060 7124 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-3.64%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4130942478
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131714088
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 61.21% -7.17%
+ Complexity 27573 24752 -2821
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 81861 -9261
- Misses 35093 45002 +9909
+ Partials 7053 6866 -187
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131732252
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.75%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 65.75% -2.63%
+ Complexity 27573 26567 -1006
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 87930 -3192
- Misses 35093 38525 +3432
- Partials 7053 7274 +221
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.30%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [366 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128660620
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.19% -1.19%
+ Complexity 27505 27213 -292
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 89853 -1049
- Misses 34964 36716 +1752
- Partials 7060 7144 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <ø> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <ø> (-0.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [209 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129781554
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.28%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|1|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 59.28% -9.09%
+ Complexity 27573 23566 -4007
============================================
Files 2433 2406 -27
Lines 133268 131161 -2107
Branches 16034 15526 -508
============================================
- Hits 91122 77763 -13359
- Misses 35093 46823 +11730
+ Partials 7053 6575 -478
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.83% <ø> (-14.91%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [671 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129803568
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.51%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 58.51% -9.86%
+ Complexity 27573 23680 -3893
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 78258 -12864
- Misses 35093 48815 +13722
+ Partials 7053 6656 -397
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [656 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131678392
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.86%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.86% -22.51%
+ Complexity 27573 15206 -12367
=============================================
Files 2433 1965 -468
Lines 133268 108028 -25240
Branches 16034 13361 -2673
=============================================
- Hits 91122 49552 -41570
- Misses 35093 53294 +18201
+ Partials 7053 5182 -1871
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <ø> (-12.50%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1565 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131661835
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 54.17% -14.21%
+ Complexity 27573 12185 -15388
=============================================
Files 2433 1422 -1011
Lines 133268 70035 -63233
Branches 16034 7804 -8230
=============================================
- Hits 91122 37940 -53182
+ Misses 35093 28729 -6364
+ Partials 7053 3366 -3687
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1780 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #18361:
URL: https://github.com/apache/hudi/pull/18361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129957241
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.20%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
+ Hits 91122 91174 +52
- Misses 35093 35489 +396
- Partials 7053 7066 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <ø> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120520839
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.75%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.75% -2.63%
+ Complexity 27505 26543 -962
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 87834 -3068
- Misses 34964 38462 +3498
- Partials 7060 7275 +215
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [381 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120488810
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.03%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|4|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.03% -20.36%
+ Complexity 27505 16191 -11314
=============================================
Files 2428 1994 -434
Lines 132926 110506 -22420
Branches 16000 13896 -2104
=============================================
- Hits 90902 53080 -37822
- Misses 34964 51955 +16991
+ Partials 7060 5471 -1589
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124167803
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.14% -0.24%
- Complexity 27505 27574 +69
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
+ Hits 90902 91069 +167
- Misses 34964 35509 +545
+ Partials 7060 7058 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <ø> (-0.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2985289160
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -530,10 +531,8 @@ private static class DataLogFileIterator implements ClosableIterator<RowData> {
this.tableSchema = tableSchema;
this.maxCompactionMemoryInBytes = maxCompactionMemoryInBytes;
this.imageManager = imageManager;
- this.projection = requiredRowType.equals(tableSchema.getAvroSchema().getFields().size() == requiredRowType.getFieldCount()
- ? requiredRowType : null)
- ? null
- : RowDataProjection.instance(requiredRowType, requiredPositions);
+ this.projection = HoodieSchemaConverter.convertToRowType(tableSchema).equals(requiredRowType)
Review Comment:
can we introudce `MergeOnReadTableState` juse like before, the conversion is risky for minor discrepancies like column nullability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123772375
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.13859%` with `398 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.22%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.98% | [381 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.22% -7.17%
+ Complexity 27505 24742 -2763
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 81813 -9089
- Misses 34964 44959 +9995
+ Partials 7060 6860 -200
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <15.13%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.58% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.98% <3.98%> (ø)` | |
... and [552 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129266052
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129770792
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.85% -22.52%
+ Complexity 27573 15204 -12369
=============================================
Files 2433 1965 -468
Lines 133268 108037 -25231
Branches 16034 13357 -2677
=============================================
- Hits 91122 49542 -41580
- Misses 35093 53314 +18221
+ Partials 7053 5181 -1872
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128623826
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.75%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.75% -2.64%
+ Complexity 27505 26569 -936
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 87923 -2979
- Misses 34964 38519 +3555
- Partials 7060 7271 +211
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <ø> (-16.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <ø> (-0.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [383 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129893041
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.20%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
+ Hits 91122 91173 +51
- Misses 35093 35490 +397
- Partials 7053 7066 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <ø> (-0.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131705950
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 61.21% -7.17%
+ Complexity 27573 24752 -2821
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 81861 -9261
- Misses 35093 45002 +9909
+ Partials 7053 6866 -187
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124186577
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.21%
- Complexity 27505 27589 +84
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
+ Hits 90902 91110 +208
- Misses 34964 35470 +506
+ Partials 7060 7056 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [42 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129806374
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.52%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 58.52% -9.86%
+ Complexity 27573 23680 -3893
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 78259 -12863
- Misses 35093 48815 +13722
+ Partials 7053 6655 -398
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [656 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120569346
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.23%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.23% -1.15%
+ Complexity 27505 27198 -307
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 89812 -1090
- Misses 34964 36614 +1650
- Partials 7060 7145 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-3.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [199 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "HuangZhenQiu (via GitHub)" <gi...@apache.org>.
HuangZhenQiu commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2983313932
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1054 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.RowDataProjection;
+import org.apache.hudi.util.StreamerUtil;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final HoodieSchema tableSchema;
+ private final HoodieSchema requiredSchema;
+ private final RowType rowType;
+ private final RowType requiredRowType;
+ private final int[] requiredPositions;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableSchema Full Avro schema of the Hoodie table
+ * @param requiredSchema Projected schema required by the query
+ * @param rowType Full Flink {@link RowType} of the table
+ * @param requiredRowType Projected Flink {@link RowType} required by the query
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ HoodieSchema tableSchema,
+ HoodieSchema requiredSchema,
+ RowType rowType,
+ RowType requiredRowType,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes) {
+ this.conf = conf;
+ this.tableSchema = tableSchema;
+ this.requiredSchema = requiredSchema;
+ this.rowType = rowType;
+ this.requiredRowType = requiredRowType;
+ this.requiredPositions = computeRequiredPositions(rowType, requiredRowType);
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(rowType, wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
+ if (fallbackReaderFunction == null) {
+ fallbackReaderFunction = new HoodieSplitReaderFunction(
+ conf,
+ tableSchema,
+ requiredSchema,
+ internalSchemaManager,
+ conf.get(FlinkOptions.MERGE_TYPE),
+ Collections.emptyList(),
+ false);
+ }
+ return fallbackReaderFunction;
+ }
+
+ private ClosableIterator<RowData> createRecordIteratorSafe(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) {
+ try {
+ return createRecordIterator(tablePath, maxCompactionMemoryInBytes, fileSplit, mode, imageManager, client);
+ } catch (IOException e) {
+ throw new HoodieException("Failed to create CDC record iterator for split: " + fileSplit, e);
+ }
+ }
+
+ private ClosableIterator<RowData> createRecordIterator(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) throws IOException {
+ switch (fileSplit.getCdcInferCase()) {
+ case BASE_FILE_INSERT: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for BASE_FILE_INSERT");
+ String path = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ return new AddBaseFileIterator(getBaseFileIterator(path));
+ }
+ case BASE_FILE_DELETE: {
+ ValidationUtils.checkState(fileSplit.getBeforeFileSlice().isPresent(),
+ "Before file slice should exist for BASE_FILE_DELETE");
+ FileSlice fileSlice = fileSplit.getBeforeFileSlice().get();
+ MergeOnReadInputSplit inputSplit = CdcInputFormat.fileSlice2Split(tablePath, fileSlice, maxCompactionMemoryInBytes);
+ return new RemoveBaseFileIterator(requiredRowType, requiredPositions, getFileSliceIterator(inputSplit));
+ }
+ case AS_IS: {
+ HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(tableSchema);
+ HoodieSchema cdcSchema = HoodieCDCUtils.schemaBySupplementalLoggingMode(mode, dataSchema);
+ switch (mode) {
+ case DATA_BEFORE_AFTER:
+ return new BeforeAfterImageIterator(
+ getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType, cdcSchema, fileSplit);
+ case DATA_BEFORE:
+ return new BeforeImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ case OP_KEY_ONLY:
+ return new RecordKeyImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ default:
+ throw new AssertionError("Unexpected CDC supplemental logging mode: " + mode);
+ }
+ }
+ case LOG_FILE: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for LOG_FILE");
+ String logFilePath = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ MergeOnReadInputSplit split = CdcInputFormat.singleLogFile2Split(tablePath, logFilePath, maxCompactionMemoryInBytes);
+ ClosableIterator<HoodieRecord<RowData>> recordIterator = getFileSliceHoodieRecordIterator(split);
+ return new DataLogFileIterator(
+ maxCompactionMemoryInBytes, imageManager, fileSplit, tableSchema, requiredRowType, requiredPositions,
+ recordIterator, client, getWriteConfig());
+ }
+ case REPLACE_COMMIT: {
+ return new ReplaceCommitIterator(
+ conf, tablePath, requiredRowType, requiredPositions, maxCompactionMemoryInBytes,
+ fileSplit, this::getFileSliceIterator);
+ }
+ default:
+ throw new AssertionError("Unexpected CDC file split infer case: " + fileSplit.getCdcInferCase());
+ }
+ }
+
+ /** Reads the full-schema before/after image for a file slice (emitDelete=false). */
+ private ClosableIterator<RowData> getFileSliceIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, false,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create file slice iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a single log file and returns a typed {@link HoodieRecord} iterator (for LOG_FILE CDC inference). */
+ private ClosableIterator<HoodieRecord<RowData>> getFileSliceHoodieRecordIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, true,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableHoodieRecordIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create Hoodie record iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a parquet CDC base file returning required-schema records. */
+ private ClosableIterator<RowData> getBaseFileIterator(String path) throws IOException {
+ String[] fieldNames = rowType.getFieldNames().toArray(new String[0]);
+ DataType[] fieldTypesArray = fieldTypes.toArray(new DataType[0]);
+ return RecordIterators.getParquetRecordIterator(
+ internalSchemaManager,
+ conf.get(FlinkOptions.READ_UTC_TIMEZONE),
+ true,
+ HadoopConfigurations.getParquetConf(conf, getHadoopConf()),
+ fieldNames,
+ fieldTypesArray,
+ Collections.emptyMap(),
+ requiredPositions,
+ 2048,
+ new org.apache.flink.core.fs.Path(path),
+ 0,
+ Long.MAX_VALUE,
+ Collections.emptyList());
+ }
+
+ private static FileSlice buildFileSlice(MergeOnReadInputSplit split) {
+ return new FileSlice(
+ new HoodieFileGroupId("", split.getFileId()),
+ "",
+ split.getBasePath().map(HoodieBaseFile::new).orElse(null),
+ split.getLogPaths()
+ .map(lp -> lp.stream().map(HoodieLogFile::new).collect(Collectors.toList()))
+ .orElse(Collections.emptyList()));
+ }
+
+ private static int[] computeRequiredPositions(RowType rowType, RowType requiredRowType) {
+ List<String> allNames = rowType.getFieldNames();
+ return requiredRowType.getFieldNames().stream()
+ .map(allNames::indexOf)
+ .mapToInt(i -> i)
+ .toArray();
+ }
+
+ private HoodieTableMetaClient getMetaClient() {
+ if (metaClient == null) {
+ metaClient = StreamerUtil.metaClientForReader(conf, getHadoopConf());
+ }
+ return metaClient;
+ }
+
+ private HoodieWriteConfig getWriteConfig() {
+ if (writeConfig == null) {
+ writeConfig = FlinkWriteClients.getHoodieClientConfig(conf);
+ }
+ return writeConfig;
+ }
+
+ private org.apache.hadoop.conf.Configuration getHadoopConf() {
+ if (hadoopConf == null) {
+ hadoopConf = HadoopConfigurations.getHadoopConf(conf);
+ }
+ return hadoopConf;
+ }
+
+ // -------------------------------------------------------------------------
+ // Inner iterators (adapted from CdcInputFormat inner classes)
+ // -------------------------------------------------------------------------
+
+ /** Iterates over an ordered list of {@link HoodieCDCFileSplit}s, delegating record reading to a factory. */
+ private static class CdcFileSplitsIterator implements ClosableIterator<RowData> {
+ private ImageManager imageManager;
+ private final Iterator<HoodieCDCFileSplit> fileSplitIterator;
+ private final Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc;
+ private ClosableIterator<RowData> recordIterator;
+
+ CdcFileSplitsIterator(
+ HoodieCDCFileSplit[] changes,
+ ImageManager imageManager,
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc) {
+ this.fileSplitIterator = Arrays.asList(changes).iterator();
+ this.imageManager = imageManager;
+ this.recordIteratorFunc = recordIteratorFunc;
+ }
+
+ @Override
+ public boolean hasNext() {
+ if (recordIterator != null) {
+ if (recordIterator.hasNext()) {
+ return true;
+ } else {
+ recordIterator.close();
+ recordIterator = null;
+ }
+ }
+ if (fileSplitIterator.hasNext()) {
+ recordIterator = recordIteratorFunc.apply(fileSplitIterator.next());
+ return recordIterator.hasNext();
+ }
+ return false;
+ }
+
+ @Override
+ public RowData next() {
+ return recordIterator.next();
+ }
+
+ @Override
+ public void close() {
+ if (recordIterator != null) {
+ recordIterator.close();
+ }
+ if (imageManager != null) {
+ imageManager.close();
+ imageManager = null;
+ }
+ }
+ }
+
+ /** Wraps a base-file parquet iterator and marks every record as {@link RowKind#INSERT}. */
+ private static class AddBaseFileIterator implements ClosableIterator<RowData> {
+ private ClosableIterator<RowData> nested;
+ private RowData currentRecord;
+
+ AddBaseFileIterator(ClosableIterator<RowData> nested) {
+ this.nested = nested;
+ }
+
+ @Override
+ public boolean hasNext() {
+ if (nested.hasNext()) {
+ currentRecord = nested.next();
+ currentRecord.setRowKind(RowKind.INSERT);
+ return true;
+ }
+ return false;
+ }
+
+ @Override
+ public RowData next() {
+ return currentRecord;
+ }
+
+ @Override
+ public void close() {
+ if (nested != null) {
+ nested.close();
+ nested = null;
+ }
+ }
+ }
+
+ /** Wraps a file-slice iterator and marks every record as {@link RowKind#DELETE}, with projection. */
+ private static class RemoveBaseFileIterator implements ClosableIterator<RowData> {
+ private ClosableIterator<RowData> nested;
+ private final RowDataProjection projection;
+
+ RemoveBaseFileIterator(RowType requiredRowType, int[] requiredPositions, ClosableIterator<RowData> iterator) {
+ this.nested = iterator;
+ this.projection = RowDataProjection.instance(requiredRowType, requiredPositions);
+ }
+
+ @Override
+ public boolean hasNext() {
+ return nested.hasNext();
+ }
+
+ @Override
+ public RowData next() {
+ RowData row = nested.next();
+ row.setRowKind(RowKind.DELETE);
+ return projection.project(row);
+ }
+
+ @Override
+ public void close() {
+ if (nested != null) {
+ nested.close();
+ nested = null;
+ }
+ }
+ }
+
+ /**
+ * Handles the {@code LOG_FILE} CDC inference case: compares records from the log file
+ * against before-image snapshots to emit INSERT/UPDATE_BEFORE/UPDATE_AFTER/DELETE events.
+ */
+ private static class DataLogFileIterator implements ClosableIterator<RowData> {
+ private final HoodieSchema tableSchema;
+ private final long maxCompactionMemoryInBytes;
+ private final ImageManager imageManager;
+ private final RowDataProjection projection;
+ private final BufferedRecordMerger recordMerger;
+ private final ClosableIterator<HoodieRecord<RowData>> logRecordIterator;
+ private final DeleteContext deleteContext;
+ private final HoodieReaderContext<RowData> readerContext;
+ private final String[] orderingFields;
+ private final TypedProperties props;
+
+ private ExternalSpillableMap<String, byte[]> beforeImages;
+ private RowData currentImage;
+ private RowData sideImage;
+
+ DataLogFileIterator(
+ long maxCompactionMemoryInBytes,
+ ImageManager imageManager,
+ HoodieCDCFileSplit cdcFileSplit,
+ HoodieSchema tableSchema,
+ RowType requiredRowType,
+ int[] requiredPositions,
+ ClosableIterator<HoodieRecord<RowData>> logRecordIterator,
+ HoodieTableMetaClient metaClient,
+ HoodieWriteConfig writeConfig) throws IOException {
+ this.tableSchema = tableSchema;
+ this.maxCompactionMemoryInBytes = maxCompactionMemoryInBytes;
+ this.imageManager = imageManager;
+ this.projection = requiredRowType.equals(tableSchema.getAvroSchema().getFields().size() == requiredRowType.getFieldCount()
Review Comment:
It is a good catch. I can't follow the same pattern as table state is not easy to constructed. But definitely, the row type needs to be compared. Revised accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128908704
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824)
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131821986
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.21%
- Complexity 27573 27595 +22
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
+ Hits 91122 91176 +54
- Misses 35093 35501 +408
- Partials 7053 7066 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108405564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 315776c04ec79cbfb7fbbe012f574a2b72b722f6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108081548
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 315776c04ec79cbfb7fbbe012f574a2b72b722f6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108210765
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.29% -23.10%
+ Complexity 27505 15349 -12156
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 50034 -40866
- Misses 34966 55106 +20140
+ Partials 7060 5330 -1730
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1545 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108322631
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.17%
- Complexity 27505 27533 +28
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90985 +83
- Misses 34964 35333 +369
Partials 7060 7060
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101888267
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.19%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 59.19% -9.28%
+ Complexity 27472 23381 -4091
============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
============================================
- Hits 90820 77246 -13574
- Misses 34784 46890 +12106
+ Partials 7051 6363 -688
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.03% <ø> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "HuangZhenQiu (via GitHub)" <gi...@apache.org>.
HuangZhenQiu commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2985635323
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1053 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.HoodieSchemaConverter;
+import org.apache.hudi.util.StreamerUtil;
+import org.apache.hudi.util.RowDataProjection;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final HoodieSchema tableSchema;
+ private final HoodieSchema requiredSchema;
+ private final RowType rowType;
+ private final RowType requiredRowType;
+ private final int[] requiredPositions;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableSchema Full Avro schema of the Hoodie table
+ * @param requiredSchema Projected schema required by the query
+ * @param rowType Full Flink {@link RowType} of the table
+ * @param requiredRowType Projected Flink {@link RowType} required by the query
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ HoodieSchema tableSchema,
+ HoodieSchema requiredSchema,
+ RowType rowType,
+ RowType requiredRowType,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes) {
+ this.conf = conf;
+ this.tableSchema = tableSchema;
+ this.requiredSchema = requiredSchema;
+ this.rowType = rowType;
+ this.requiredRowType = requiredRowType;
+ this.requiredPositions = computeRequiredPositions(rowType, requiredRowType);
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(rowType, wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
+ if (fallbackReaderFunction == null) {
+ fallbackReaderFunction = new HoodieSplitReaderFunction(
+ conf,
+ tableSchema,
+ requiredSchema,
+ internalSchemaManager,
+ conf.get(FlinkOptions.MERGE_TYPE),
+ Collections.emptyList(),
+ false);
+ }
+ return fallbackReaderFunction;
+ }
+
+ private ClosableIterator<RowData> createRecordIteratorSafe(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) {
+ try {
+ return createRecordIterator(tablePath, maxCompactionMemoryInBytes, fileSplit, mode, imageManager, client);
+ } catch (IOException e) {
+ throw new HoodieException("Failed to create CDC record iterator for split: " + fileSplit, e);
+ }
+ }
+
+ private ClosableIterator<RowData> createRecordIterator(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) throws IOException {
+ switch (fileSplit.getCdcInferCase()) {
+ case BASE_FILE_INSERT: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for BASE_FILE_INSERT");
+ String path = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ return new AddBaseFileIterator(getBaseFileIterator(path));
+ }
+ case BASE_FILE_DELETE: {
+ ValidationUtils.checkState(fileSplit.getBeforeFileSlice().isPresent(),
+ "Before file slice should exist for BASE_FILE_DELETE");
+ FileSlice fileSlice = fileSplit.getBeforeFileSlice().get();
+ MergeOnReadInputSplit inputSplit = CdcInputFormat.fileSlice2Split(tablePath, fileSlice, maxCompactionMemoryInBytes);
+ return new RemoveBaseFileIterator(requiredRowType, requiredPositions, getFileSliceIterator(inputSplit));
+ }
+ case AS_IS: {
+ HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(tableSchema);
+ HoodieSchema cdcSchema = HoodieCDCUtils.schemaBySupplementalLoggingMode(mode, dataSchema);
+ switch (mode) {
+ case DATA_BEFORE_AFTER:
+ return new BeforeAfterImageIterator(
+ getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType, cdcSchema, fileSplit);
+ case DATA_BEFORE:
+ return new BeforeImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ case OP_KEY_ONLY:
+ return new RecordKeyImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ default:
+ throw new AssertionError("Unexpected CDC supplemental logging mode: " + mode);
+ }
+ }
+ case LOG_FILE: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for LOG_FILE");
+ String logFilePath = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ MergeOnReadInputSplit split = CdcInputFormat.singleLogFile2Split(tablePath, logFilePath, maxCompactionMemoryInBytes);
+ ClosableIterator<HoodieRecord<RowData>> recordIterator = getFileSliceHoodieRecordIterator(split);
+ return new DataLogFileIterator(
+ maxCompactionMemoryInBytes, imageManager, fileSplit, tableSchema, requiredRowType, requiredPositions,
+ recordIterator, client, getWriteConfig());
+ }
+ case REPLACE_COMMIT: {
+ return new ReplaceCommitIterator(
+ conf, tablePath, requiredRowType, requiredPositions, maxCompactionMemoryInBytes,
+ fileSplit, this::getFileSliceIterator);
+ }
+ default:
+ throw new AssertionError("Unexpected CDC file split infer case: " + fileSplit.getCdcInferCase());
+ }
+ }
+
+ /** Reads the full-schema before/after image for a file slice (emitDelete=false). */
+ private ClosableIterator<RowData> getFileSliceIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, false,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create file slice iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a single log file and returns a typed {@link HoodieRecord} iterator (for LOG_FILE CDC inference). */
+ private ClosableIterator<HoodieRecord<RowData>> getFileSliceHoodieRecordIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, true,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableHoodieRecordIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create Hoodie record iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a parquet CDC base file returning required-schema records. */
+ private ClosableIterator<RowData> getBaseFileIterator(String path) throws IOException {
+ String[] fieldNames = rowType.getFieldNames().toArray(new String[0]);
+ DataType[] fieldTypesArray = fieldTypes.toArray(new DataType[0]);
+ return RecordIterators.getParquetRecordIterator(
+ internalSchemaManager,
+ conf.get(FlinkOptions.READ_UTC_TIMEZONE),
+ true,
+ HadoopConfigurations.getParquetConf(conf, getHadoopConf()),
+ fieldNames,
+ fieldTypesArray,
+ Collections.emptyMap(),
Review Comment:
Good catch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123180037
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* d481a60fde89534f6ca64b07a66d57bb45f8b09e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804)
* 18d4c27fe8487962d47633cc38c0765c04b96c63 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123320585
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.23%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.23% -20.15%
+ Complexity 27505 16312 -11193
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53331 -37571
- Misses 34964 51697 +16733
+ Partials 7060 5532 -1528
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.50% <ø> (-15.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128796150
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27595 +90
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16071 +71
============================================
+ Hits 90902 91161 +259
- Misses 34964 35505 +541
- Partials 7060 7061 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [44 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101664863
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4107969072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108207371
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|12|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.29% -23.10%
+ Complexity 27505 15349 -12156
=============================================
Files 2428 1993 -435
Lines 132926 110465 -22461
Branches 16000 13888 -2112
=============================================
- Hits 90900 50030 -40870
- Misses 34966 55104 +20138
+ Partials 7060 5331 -1729
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1547 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108338786
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.17%
- Complexity 27505 27533 +28
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90987 +85
- Misses 34964 35331 +367
Partials 7060 7060
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108349200
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.17%
- Complexity 27505 27533 +28
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90989 +87
- Misses 34964 35329 +365
Partials 7060 7060
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108277604
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.31%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.31% -1.08%
+ Complexity 27505 27176 -329
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89782 -1120
- Misses 34964 36475 +1511
- Partials 7060 7121 +61
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-3.81%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [159 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108283900
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.33%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.33% -1.05%
+ Complexity 27505 27183 -322
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89811 -1091
- Misses 34964 36449 +1485
- Partials 7060 7118 +58
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-3.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108297822
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.18%
- Complexity 27505 27532 +27
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90983 +81
- Misses 34964 35334 +370
- Partials 7060 7061 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <ø> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129153236
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.44%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.44% -21.95%
+ Complexity 27505 15042 -12463
=============================================
Files 2428 1948 -480
Lines 132926 105708 -27218
Branches 16000 12871 -3129
=============================================
- Hits 90902 49093 -41809
- Misses 34964 51571 +16607
+ Partials 7060 5044 -2016
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <ø> (-12.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1574 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129195093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.70%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 58.70% -9.69%
+ Complexity 27505 23791 -3714
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 78491 -12411
- Misses 34964 48513 +13549
+ Partials 7060 6709 -351
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [675 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129731645
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839)
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129783187
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.31%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|2|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 59.31% -9.07%
+ Complexity 27573 23578 -3995
============================================
Files 2433 2406 -27
Lines 133268 131175 -2093
Branches 16034 15528 -506
============================================
- Hits 91122 77805 -13317
- Misses 35093 46806 +11713
+ Partials 7053 6564 -489
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.41% <ø> (-15.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [671 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129815658
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 61.21% -7.16%
+ Complexity 27573 24752 -2821
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 81863 -9259
- Misses 35093 45002 +9909
+ Partials 7053 6864 -189
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129860738
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.32%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.32% -1.05%
+ Complexity 27573 27258 -315
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 90034 -1088
- Misses 35093 36572 +1479
- Partials 7053 7123 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <ø> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129878544
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.20%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
+ Hits 91122 91172 +50
- Misses 35093 35491 +398
- Partials 7053 7066 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <ø> (-0.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129861508
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.32%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.32% -1.05%
+ Complexity 27573 27258 -315
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 90034 -1088
- Misses 35093 36572 +1479
- Partials 7053 7123 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <ø> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124219570
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.21%
- Complexity 27505 27589 +84
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
+ Hits 90902 91112 +210
- Misses 34964 35468 +504
+ Partials 7060 7056 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [40 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120179967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 315776c04ec79cbfb7fbbe012f574a2b72b722f6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779)
* d481a60fde89534f6ca64b07a66d57bb45f8b09e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120576561
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.29% -1.10%
+ Complexity 27505 27220 -285
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 89887 -1015
- Misses 34964 36546 +1582
- Partials 7060 7138 +78
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <ø> (-3.65%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [183 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4122954850
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* d481a60fde89534f6ca64b07a66d57bb45f8b09e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804)
* 18d4c27fe8487962d47633cc38c0765c04b96c63 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123908806
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 18d4c27fe8487962d47633cc38c0765c04b96c63 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817)
* 09af38b4d894ca0f90833697a71e64bf50453e03 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820)
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123990050
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.15% -23.24%
+ Complexity 27505 8452 -19053
=============================================
Files 2428 1193 -1235
Lines 132926 61326 -71600
Branches 16000 6550 -9450
=============================================
- Hits 90902 27690 -63212
+ Misses 34964 30625 -4339
+ Partials 7060 3011 -4049
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124141950
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.18% -1.20%
+ Complexity 27505 27201 -304
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 89789 -1113
- Misses 34964 36710 +1746
- Partials 7060 7137 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [208 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120415566
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.10%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.10% -14.28%
+ Complexity 27505 12155 -15350
=============================================
Files 2428 1422 -1006
Lines 132926 69959 -62967
Branches 16000 7794 -8206
=============================================
- Hits 90902 37854 -53048
+ Misses 34964 28742 -6222
+ Partials 7060 3363 -3697
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1779 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131676177
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.42%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 46.42% -21.96%
+ Complexity 27573 15045 -12528
=============================================
Files 2433 1948 -485
Lines 133268 105689 -27579
Branches 16034 12856 -3178
=============================================
- Hits 91122 49066 -42056
- Misses 35093 51582 +16489
+ Partials 7053 5041 -2012
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <ø> (-12.23%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1580 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120687544
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.18% -0.21%
- Complexity 27505 27565 +60
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
+ Hits 90902 91073 +171
- Misses 34964 35432 +468
- Partials 7060 7066 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108199058
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.34%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|12|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.34% -22.04%
+ Complexity 27505 14996 -12509
=============================================
Files 2428 1947 -481
Lines 132926 105577 -27349
Branches 16000 12846 -3154
=============================================
- Hits 90900 48932 -41968
- Misses 34966 51611 +16645
+ Partials 7060 5034 -2026
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <ø> (-12.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108226802
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.66%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.66% -13.72%
+ Complexity 27505 18261 -9244
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 60391 -30509
- Misses 34966 43944 +8978
+ Partials 7060 6135 -925
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1359 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2973323103
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1054 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.RowDataProjection;
+import org.apache.hudi.util.StreamerUtil;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final HoodieSchema tableSchema;
+ private final HoodieSchema requiredSchema;
+ private final RowType rowType;
+ private final RowType requiredRowType;
+ private final int[] requiredPositions;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableSchema Full Avro schema of the Hoodie table
+ * @param requiredSchema Projected schema required by the query
+ * @param rowType Full Flink {@link RowType} of the table
+ * @param requiredRowType Projected Flink {@link RowType} required by the query
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ HoodieSchema tableSchema,
+ HoodieSchema requiredSchema,
+ RowType rowType,
+ RowType requiredRowType,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes) {
+ this.conf = conf;
+ this.tableSchema = tableSchema;
+ this.requiredSchema = requiredSchema;
+ this.rowType = rowType;
+ this.requiredRowType = requiredRowType;
+ this.requiredPositions = computeRequiredPositions(rowType, requiredRowType);
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(rowType, wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
+ if (fallbackReaderFunction == null) {
+ fallbackReaderFunction = new HoodieSplitReaderFunction(
+ conf,
+ tableSchema,
+ requiredSchema,
+ internalSchemaManager,
+ conf.get(FlinkOptions.MERGE_TYPE),
+ Collections.emptyList(),
+ false);
+ }
+ return fallbackReaderFunction;
+ }
+
+ private ClosableIterator<RowData> createRecordIteratorSafe(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) {
+ try {
+ return createRecordIterator(tablePath, maxCompactionMemoryInBytes, fileSplit, mode, imageManager, client);
+ } catch (IOException e) {
+ throw new HoodieException("Failed to create CDC record iterator for split: " + fileSplit, e);
+ }
+ }
+
+ private ClosableIterator<RowData> createRecordIterator(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) throws IOException {
+ switch (fileSplit.getCdcInferCase()) {
+ case BASE_FILE_INSERT: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for BASE_FILE_INSERT");
+ String path = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ return new AddBaseFileIterator(getBaseFileIterator(path));
+ }
+ case BASE_FILE_DELETE: {
+ ValidationUtils.checkState(fileSplit.getBeforeFileSlice().isPresent(),
+ "Before file slice should exist for BASE_FILE_DELETE");
+ FileSlice fileSlice = fileSplit.getBeforeFileSlice().get();
+ MergeOnReadInputSplit inputSplit = CdcInputFormat.fileSlice2Split(tablePath, fileSlice, maxCompactionMemoryInBytes);
+ return new RemoveBaseFileIterator(requiredRowType, requiredPositions, getFileSliceIterator(inputSplit));
+ }
+ case AS_IS: {
+ HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(tableSchema);
+ HoodieSchema cdcSchema = HoodieCDCUtils.schemaBySupplementalLoggingMode(mode, dataSchema);
+ switch (mode) {
+ case DATA_BEFORE_AFTER:
+ return new BeforeAfterImageIterator(
+ getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType, cdcSchema, fileSplit);
+ case DATA_BEFORE:
+ return new BeforeImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ case OP_KEY_ONLY:
+ return new RecordKeyImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, requiredRowType,
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ default:
+ throw new AssertionError("Unexpected CDC supplemental logging mode: " + mode);
+ }
+ }
+ case LOG_FILE: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for LOG_FILE");
+ String logFilePath = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ MergeOnReadInputSplit split = CdcInputFormat.singleLogFile2Split(tablePath, logFilePath, maxCompactionMemoryInBytes);
+ ClosableIterator<HoodieRecord<RowData>> recordIterator = getFileSliceHoodieRecordIterator(split);
+ return new DataLogFileIterator(
+ maxCompactionMemoryInBytes, imageManager, fileSplit, tableSchema, requiredRowType, requiredPositions,
+ recordIterator, client, getWriteConfig());
+ }
+ case REPLACE_COMMIT: {
+ return new ReplaceCommitIterator(
+ conf, tablePath, requiredRowType, requiredPositions, maxCompactionMemoryInBytes,
+ fileSplit, this::getFileSliceIterator);
+ }
+ default:
+ throw new AssertionError("Unexpected CDC file split infer case: " + fileSplit.getCdcInferCase());
+ }
+ }
+
+ /** Reads the full-schema before/after image for a file slice (emitDelete=false). */
+ private ClosableIterator<RowData> getFileSliceIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, false,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create file slice iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a single log file and returns a typed {@link HoodieRecord} iterator (for LOG_FILE CDC inference). */
+ private ClosableIterator<HoodieRecord<RowData>> getFileSliceHoodieRecordIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, true,
+ Collections.emptyList(), split.getInstantRange());
+ return reader.getClosableHoodieRecordIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create Hoodie record iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a parquet CDC base file returning required-schema records. */
+ private ClosableIterator<RowData> getBaseFileIterator(String path) throws IOException {
+ String[] fieldNames = rowType.getFieldNames().toArray(new String[0]);
+ DataType[] fieldTypesArray = fieldTypes.toArray(new DataType[0]);
+ return RecordIterators.getParquetRecordIterator(
+ internalSchemaManager,
+ conf.get(FlinkOptions.READ_UTC_TIMEZONE),
+ true,
+ HadoopConfigurations.getParquetConf(conf, getHadoopConf()),
+ fieldNames,
+ fieldTypesArray,
+ Collections.emptyMap(),
+ requiredPositions,
+ 2048,
+ new org.apache.flink.core.fs.Path(path),
+ 0,
+ Long.MAX_VALUE,
+ Collections.emptyList());
+ }
+
+ private static FileSlice buildFileSlice(MergeOnReadInputSplit split) {
+ return new FileSlice(
+ new HoodieFileGroupId("", split.getFileId()),
+ "",
+ split.getBasePath().map(HoodieBaseFile::new).orElse(null),
+ split.getLogPaths()
+ .map(lp -> lp.stream().map(HoodieLogFile::new).collect(Collectors.toList()))
+ .orElse(Collections.emptyList()));
+ }
+
+ private static int[] computeRequiredPositions(RowType rowType, RowType requiredRowType) {
+ List<String> allNames = rowType.getFieldNames();
+ return requiredRowType.getFieldNames().stream()
+ .map(allNames::indexOf)
+ .mapToInt(i -> i)
+ .toArray();
+ }
+
+ private HoodieTableMetaClient getMetaClient() {
+ if (metaClient == null) {
+ metaClient = StreamerUtil.metaClientForReader(conf, getHadoopConf());
+ }
+ return metaClient;
+ }
+
+ private HoodieWriteConfig getWriteConfig() {
+ if (writeConfig == null) {
+ writeConfig = FlinkWriteClients.getHoodieClientConfig(conf);
+ }
+ return writeConfig;
+ }
+
+ private org.apache.hadoop.conf.Configuration getHadoopConf() {
+ if (hadoopConf == null) {
+ hadoopConf = HadoopConfigurations.getHadoopConf(conf);
+ }
+ return hadoopConf;
+ }
+
+ // -------------------------------------------------------------------------
+ // Inner iterators (adapted from CdcInputFormat inner classes)
+ // -------------------------------------------------------------------------
+
+ /** Iterates over an ordered list of {@link HoodieCDCFileSplit}s, delegating record reading to a factory. */
+ private static class CdcFileSplitsIterator implements ClosableIterator<RowData> {
+ private ImageManager imageManager;
+ private final Iterator<HoodieCDCFileSplit> fileSplitIterator;
+ private final Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc;
+ private ClosableIterator<RowData> recordIterator;
+
+ CdcFileSplitsIterator(
+ HoodieCDCFileSplit[] changes,
+ ImageManager imageManager,
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc) {
+ this.fileSplitIterator = Arrays.asList(changes).iterator();
+ this.imageManager = imageManager;
+ this.recordIteratorFunc = recordIteratorFunc;
+ }
+
+ @Override
+ public boolean hasNext() {
+ if (recordIterator != null) {
+ if (recordIterator.hasNext()) {
+ return true;
+ } else {
+ recordIterator.close();
+ recordIterator = null;
+ }
+ }
+ if (fileSplitIterator.hasNext()) {
+ recordIterator = recordIteratorFunc.apply(fileSplitIterator.next());
+ return recordIterator.hasNext();
+ }
+ return false;
+ }
+
+ @Override
+ public RowData next() {
+ return recordIterator.next();
+ }
+
+ @Override
+ public void close() {
+ if (recordIterator != null) {
+ recordIterator.close();
+ }
+ if (imageManager != null) {
+ imageManager.close();
+ imageManager = null;
+ }
+ }
+ }
+
+ /** Wraps a base-file parquet iterator and marks every record as {@link RowKind#INSERT}. */
+ private static class AddBaseFileIterator implements ClosableIterator<RowData> {
+ private ClosableIterator<RowData> nested;
+ private RowData currentRecord;
+
+ AddBaseFileIterator(ClosableIterator<RowData> nested) {
+ this.nested = nested;
+ }
+
+ @Override
+ public boolean hasNext() {
+ if (nested.hasNext()) {
+ currentRecord = nested.next();
+ currentRecord.setRowKind(RowKind.INSERT);
+ return true;
+ }
+ return false;
+ }
+
+ @Override
+ public RowData next() {
+ return currentRecord;
+ }
+
+ @Override
+ public void close() {
+ if (nested != null) {
+ nested.close();
+ nested = null;
+ }
+ }
+ }
+
+ /** Wraps a file-slice iterator and marks every record as {@link RowKind#DELETE}, with projection. */
+ private static class RemoveBaseFileIterator implements ClosableIterator<RowData> {
+ private ClosableIterator<RowData> nested;
+ private final RowDataProjection projection;
+
+ RemoveBaseFileIterator(RowType requiredRowType, int[] requiredPositions, ClosableIterator<RowData> iterator) {
+ this.nested = iterator;
+ this.projection = RowDataProjection.instance(requiredRowType, requiredPositions);
+ }
+
+ @Override
+ public boolean hasNext() {
+ return nested.hasNext();
+ }
+
+ @Override
+ public RowData next() {
+ RowData row = nested.next();
+ row.setRowKind(RowKind.DELETE);
+ return projection.project(row);
+ }
+
+ @Override
+ public void close() {
+ if (nested != null) {
+ nested.close();
+ nested = null;
+ }
+ }
+ }
+
+ /**
+ * Handles the {@code LOG_FILE} CDC inference case: compares records from the log file
+ * against before-image snapshots to emit INSERT/UPDATE_BEFORE/UPDATE_AFTER/DELETE events.
+ */
+ private static class DataLogFileIterator implements ClosableIterator<RowData> {
+ private final HoodieSchema tableSchema;
+ private final long maxCompactionMemoryInBytes;
+ private final ImageManager imageManager;
+ private final RowDataProjection projection;
+ private final BufferedRecordMerger recordMerger;
+ private final ClosableIterator<HoodieRecord<RowData>> logRecordIterator;
+ private final DeleteContext deleteContext;
+ private final HoodieReaderContext<RowData> readerContext;
+ private final String[] orderingFields;
+ private final TypedProperties props;
+
+ private ExternalSpillableMap<String, byte[]> beforeImages;
+ private RowData currentImage;
+ private RowData sideImage;
+
+ DataLogFileIterator(
+ long maxCompactionMemoryInBytes,
+ ImageManager imageManager,
+ HoodieCDCFileSplit cdcFileSplit,
+ HoodieSchema tableSchema,
+ RowType requiredRowType,
+ int[] requiredPositions,
+ ClosableIterator<HoodieRecord<RowData>> logRecordIterator,
+ HoodieTableMetaClient metaClient,
+ HoodieWriteConfig writeConfig) throws IOException {
+ this.tableSchema = tableSchema;
+ this.maxCompactionMemoryInBytes = maxCompactionMemoryInBytes;
+ this.imageManager = imageManager;
+ this.projection = requiredRowType.equals(tableSchema.getAvroSchema().getFields().size() == requiredRowType.getFieldCount()
Review Comment:
Projection is skipped based on equal field count, not schema equality. If required and full row types differ but have same arity, emitted rows may not match the required schema. Can we follow the behavior as in legacy `CdcInputFormat`?
https://github.com/apache/hudi/blob/817b3ad7de92602ae301c0b1d1931e016f1261a3/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcInputFormat.java#L369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124144181
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.18% -1.20%
+ Complexity 27505 27201 -304
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 89789 -1113
- Misses 34964 36710 +1746
- Partials 7060 7137 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [208 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131953968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
}, {
"hash" : "05b0641891737e38a469b3c23688ea6dd249346e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12852",
"triggerID" : "05b0641891737e38a469b3c23688ea6dd249346e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 05b0641891737e38a469b3c23688ea6dd249346e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123748370
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.26%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.26% -20.12%
+ Complexity 27505 16322 -11183
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53366 -37536
- Misses 34964 51665 +16701
+ Partials 7060 5529 -1531
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <ø> (-15.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129772679
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.85% -22.52%
+ Complexity 27573 15204 -12369
=============================================
Files 2433 1965 -468
Lines 133268 108037 -25231
Branches 16034 13357 -2677
=============================================
- Hits 91122 49542 -41580
- Misses 35093 53314 +18221
+ Partials 7053 5181 -1872
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "HuangZhenQiu (via GitHub)" <gi...@apache.org>.
HuangZhenQiu commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2985445921
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -530,10 +531,8 @@ private static class DataLogFileIterator implements ClosableIterator<RowData> {
this.tableSchema = tableSchema;
this.maxCompactionMemoryInBytes = maxCompactionMemoryInBytes;
this.imageManager = imageManager;
- this.projection = requiredRowType.equals(tableSchema.getAvroSchema().getFields().size() == requiredRowType.getFieldCount()
- ? requiredRowType : null)
- ? null
- : RowDataProjection.instance(requiredRowType, requiredPositions);
+ this.projection = HoodieSchemaConverter.convertToRowType(tableSchema).equals(requiredRowType)
Review Comment:
Make sense. I will make MergeOnReadTableState generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123840440
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.13859%` with `398 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.81%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.98% | [381 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.81% -2.58%
+ Complexity 27505 26578 -927
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 87949 -2953
- Misses 34964 38410 +3446
- Partials 7060 7273 +213
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <15.13%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.58% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.98% <3.98%> (ø)` | |
... and [371 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123815098
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.13859%` with `398 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.76%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.98% | [381 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.76% -2.63%
+ Complexity 27505 26559 -946
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 87882 -3020
- Misses 34964 38482 +3518
- Partials 7060 7268 +208
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <15.13%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <ø> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.58% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.98% <3.98%> (ø)` | |
... and [382 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124127959
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.74%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.74% -2.65%
+ Complexity 27505 26557 -948
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 87859 -3043
- Misses 34964 38513 +3549
- Partials 7060 7264 +204
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <ø> (-16.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [382 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124109992
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.65%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.65% -13.73%
+ Complexity 27505 18279 -9226
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13901 -2099
=============================================
- Hits 90902 60432 -30470
- Misses 34964 43990 +9026
+ Partials 7060 6138 -922
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <ø> (-16.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1364 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120574720
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.26%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.26% -1.12%
+ Complexity 27505 27206 -299
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 89850 -1052
- Misses 34964 36583 +1619
- Partials 7060 7138 +78
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (-3.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [190 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120589692
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.21%
- Complexity 27505 27562 +57
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
+ Hits 90902 91067 +165
- Misses 34964 35436 +472
- Partials 7060 7068 +8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.58% <ø> (-0.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [38 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131595171
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.15% -23.23%
+ Complexity 27573 8455 -19118
=============================================
Files 2433 1193 -1240
Lines 133268 61348 -71920
Branches 16034 6553 -9481
=============================================
- Hits 91122 27700 -63422
+ Misses 35093 30635 -4458
+ Partials 7053 3013 -4040
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2034 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131689904
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.25%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 48.25% -20.13%
+ Complexity 27573 16327 -11246
=============================================
Files 2433 1994 -439
Lines 133268 110610 -22658
Branches 16034 13908 -2126
=============================================
- Hits 91122 53374 -37748
- Misses 35093 51703 +16610
+ Partials 7053 5533 -1520
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <ø> (-15.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123336286
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `14.68085%` with `401 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.70%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.48% | [383 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 58.70% -9.69%
+ Complexity 27505 23783 -3722
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 78442 -12460
- Misses 34964 48483 +13519
+ Partials 7060 6707 -353
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <14.68%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <ø> (-16.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.48% <3.48%> (ø)` | |
... and [670 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123266995
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.43%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.43% -21.95%
+ Complexity 27505 15042 -12463
=============================================
Files 2428 1948 -480
Lines 132926 105697 -27229
Branches 16000 12864 -3136
=============================================
- Hits 90902 49085 -41817
- Misses 34964 51569 +16605
+ Partials 7060 5043 -2017
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <ø> (-12.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123861008
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.13859%` with `398 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.98% | [381 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.19% -1.19%
+ Complexity 27505 27182 -323
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 89797 -1105
- Misses 34964 36690 +1726
- Partials 7060 7145 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <15.13%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.48% <ø> (-6.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.58% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.98% <3.98%> (ø)` | |
... and [213 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129851007
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.80%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 65.80% -2.58%
+ Complexity 27573 26586 -987
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 87999 -3123
- Misses 35093 38453 +3360
- Partials 7053 7277 +224
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [355 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129859093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.29%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.29% -1.08%
+ Complexity 27573 27243 -330
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 89993 -1129
- Misses 35093 36616 +1523
- Partials 7053 7120 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <ø> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [159 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131556205
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
}, {
"hash" : "05b0641891737e38a469b3c23688ea6dd249346e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05b0641891737e38a469b3c23688ea6dd249346e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841)
* 05b0641891737e38a469b3c23688ea6dd249346e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131735785
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.80%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 65.80% -2.58%
+ Complexity 27573 26586 -987
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 87997 -3125
- Misses 35093 38453 +3360
- Partials 7053 7279 +226
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [356 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131747991
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.31%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.31% -1.06%
+ Complexity 27573 27258 -315
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
- Hits 91122 90031 -1091
- Misses 35093 36586 +1493
- Partials 7053 7126 +73
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108306391
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.18%
- Complexity 27505 27533 +28
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90984 +82
- Misses 34964 35334 +370
Partials 7060 7060
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108289890
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.39%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.39% -1.00%
+ Complexity 27505 27206 -299
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89884 -1018
- Misses 34964 36376 +1412
- Partials 7060 7118 +58
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (-3.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101668468
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108337669
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.21% -0.17%
- Complexity 27505 27533 +28
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
+ Hits 90902 90987 +85
- Misses 34964 35331 +367
Partials 7060 7060
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <ø> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108122372
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.06%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 45.78% 45.06% -0.73%
+ Complexity 15154 8428 -6726
============================================
Files 1964 1192 -772
Lines 107916 61236 -46680
Branches 13351 6541 -6810
============================================
- Hits 49410 27596 -21814
+ Misses 53331 30634 -22697
+ Partials 5175 3006 -2169
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1313 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108224584
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.24% -20.14%
+ Complexity 27505 16297 -11208
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 53298 -37602
- Misses 34966 51650 +16684
+ Partials 7060 5522 -1538
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108197316
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.84%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|11|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.84% -21.54%
+ Complexity 27504 14835 -12669
=============================================
Files 2428 1930 -498
Lines 132926 103132 -29794
Branches 16000 12302 -3698
=============================================
- Hits 90899 48316 -42583
- Misses 34967 49892 +14925
+ Partials 7060 4924 -2136
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.34% <ø> (-12.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1601 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123704617
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.92%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.92% -21.46%
+ Complexity 27505 14878 -12627
=============================================
Files 2428 1931 -497
Lines 132926 103222 -29704
Branches 16000 12311 -3689
=============================================
- Hits 90902 48440 -42462
- Misses 34964 49852 +14888
+ Partials 7060 4930 -2130
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.32% <ø> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1606 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124172916
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.14% -0.24%
- Complexity 27505 27574 +69
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
+ Hits 90902 91070 +168
- Misses 34964 35508 +544
+ Partials 7060 7058 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <ø> (-0.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [52 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124155717
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.33%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.33% -1.05%
+ Complexity 27505 27255 -250
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 89989 -913
- Misses 34964 36532 +1568
- Partials 7060 7115 +55
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <ø> (-3.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [165 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120370891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 315776c04ec79cbfb7fbbe012f574a2b72b722f6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779)
* d481a60fde89534f6ca64b07a66d57bb45f8b09e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120517531
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.18%
+ Complexity 27505 24726 -2779
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 81765 -9137
- Misses 34964 44939 +9975
+ Partials 7060 6867 -193
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [552 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2985488503
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1053 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.HoodieSchemaConverter;
+import org.apache.hudi.util.StreamerUtil;
+import org.apache.hudi.util.RowDataProjection;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final HoodieSchema tableSchema;
+ private final HoodieSchema requiredSchema;
+ private final RowType rowType;
+ private final RowType requiredRowType;
+ private final int[] requiredPositions;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableSchema Full Avro schema of the Hoodie table
+ * @param requiredSchema Projected schema required by the query
+ * @param rowType Full Flink {@link RowType} of the table
+ * @param requiredRowType Projected Flink {@link RowType} required by the query
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ HoodieSchema tableSchema,
+ HoodieSchema requiredSchema,
+ RowType rowType,
+ RowType requiredRowType,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes) {
+ this.conf = conf;
+ this.tableSchema = tableSchema;
+ this.requiredSchema = requiredSchema;
+ this.rowType = rowType;
+ this.requiredRowType = requiredRowType;
+ this.requiredPositions = computeRequiredPositions(rowType, requiredRowType);
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(rowType, wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
Review Comment:
The non-CDC fallback constructs `HoodieSplitReaderFunction` with an empty predicate list. `CdcInputFormat`'s non-CDC path preserves configured predicates, so this fallback is not on par.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123257514
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.92%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.92% -21.46%
+ Complexity 27505 14880 -12625
=============================================
Files 2428 1931 -497
Lines 132926 103222 -29704
Branches 16000 12311 -3689
=============================================
- Hits 90902 48440 -42462
- Misses 34964 49855 +14891
+ Partials 7060 4927 -2133
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.32% <ø> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1605 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123275778
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.86%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.86% -22.52%
+ Complexity 27505 15202 -12303
=============================================
Files 2428 1965 -463
Lines 132926 108006 -24920
Branches 16000 13360 -2640
=============================================
- Hits 90902 49538 -41364
- Misses 34964 53292 +18328
+ Partials 7060 5176 -1884
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1565 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124106840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 18d4c27fe8487962d47633cc38c0765c04b96c63 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817)
* 09af38b4d894ca0f90833697a71e64bf50453e03 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820)
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128673045
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.32%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.32% -1.07%
+ Complexity 27505 27259 -246
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 90021 -881
- Misses 34964 36568 +1604
- Partials 7060 7124 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <ø> (-3.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [174 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129790403
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.34%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|3|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 59.34% -9.04%
+ Complexity 27573 23588 -3985
============================================
Files 2433 2406 -27
Lines 133268 131175 -2093
Branches 16034 15528 -506
============================================
- Hits 91122 77841 -13281
- Misses 35093 46774 +11681
+ Partials 7053 6560 -493
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <ø> (-15.77%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [671 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129779267
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.74%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 48.74% -19.63%
+ Complexity 27573 16109 -11464
=============================================
Files 2433 1965 -468
Lines 133268 108037 -25231
Branches 16034 13357 -2677
=============================================
- Hits 91122 52666 -38456
- Misses 35093 49979 +14886
+ Partials 7053 5392 -1661
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.83% <ø> (-14.91%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131686080
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 48.18% -20.20%
+ Complexity 27573 16304 -11269
=============================================
Files 2433 1994 -439
Lines 133268 110596 -22672
Branches 16034 13906 -2128
=============================================
- Hits 91122 53288 -37834
- Misses 35093 51762 +16669
+ Partials 7053 5546 -1507
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.83% <ø> (-14.92%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131741662
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.19% -1.18%
+ Complexity 27573 27212 -361
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 89863 -1259
- Misses 35093 36720 +1627
- Partials 7053 7146 +93
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-3.86%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [192 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128741282
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27594 +89
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16071 +71
============================================
+ Hits 90902 91156 +254
- Misses 34964 35508 +544
- Partials 7060 7063 +3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [47 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129128960
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.92%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.92% -21.46%
+ Complexity 27505 14880 -12625
=============================================
Files 2428 1931 -497
Lines 132926 103228 -29698
Branches 16000 12312 -3688
=============================================
- Hits 90902 48444 -42458
- Misses 34964 49855 +14891
+ Partials 7060 4929 -2131
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.32% <ø> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1605 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131809949
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.21%
- Complexity 27573 27594 +21
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
+ Hits 91122 91174 +52
- Misses 35093 35503 +410
- Partials 7053 7066 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <ø> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101833444
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.54%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.46% 56.54% -11.92%
+ Complexity 27472 22373 -5099
=============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
=============================================
- Hits 90820 73794 -17026
- Misses 34784 50464 +15680
+ Partials 7051 6241 -810
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.42% <ø> (-15.41%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [747 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4102803908
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.27%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 68.27% -0.19%
- Complexity 27472 27492 +20
============================================
Files 2427 2429 +2
Lines 132655 133067 +412
Branches 15994 16024 +30
============================================
+ Hits 90820 90857 +37
- Misses 34784 35157 +373
- Partials 7051 7053 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <ø> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.64% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101914419
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.31%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 61.31% -7.15%
+ Complexity 27472 24224 -3248
============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
============================================
- Hits 90820 80021 -10799
- Misses 34784 43878 +9094
+ Partials 7051 6600 -451
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.03% <ø> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <ø> (-12.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [557 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123341382
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `14.68085%` with `401 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.48% | [383 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.17%
+ Complexity 27505 24742 -2763
============================================
Files 2428 2434 +6
Lines 132926 133632 +706
Branches 16000 16064 +64
============================================
- Hits 90902 81808 -9094
- Misses 34964 44962 +9998
+ Partials 7060 6862 -198
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.21% <14.68%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <ø> (-16.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.54% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.48% <3.48%> (ø)` | |
... and [550 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123326063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.27%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.27% -20.12%
+ Complexity 27505 16325 -11180
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53368 -37534
- Misses 34964 51665 +16701
+ Partials 7060 5527 -1533
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <ø> (-15.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123745634
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.23%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.23% -20.16%
+ Complexity 27505 16308 -11197
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53329 -37573
- Misses 34964 51697 +16733
+ Partials 7060 5534 -1526
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.44% <ø> (-15.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1502 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124061865
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.17% -14.22%
+ Complexity 27505 12182 -15323
=============================================
Files 2428 1422 -1006
Lines 132926 70013 -62913
Branches 16000 7801 -8199
=============================================
- Hits 90902 37927 -52975
+ Misses 34964 28721 -6243
+ Partials 7060 3365 -3695
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1780 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124102581
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.24% -20.15%
+ Complexity 27505 16319 -11186
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13901 -2099
=============================================
- Hits 90902 53336 -37566
- Misses 34964 51694 +16730
+ Partials 7060 5530 -1530
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <ø> (-15.69%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1499 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124090649
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.82%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.82% -22.57%
+ Complexity 27505 15200 -12305
=============================================
Files 2428 1965 -463
Lines 132926 107992 -24934
Branches 16000 13276 -2724
=============================================
- Hits 90902 49484 -41418
- Misses 34964 53289 +18325
+ Partials 7060 5219 -1841
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <ø> (-12.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1574 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124151707
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.28%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.28% -1.11%
+ Complexity 27505 27232 -273
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 89916 -986
- Misses 34964 36605 +1641
- Partials 7060 7115 +55
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <ø> (-3.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124435742
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120579623
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.31%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.31% -1.07%
+ Complexity 27505 27220 -285
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 89919 -983
- Misses 34964 36535 +1571
- Partials 7060 7117 +57
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <ø> (-3.65%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <ø> (-0.17%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [166 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101782469
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 52.90%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.46% 52.90% -15.57%
+ Complexity 27472 20656 -6816
=============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
=============================================
- Hits 90820 69037 -21783
- Misses 34784 55232 +20448
+ Partials 7051 6230 -821
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.42% <ø> (-15.41%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [946 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120468192
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 47.94%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 47.94% -20.44%
+ Complexity 27505 16165 -11340
=============================================
Files 2428 1994 -434
Lines 132926 110506 -22420
Branches 16000 13896 -2104
=============================================
- Hits 90902 52987 -37915
- Misses 34964 52035 +17071
+ Partials 7060 5484 -1576
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <ø> (-15.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120465686
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 47.91%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 47.91% -20.48%
+ Complexity 27505 16153 -11352
=============================================
Files 2428 1994 -434
Lines 132926 110506 -22420
Branches 16000 13896 -2104
=============================================
- Hits 90902 52944 -37958
- Misses 34964 52075 +17111
+ Partials 7060 5487 -1573
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.80% <ø> (-14.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120450567
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.37%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.37% -22.01%
+ Complexity 27505 15012 -12493
=============================================
Files 2428 1948 -480
Lines 132926 105613 -27313
Branches 16000 12848 -3152
=============================================
- Hits 90902 48981 -41921
- Misses 34964 51594 +16630
+ Partials 7060 5038 -2022
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <ø> (-12.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1579 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123278558
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.36%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.36% -23.03%
+ Complexity 27505 15394 -12111
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 50154 -40748
- Misses 34964 55075 +20111
+ Partials 7060 5331 -1729
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128544611
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.35%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.35% -23.04%
+ Complexity 27505 15398 -12107
=============================================
Files 2428 1994 -434
Lines 132926 110575 -22351
Branches 16000 13898 -2102
=============================================
- Hits 90902 50151 -40751
- Misses 34964 55090 +20126
+ Partials 7060 5334 -1726
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128582049
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.17%
+ Complexity 27505 24754 -2751
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 81854 -9048
- Misses 34964 44996 +10032
+ Partials 7060 6863 -197
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <ø> (-16.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [553 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128979790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129190345
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.70%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 58.70% -9.69%
+ Complexity 27505 23791 -3714
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 78490 -12412
- Misses 34964 48513 +13549
+ Partials 7060 6710 -350
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [675 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129809599
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.04%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 61.04% -7.34%
+ Complexity 27573 24641 -2932
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 81630 -9492
- Misses 35093 45292 +10199
+ Partials 7053 6807 -246
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128852759
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27595 +90
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16071 +71
============================================
+ Hits 90902 91161 +259
- Misses 34964 35505 +541
- Partials 7060 7061 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [44 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129246362
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.14% -1.24%
+ Complexity 27505 27191 -314
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 89787 -1115
- Misses 34964 36786 +1822
- Partials 7060 7140 +80
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [224 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129981465
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.18% -0.20%
- Complexity 27573 27594 +21
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
+ Hits 91122 91179 +57
- Misses 35093 35486 +393
- Partials 7053 7064 +11
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <ø> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131699588
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.69%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 58.69% -9.69%
+ Complexity 27573 23792 -3781
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 78492 -12630
- Misses 35093 48524 +13431
+ Partials 7053 6713 -340
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [652 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131692567
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.28%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 48.28% -20.10%
+ Complexity 27573 16337 -11236
=============================================
Files 2433 1994 -439
Lines 133268 110610 -22658
Branches 16034 13908 -2126
=============================================
- Hits 91122 53407 -37715
- Misses 35093 51674 +16581
+ Partials 7053 5529 -1524
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108184047
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.06%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|7|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 67.53% 54.06% -13.47%
+ Complexity 27171 12139 -15032
=============================================
Files 2428 1421 -1007
Lines 132926 69923 -63003
Branches 16000 7792 -8208
=============================================
- Hits 89769 37805 -51964
+ Misses 36038 28759 -7279
+ Partials 7119 3359 -3760
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1744 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124101600
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.20%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.20% -20.19%
+ Complexity 27505 16304 -11201
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13901 -2099
=============================================
- Hits 90902 53295 -37607
- Misses 34964 51729 +16765
+ Partials 7060 5536 -1524
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <ø> (-15.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120536225
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.80%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.80% -2.58%
+ Complexity 27505 26562 -943
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 87901 -3001
- Misses 34964 38390 +3426
- Partials 7060 7280 +220
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [370 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123452908
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.17% -23.22%
+ Complexity 27505 8459 -19046
=============================================
Files 2428 1193 -1235
Lines 132926 61326 -71600
Branches 16000 6550 -9450
=============================================
- Hits 90902 27701 -63201
+ Misses 34964 30617 -4347
+ Partials 7060 3008 -4052
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2032 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124091944
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.35%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.35% -23.04%
+ Complexity 27505 15395 -12110
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13893 -2107
=============================================
- Hits 90902 50142 -40760
- Misses 34964 55082 +20118
+ Partials 7060 5336 -1724
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1550 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124087788
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.37%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.37% -22.02%
+ Complexity 27505 15033 -12472
=============================================
Files 2428 1948 -480
Lines 132926 105584 -27342
Branches 16000 12753 -3247
=============================================
- Hits 90902 48962 -41940
- Misses 34964 51542 +16578
+ Partials 7060 5080 -1980
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-12.34%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1582 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108234686
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|13|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.24% -7.15%
+ Complexity 27505 24696 -2809
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 81684 -9218
- Misses 34964 44835 +9871
+ Partials 7060 6859 -201
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [531 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108270744
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.24%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.24% -1.15%
+ Complexity 27505 27160 -345
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89687 -1215
- Misses 34964 36552 +1588
- Partials 7060 7139 +79
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-3.81%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <ø> (-0.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [183 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120655836
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.18% -0.21%
- Complexity 27505 27565 +60
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
+ Hits 90902 91073 +171
- Misses 34964 35432 +468
- Partials 7060 7066 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <ø> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120639371
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.18% -0.21%
- Complexity 27505 27564 +59
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
+ Hits 90902 91071 +169
- Misses 34964 35433 +469
- Partials 7060 7067 +7
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <ø> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128981515
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.15% -23.24%
+ Complexity 27505 8454 -19051
=============================================
Files 2428 1193 -1235
Lines 132926 61332 -71594
Branches 16000 6551 -9449
=============================================
- Hits 90902 27693 -63209
+ Misses 34964 30627 -4337
+ Partials 7060 3012 -4048
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129367186
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27585 +80
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16073 +73
============================================
+ Hits 90902 91161 +259
- Misses 34964 35503 +539
- Partials 7060 7063 +3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129316232
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.22%
- Complexity 27505 27585 +80
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
+ Hits 90902 91157 +255
- Misses 34964 35492 +528
- Partials 7060 7064 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [45 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129348567
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.22%
- Complexity 27505 27585 +80
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
+ Hits 90902 91159 +257
- Misses 34964 35490 +526
- Partials 7060 7064 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <ø> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131680318
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.36% -23.02%
+ Complexity 27573 15398 -12175
=============================================
Files 2433 1994 -439
Lines 133268 110596 -22672
Branches 16034 13906 -2128
=============================================
- Hits 91122 50168 -40954
- Misses 35093 55091 +19998
+ Partials 7053 5337 -1716
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.70%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128576793
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.28%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.28% -20.10%
+ Complexity 27505 16340 -11165
=============================================
Files 2428 1994 -434
Lines 132926 110594 -22332
Branches 16000 13906 -2094
=============================================
- Hits 90902 53402 -37500
- Misses 34964 51667 +16703
+ Partials 7060 5525 -1535
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <ø> (-16.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128539268
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.85% -22.53%
+ Complexity 27505 15206 -12299
=============================================
Files 2428 1965 -463
Lines 132926 108021 -24905
Branches 16000 13355 -2645
=============================================
- Hits 90902 49538 -41364
- Misses 34964 53304 +18340
+ Partials 7060 5179 -1881
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.54%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128620965
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.17%
+ Complexity 27505 24754 -2751
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 81854 -9048
- Misses 34964 44996 +10032
+ Partials 7060 6863 -197
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <ø> (-16.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [553 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128677888
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.34%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.34% -1.04%
+ Complexity 27505 27266 -239
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 90050 -852
- Misses 34964 36540 +1576
- Partials 7060 7123 +63
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <ø> (-3.69%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [167 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129288186
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.37%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.37% -1.01%
+ Complexity 27505 27270 -235
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 90090 -812
- Misses 34964 36499 +1535
- Partials 7060 7124 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-3.64%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129294392
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27583 +78
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
+ Hits 90902 91151 +249
- Misses 34964 35495 +531
- Partials 7060 7067 +7
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <ø> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129270681
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.23%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.23% -1.15%
+ Complexity 27505 27218 -287
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 89908 -994
- Misses 34964 36668 +1704
- Partials 7060 7137 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <ø> (-3.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [202 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129971060
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.18% -0.20%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
+ Hits 91122 91177 +55
- Misses 35093 35487 +394
- Partials 7053 7065 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <ø> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131638076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
}, {
"hash" : "05b0641891737e38a469b3c23688ea6dd249346e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12852",
"triggerID" : "05b0641891737e38a469b3c23688ea6dd249346e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841)
* 05b0641891737e38a469b3c23688ea6dd249346e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131757052
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.36%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.36% -1.01%
+ Complexity 27573 27279 -294
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
- Hits 91122 90097 -1025
- Misses 35093 36521 +1428
- Partials 7053 7125 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <ø> (-3.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [140 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101887428
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.19%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 59.19% -9.28%
+ Complexity 27472 23381 -4091
============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
============================================
- Hits 90820 77246 -13574
- Misses 34784 46890 +12106
+ Partials 7051 6363 -688
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.03% <ø> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108245166
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.79%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.79% -2.60%
+ Complexity 27505 26513 -992
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 87753 -3149
- Misses 34964 38358 +3394
- Partials 7060 7267 +207
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <ø> (-0.29%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [360 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108270147
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.84%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 65.84% -2.55%
+ Complexity 27505 26532 -973
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 87820 -3082
- Misses 34964 38286 +3322
- Partials 7060 7272 +212
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <ø> (-0.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [349 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108280340
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.31%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.31% -1.08%
+ Complexity 27505 27176 -329
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89782 -1120
- Misses 34964 36475 +1511
- Partials 7060 7121 +61
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-3.81%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [159 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120477093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.00%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.00% -20.39%
+ Complexity 27505 16181 -11324
=============================================
Files 2428 1994 -434
Lines 132926 110506 -22420
Branches 16000 13896 -2104
=============================================
- Hits 90902 53047 -37855
- Misses 34964 51984 +17020
+ Partials 7060 5475 -1585
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.02% <ø> (-15.68%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120455078
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.82%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.82% -22.57%
+ Complexity 27505 15174 -12331
=============================================
Files 2428 1965 -463
Lines 132926 107952 -24974
Branches 16000 13353 -2647
=============================================
- Hits 90902 49464 -41438
- Misses 34964 53312 +18348
+ Partials 7060 5176 -1884
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101661018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124148900
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.26%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.26% -1.13%
+ Complexity 27505 27224 -281
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
- Hits 90902 89884 -1018
- Misses 34964 36633 +1669
- Partials 7060 7119 +59
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [184 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129257664
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.19% -1.19%
+ Complexity 27505 27210 -295
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 89854 -1048
- Misses 34964 36714 +1750
- Partials 7060 7145 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [214 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129867079
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.34%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.34% -1.03%
+ Complexity 27573 27266 -307
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 90066 -1056
- Misses 35093 36542 +1449
- Partials 7053 7121 +68
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <ø> (-3.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [147 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128450835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824)
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128573463
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.25%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.25% -20.13%
+ Complexity 27505 16330 -11175
=============================================
Files 2428 1994 -434
Lines 132926 110594 -22332
Branches 16000 13906 -2094
=============================================
- Hits 90902 53369 -37533
- Misses 34964 51696 +16732
+ Partials 7060 5529 -1531
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <ø> (-15.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120495721
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 61.21% -7.18%
+ Complexity 27505 24726 -2779
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 81765 -9137
- Misses 34964 44939 +9975
+ Partials 7060 6867 -193
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [552 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120554823
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.20%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.20% -1.18%
+ Complexity 27505 27190 -315
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 89768 -1134
- Misses 34964 36656 +1692
- Partials 7060 7147 +87
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <ø> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [206 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123736716
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.17% -20.22%
+ Complexity 27505 16289 -11216
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53261 -37641
- Misses 34964 51753 +16789
+ Partials 7060 5546 -1514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.82% <ø> (-14.88%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2986149895
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1065 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import com.google.common.collect.Lists;
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.ExpressionPredicates;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.FilePathUtils;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.table.format.mor.MergeOnReadTableState;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.HoodieSchemaConverter;
+import org.apache.hudi.util.StreamerUtil;
+import org.apache.hudi.util.RowDataProjection;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+ private final MergeOnReadTableState tableState;
+ private final boolean emitDelete;
+ private final List<ExpressionPredicates.Predicate> predicates;
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableState Merge on Read table state
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ * @param predicates Predicates for push down
+ * @param emitDelete Whether to emit delete
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ MergeOnReadTableState tableState,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes,
+ List<ExpressionPredicates.Predicate> predicates,
+ boolean emitDelete) {
+ this.conf = conf;
+ this.tableState = tableState;
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ this.predicates = predicates;
+ this.emitDelete = emitDelete;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(tableState.getRowType(), wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
+ if (fallbackReaderFunction == null) {
+ fallbackReaderFunction = new HoodieSplitReaderFunction(
+ conf,
+ HoodieSchema.parse(tableState.getTableSchema()),
+ HoodieSchema.parse(tableState.getRequiredSchema()),
+ internalSchemaManager,
+ conf.get(FlinkOptions.MERGE_TYPE),
+ predicates,
+ emitDelete);
+ }
+ return fallbackReaderFunction;
+ }
+
+ private ClosableIterator<RowData> createRecordIteratorSafe(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) {
+ try {
+ return createRecordIterator(tablePath, maxCompactionMemoryInBytes, fileSplit, mode, imageManager, client);
+ } catch (IOException e) {
+ throw new HoodieException("Failed to create CDC record iterator for split: " + fileSplit, e);
+ }
+ }
+
+ private ClosableIterator<RowData> createRecordIterator(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) throws IOException {
+
+ final HoodieSchema tableSchema = HoodieSchema.parse(tableState.getTableSchema());
+ final HoodieSchema requiredSchema = HoodieSchema.parse(tableState.getRequiredSchema());
+ switch (fileSplit.getCdcInferCase()) {
+ case BASE_FILE_INSERT: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for BASE_FILE_INSERT");
+ String path = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ return new AddBaseFileIterator(getBaseFileIterator(path));
+ }
+ case BASE_FILE_DELETE: {
+ ValidationUtils.checkState(fileSplit.getBeforeFileSlice().isPresent(),
+ "Before file slice should exist for BASE_FILE_DELETE");
+ FileSlice fileSlice = fileSplit.getBeforeFileSlice().get();
+ MergeOnReadInputSplit inputSplit = CdcInputFormat.fileSlice2Split(tablePath, fileSlice, maxCompactionMemoryInBytes);
+ return new RemoveBaseFileIterator(tableState.getRequiredRowType(), tableState.getRequiredPositions(), getFileSliceIterator(inputSplit));
+ }
+ case AS_IS: {
+ HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(tableSchema);
+ HoodieSchema cdcSchema = HoodieCDCUtils.schemaBySupplementalLoggingMode(mode, dataSchema);
+ switch (mode) {
+ case DATA_BEFORE_AFTER:
+ return new BeforeAfterImageIterator(
+ getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(), cdcSchema, fileSplit);
+ case DATA_BEFORE:
+ return new BeforeImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(),
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ case OP_KEY_ONLY:
+ return new RecordKeyImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(),
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ default:
+ throw new AssertionError("Unexpected CDC supplemental logging mode: " + mode);
+ }
+ }
+ case LOG_FILE: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for LOG_FILE");
+ String logFilePath = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ MergeOnReadInputSplit split = CdcInputFormat.singleLogFile2Split(tablePath, logFilePath, maxCompactionMemoryInBytes);
+ ClosableIterator<HoodieRecord<RowData>> recordIterator = getFileSliceHoodieRecordIterator(split);
+ return new DataLogFileIterator(
+ maxCompactionMemoryInBytes, imageManager, fileSplit, tableSchema, tableState.getRequiredRowType(), tableState.getRequiredPositions(),
+ recordIterator, client, getWriteConfig());
+ }
+ case REPLACE_COMMIT: {
+ return new ReplaceCommitIterator(
+ conf, tablePath, tableState.getRequiredRowType(), tableState.getRequiredPositions(), maxCompactionMemoryInBytes,
+ fileSplit, this::getFileSliceIterator);
+ }
+ default:
+ throw new AssertionError("Unexpected CDC file split infer case: " + fileSplit.getCdcInferCase());
+ }
+ }
+
+ /** Reads the full-schema before/after image for a file slice (emitDelete=false). */
+ private ClosableIterator<RowData> getFileSliceIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ final HoodieSchema tableSchema = HoodieSchema.parse(tableState.getTableSchema());
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, false,
+ predicates, split.getInstantRange());
+ return reader.getClosableIterator();
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create file slice iterator for split: " + split, e);
+ }
+ }
+
+ /** Reads a single log file and returns a typed {@link HoodieRecord} iterator (for LOG_FILE CDC inference). */
+ private ClosableIterator<HoodieRecord<RowData>> getFileSliceHoodieRecordIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ final HoodieSchema tableSchema = HoodieSchema.parse(tableState.getTableSchema());
+ try {
+ HoodieFileGroupReader<RowData> reader = FormatUtils.createFileGroupReader(
+ getMetaClient(), getWriteConfig(), internalSchemaManager, fileSlice,
+ tableSchema, tableSchema, split.getLatestCommit(),
+ FlinkOptions.REALTIME_PAYLOAD_COMBINE, true,
+ Collections.emptyList(), split.getInstantRange());
Review Comment:
`Collections.emptyList()` -> `predicates`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128367922
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.15% -23.24%
+ Complexity 27505 8453 -19052
=============================================
Files 2428 1193 -1235
Lines 132926 61332 -71594
Branches 16000 6551 -9449
=============================================
- Hits 90902 27693 -63209
+ Misses 34964 30627 -4337
+ Partials 7060 3012 -4048
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128775059
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27595 +90
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16071 +71
============================================
+ Hits 90902 91160 +258
- Misses 34964 35505 +541
- Partials 7060 7062 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <ø> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [45 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129104871
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.17% -14.22%
+ Complexity 27505 12184 -15321
=============================================
Files 2428 1422 -1006
Lines 132926 70019 -62907
Branches 16000 7802 -8198
=============================================
- Hits 90902 37933 -52969
+ Misses 34964 28721 -6243
+ Partials 7060 3365 -3695
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1780 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129147420
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.44%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.44% -21.95%
+ Complexity 27505 15042 -12463
=============================================
Files 2428 1948 -480
Lines 132926 105703 -27223
Branches 16000 12865 -3135
=============================================
- Hits 90902 49089 -41813
- Misses 34964 51569 +16605
+ Partials 7060 5045 -2015
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <ø> (-12.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129543934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839)
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129769192
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.85% -22.52%
+ Complexity 27573 15204 -12369
=============================================
Files 2433 1965 -468
Lines 133268 108037 -25231
Branches 16034 13357 -2677
=============================================
- Hits 91122 49542 -41580
- Misses 35093 53314 +18221
+ Partials 7053 5181 -1872
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131746792
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.28%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.28% -1.10%
+ Complexity 27573 27242 -331
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
- Hits 91122 89987 -1135
- Misses 35093 36631 +1538
- Partials 7053 7125 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18361:
URL: https://github.com/apache/hudi/pull/18361#discussion_r2992164219
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieCdcSplitReaderFunction.java:
##########
@@ -0,0 +1,1064 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source.reader.function;
+
+import org.apache.hudi.client.model.HoodieFlinkRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.common.engine.HoodieReaderContext;
+import org.apache.hudi.common.model.FileSlice;
+import org.apache.hudi.common.model.HoodieBaseFile;
+import org.apache.hudi.common.model.HoodieFileGroupId;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieOperation;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaField;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.cdc.HoodieCDCFileSplit;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.cdc.HoodieCDCUtils;
+import org.apache.hudi.common.table.log.HoodieCDCLogRecordIterator;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.table.read.BufferedRecordMerger;
+import org.apache.hudi.common.table.read.BufferedRecordMergerFactory;
+import org.apache.hudi.common.table.read.BufferedRecords;
+import org.apache.hudi.common.table.read.DeleteContext;
+import org.apache.hudi.common.table.read.HoodieFileGroupReader;
+import org.apache.hudi.common.util.CollectionUtils;
+import org.apache.hudi.common.util.ConfigUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.common.util.collection.ClosableIterator;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.HadoopConfigurations;
+import org.apache.hudi.configuration.OptionsResolver;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.source.ExpressionPredicates;
+import org.apache.hudi.source.reader.BatchRecords;
+import org.apache.hudi.source.reader.HoodieRecordWithPosition;
+import org.apache.hudi.source.split.HoodieCdcSourceSplit;
+import org.apache.hudi.source.split.HoodieSourceSplit;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.HoodieStorageUtils;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.format.FormatUtils;
+import org.apache.hudi.table.format.FilePathUtils;
+import org.apache.hudi.table.format.FlinkReaderContextFactory;
+import org.apache.hudi.table.format.InternalSchemaManager;
+import org.apache.hudi.table.format.RecordIterators;
+import org.apache.hudi.table.format.cdc.CdcInputFormat;
+import org.apache.hudi.table.format.mor.MergeOnReadInputSplit;
+import org.apache.hudi.table.format.mor.MergeOnReadTableState;
+import org.apache.hudi.util.AvroToRowDataConverters;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.HoodieSchemaConverter;
+import org.apache.hudi.util.StreamerUtil;
+import org.apache.hudi.util.RowDataProjection;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.GenericRecordBuilder;
+import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.types.RowKind;
+import org.apache.hadoop.fs.Path;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.hudi.hadoop.utils.HoodieInputFormatUtils.HOODIE_RECORD_KEY_COL_POS;
+import static org.apache.hudi.table.format.FormatUtils.buildAvroRecordBySchema;
+
+/**
+ * CDC reader function for source V2. Reads CDC splits ({@link HoodieCdcSourceSplit}) and
+ * emits change-log {@link RowData} records tagged with the appropriate {@link RowKind}.
+ *
+ * <p>The implementation mirrors the logic in {@link CdcInputFormat}, adapted for the
+ * {@link SplitReaderFunction} contract.
+ */
+@Slf4j
+public class HoodieCdcSplitReaderFunction implements SplitReaderFunction<RowData> {
+
+ private final org.apache.flink.configuration.Configuration conf;
+ private final InternalSchemaManager internalSchemaManager;
+ private final List<DataType> fieldTypes;
+ private final MergeOnReadTableState tableState;
+ private final boolean emitDelete;
+ private final List<ExpressionPredicates.Predicate> predicates;
+ private transient HoodieTableMetaClient metaClient;
+ private transient HoodieWriteConfig writeConfig;
+ private transient org.apache.hadoop.conf.Configuration hadoopConf;
+ private transient ClosableIterator<RowData> currentIterator;
+ // Fallback reader for non-CDC splits (e.g. snapshot reads when read.start-commit='earliest')
+ private transient HoodieSplitReaderFunction fallbackReaderFunction;
+
+ /**
+ * Creates a CDC split reader function.
+ *
+ * @param conf Flink configuration
+ * @param tableState Merge on Read table state
+ * @param internalSchemaManager Schema-evolution manager
+ * @param fieldTypes DataType list for all table fields (used for parquet reading)
+ * @param predicates Predicates for push down
+ * @param emitDelete Whether to emit delete
+ */
+ public HoodieCdcSplitReaderFunction(
+ org.apache.flink.configuration.Configuration conf,
+ MergeOnReadTableState tableState,
+ InternalSchemaManager internalSchemaManager,
+ List<DataType> fieldTypes,
+ List<ExpressionPredicates.Predicate> predicates,
+ boolean emitDelete) {
+ this.conf = conf;
+ this.tableState = tableState;
+ this.internalSchemaManager = internalSchemaManager;
+ this.fieldTypes = fieldTypes;
+ this.predicates = predicates;
+ this.emitDelete = emitDelete;
+ }
+
+ @Override
+ public RecordsWithSplitIds<HoodieRecordWithPosition<RowData>> read(HoodieSourceSplit split) {
+ if (!(split instanceof HoodieCdcSourceSplit)) {
+ // Non-CDC splits arrive when reading from 'earliest' with no prior CDC history
+ // (i.e. instantRange is empty → snapshot path). Fall back to the standard MOR reader
+ // which emits all records as INSERT rows, matching the expected snapshot behaviour.
+ return getFallbackReaderFunction().read(split);
+ }
+ HoodieCdcSourceSplit cdcSplit = (HoodieCdcSourceSplit) split;
+
+ HoodieCDCSupplementalLoggingMode mode = OptionsResolver.getCDCSupplementalLoggingMode(conf);
+ HoodieTableMetaClient client = getMetaClient();
+ HoodieWriteConfig wConfig = getWriteConfig();
+
+ ImageManager imageManager = new ImageManager(tableState.getRowType(), wConfig, this::getFileSliceIterator);
+
+ Function<HoodieCDCFileSplit, ClosableIterator<RowData>> recordIteratorFunc =
+ cdcFileSplit -> createRecordIteratorSafe(
+ cdcSplit.getTablePath(),
+ cdcSplit.getMaxCompactionMemoryInBytes(),
+ cdcFileSplit,
+ mode,
+ imageManager,
+ client);
+
+ currentIterator = new CdcFileSplitsIterator(cdcSplit.getChanges(), imageManager, recordIteratorFunc);
+ BatchRecords<RowData> records = BatchRecords.forRecords(
+ split.splitId(), currentIterator, split.getFileOffset(), split.getConsumed());
+ records.seek(split.getConsumed());
+ return records;
+ }
+
+ @Override
+ public void close() throws Exception {
+ if (currentIterator != null) {
+ currentIterator.close();
+ }
+ if (fallbackReaderFunction != null) {
+ fallbackReaderFunction.close();
+ }
+ }
+
+ // -------------------------------------------------------------------------
+ // Internal helpers
+ // -------------------------------------------------------------------------
+
+ private HoodieSplitReaderFunction getFallbackReaderFunction() {
+ if (fallbackReaderFunction == null) {
+ fallbackReaderFunction = new HoodieSplitReaderFunction(
+ conf,
+ HoodieSchema.parse(tableState.getTableSchema()),
+ HoodieSchema.parse(tableState.getRequiredSchema()),
+ internalSchemaManager,
+ conf.get(FlinkOptions.MERGE_TYPE),
+ predicates,
+ emitDelete);
+ }
+ return fallbackReaderFunction;
+ }
+
+ private ClosableIterator<RowData> createRecordIteratorSafe(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) {
+ try {
+ return createRecordIterator(tablePath, maxCompactionMemoryInBytes, fileSplit, mode, imageManager, client);
+ } catch (IOException e) {
+ throw new HoodieException("Failed to create CDC record iterator for split: " + fileSplit, e);
+ }
+ }
+
+ private ClosableIterator<RowData> createRecordIterator(
+ String tablePath,
+ long maxCompactionMemoryInBytes,
+ HoodieCDCFileSplit fileSplit,
+ HoodieCDCSupplementalLoggingMode mode,
+ ImageManager imageManager,
+ HoodieTableMetaClient client) throws IOException {
+
+ final HoodieSchema tableSchema = HoodieSchema.parse(tableState.getTableSchema());
+ final HoodieSchema requiredSchema = HoodieSchema.parse(tableState.getRequiredSchema());
+ switch (fileSplit.getCdcInferCase()) {
+ case BASE_FILE_INSERT: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for BASE_FILE_INSERT");
+ String path = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ return new AddBaseFileIterator(getBaseFileIterator(path));
+ }
+ case BASE_FILE_DELETE: {
+ ValidationUtils.checkState(fileSplit.getBeforeFileSlice().isPresent(),
+ "Before file slice should exist for BASE_FILE_DELETE");
+ FileSlice fileSlice = fileSplit.getBeforeFileSlice().get();
+ MergeOnReadInputSplit inputSplit = CdcInputFormat.fileSlice2Split(tablePath, fileSlice, maxCompactionMemoryInBytes);
+ return new RemoveBaseFileIterator(tableState.getRequiredRowType(), tableState.getRequiredPositions(), getFileSliceIterator(inputSplit));
+ }
+ case AS_IS: {
+ HoodieSchema dataSchema = HoodieSchemaUtils.removeMetadataFields(tableSchema);
+ HoodieSchema cdcSchema = HoodieCDCUtils.schemaBySupplementalLoggingMode(mode, dataSchema);
+ switch (mode) {
+ case DATA_BEFORE_AFTER:
+ return new BeforeAfterImageIterator(
+ getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(), cdcSchema, fileSplit);
+ case DATA_BEFORE:
+ return new BeforeImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(),
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ case OP_KEY_ONLY:
+ return new RecordKeyImageIterator(
+ conf, getHadoopConf(), tablePath, tableSchema, requiredSchema, tableState.getRequiredRowType(),
+ maxCompactionMemoryInBytes, cdcSchema, fileSplit, imageManager);
+ default:
+ throw new AssertionError("Unexpected CDC supplemental logging mode: " + mode);
+ }
+ }
+ case LOG_FILE: {
+ ValidationUtils.checkState(fileSplit.getCdcFiles() != null && fileSplit.getCdcFiles().size() == 1,
+ "CDC file path should exist and be singleton for LOG_FILE");
+ String logFilePath = new Path(tablePath, fileSplit.getCdcFiles().get(0)).toString();
+ MergeOnReadInputSplit split = CdcInputFormat.singleLogFile2Split(tablePath, logFilePath, maxCompactionMemoryInBytes);
+ ClosableIterator<HoodieRecord<RowData>> recordIterator = getFileSliceHoodieRecordIterator(split);
+ return new DataLogFileIterator(
+ maxCompactionMemoryInBytes, imageManager, fileSplit, tableSchema, tableState.getRequiredRowType(), tableState.getRequiredPositions(),
+ recordIterator, client, getWriteConfig());
+ }
+ case REPLACE_COMMIT: {
+ return new ReplaceCommitIterator(
+ conf, tablePath, tableState.getRequiredRowType(), tableState.getRequiredPositions(), maxCompactionMemoryInBytes,
+ fileSplit, this::getFileSliceIterator);
+ }
+ default:
+ throw new AssertionError("Unexpected CDC file split infer case: " + fileSplit.getCdcInferCase());
+ }
+ }
+
+ /** Reads the full-schema before/after image for a file slice (emitDelete=false). */
+ private ClosableIterator<RowData> getFileSliceIterator(MergeOnReadInputSplit split) {
+ FileSlice fileSlice = buildFileSlice(split);
+ final HoodieSchema tableSchema = HoodieSchema.parse(tableState.getTableSchema());
Review Comment:
did we intern the schema just like what we did in `CdcInputFormat` with call `HoodieSchemaCache.intern`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120491716
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.31602%` with `382 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.51%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.54% | [366 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 58.51% -9.87%
+ Complexity 27505 23655 -3850
============================================
Files 2428 2434 +6
Lines 132926 133571 +645
Branches 16000 16056 +56
============================================
- Hits 90902 78162 -12740
- Misses 34964 48752 +13788
+ Partials 7060 6657 -403
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.23% <17.31%> (-0.12%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.18% <ø> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.78% <0.00%> (-1.23%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.54% <6.54%> (ø)` | |
... and [672 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123363531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* d481a60fde89534f6ca64b07a66d57bb45f8b09e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804)
* 18d4c27fe8487962d47633cc38c0765c04b96c63 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817)
* 09af38b4d894ca0f90833697a71e64bf50453e03 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124157658
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.14% -0.24%
- Complexity 27505 27574 +69
============================================
Files 2428 2434 +6
Lines 132926 133636 +710
Branches 16000 16062 +62
============================================
+ Hits 90902 91069 +167
- Misses 34964 35509 +545
+ Partials 7060 7058 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.22% <15.01%> (-0.13%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <ø> (-0.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108016225
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.06%. Comparing base ([`3aef2ca`](https://app.codecov.io/gh/apache/hudi/commit/3aef2cacdb1ca6e5bbe1be50caf3d0bfd8e6caaf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a50dd55`](https://app.codecov.io/gh/apache/hudi/commit/a50dd5580cf75c4e0a2a04b1152deef26055b40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (3aef2ca) and HEAD (a50dd55). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (3aef2ca) | HEAD (a50dd55) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.46% 45.06% -23.40%
+ Complexity 27472 8429 -19043
=============================================
Files 2427 1192 -1235
Lines 132655 61236 -71419
Branches 15994 6541 -9453
=============================================
- Hits 90819 27596 -63223
+ Misses 34786 30634 -4152
+ Partials 7050 3006 -4044
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (+0.06%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2030 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101792948
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101920259
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.27%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 68.27% -0.19%
- Complexity 27472 27492 +20
============================================
Files 2427 2429 +2
Lines 132655 133067 +412
Branches 15994 16024 +30
============================================
+ Hits 90820 90857 +37
- Misses 34784 35157 +373
- Partials 7051 7053 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <ø> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.64% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128535047
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.94%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.94% -21.45%
+ Complexity 27505 14872 -12633
=============================================
Files 2428 1931 -497
Lines 132926 103256 -29670
Branches 16000 12255 -3745
=============================================
- Hits 90902 48471 -42431
- Misses 34964 49852 +14888
+ Partials 7060 4933 -2127
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <ø> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1593 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129170028
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.15%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.15% -20.24%
+ Complexity 27505 16290 -11215
=============================================
Files 2428 1994 -434
Lines 132926 110580 -22346
Branches 16000 13906 -2094
=============================================
- Hits 90902 53248 -37654
- Misses 34964 51786 +16822
+ Partials 7060 5546 -1514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.78% <ø> (-14.92%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1499 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129160045
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.91%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.91% -22.47%
+ Complexity 27505 15234 -12271
=============================================
Files 2428 1977 -451
Lines 132926 108262 -24664
Branches 16000 13414 -2586
=============================================
- Hits 90902 49709 -41193
- Misses 34964 53354 +18390
+ Partials 7060 5199 -1861
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.46%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1558 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129188456
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.68%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 58.68% -9.71%
+ Complexity 27505 23780 -3725
============================================
Files 2428 2435 +7
Lines 132926 133699 +773
Branches 16000 16069 +69
============================================
- Hits 90902 78456 -12446
- Misses 34964 48528 +13564
+ Partials 7060 6715 -345
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <ø> (-15.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [675 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129251531
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.14% -1.24%
+ Complexity 27505 27191 -314
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 89787 -1115
- Misses 34964 36786 +1822
- Partials 7060 7140 +80
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [224 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129277226
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.34%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.34% -1.04%
+ Complexity 27505 27256 -249
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
- Hits 90902 90052 -850
- Misses 34964 36537 +1573
- Partials 7060 7124 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <ø> (-3.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [170 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129296627
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27583 +78
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16071 +71
============================================
+ Hits 90902 91151 +249
- Misses 34964 35495 +531
- Partials 7060 7067 +7
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <ø> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129364436
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.16% -0.22%
- Complexity 27505 27585 +80
============================================
Files 2428 2435 +7
Lines 132926 133727 +801
Branches 16000 16073 +73
============================================
+ Hits 90902 91161 +259
- Misses 34964 35503 +539
- Partials 7060 7063 +3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.39% <ø> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129614757
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.15% -23.22%
+ Complexity 27573 8456 -19117
=============================================
Files 2433 1193 -1240
Lines 133268 61348 -71920
Branches 16034 6553 -9481
=============================================
- Hits 91122 27703 -63419
+ Misses 35093 30633 -4460
+ Partials 7053 3012 -4041
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2034 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129791313
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.51%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 58.51% -9.86%
+ Complexity 27573 23680 -3893
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 78255 -12867
- Misses 35093 48817 +13724
+ Partials 7053 6657 -396
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [656 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129857097
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.88%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 65.88% -2.50%
+ Complexity 27573 26613 -960
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 88101 -3021
- Misses 35093 38372 +3279
- Partials 7053 7256 +203
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.07%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [331 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108219014
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.21% -20.17%
+ Complexity 27505 16287 -11218
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 53263 -37637
- Misses 34966 51679 +16713
+ Partials 7060 5528 -1532
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.04% <ø> (-15.59%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108208493
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (315776c). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (315776c) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.29% -23.10%
+ Complexity 27505 15349 -12156
=============================================
Files 2428 1993 -435
Lines 132926 110470 -22456
Branches 16000 13894 -2106
=============================================
- Hits 90900 50034 -40866
- Misses 34966 55106 +20140
+ Partials 7060 5330 -1730
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (-12.71%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1545 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128282622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* ddc24b5d0fdc0eb637abde75f4c597d69fac941d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824)
* 6012c92f145bff09f68e559267900b1ed252d307 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128680690
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.14% -0.25%
- Complexity 27505 27577 +72
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
+ Hits 90902 91113 +211
- Misses 34964 35534 +570
- Partials 7060 7066 +6
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <ø> (-0.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [52 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128686992
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 68.17% -0.22%
- Complexity 27505 27592 +87
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
+ Hits 90902 91154 +252
- Misses 34964 35494 +530
- Partials 7060 7065 +5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <ø> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [44 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131676572
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.86%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.86% -22.51%
+ Complexity 27573 15206 -12367
=============================================
Files 2433 1965 -468
Lines 133268 108023 -25245
Branches 16034 13355 -2679
=============================================
- Hits 91122 49548 -41574
- Misses 35093 53292 +18199
+ Partials 7053 5183 -1870
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.50%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131746070
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.25%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.25% -1.12%
+ Complexity 27573 27226 -347
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 89942 -1180
- Misses 35093 36669 +1576
- Partials 7053 7118 +65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <ø> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [167 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131825937
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.17% -0.21%
- Complexity 27573 27596 +23
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
+ Hits 91122 91178 +56
- Misses 35093 35500 +407
- Partials 7053 7065 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <ø> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131770245
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.16% -0.21%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
+ Hits 91122 91171 +49
- Misses 35093 35505 +412
- Partials 7053 7067 +14
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.62% <ø> (-0.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108114919
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* 315776c04ec79cbfb7fbbe012f574a2b72b722f6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120296040
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.14%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d481a60`](https://app.codecov.io/gh/apache/hudi/commit/d481a60fde89534f6ca64b07a66d57bb45f8b09e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (d481a60). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (d481a60) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.14% -23.24%
+ Complexity 27505 8449 -19056
=============================================
Files 2428 1193 -1235
Lines 132926 61272 -71654
Branches 16000 6543 -9457
=============================================
- Hits 90902 27664 -63238
+ Misses 34964 30599 -4365
+ Partials 7060 3009 -4051
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2033 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123328135
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.30%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.30% -20.09%
+ Complexity 27505 16335 -11170
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53402 -37500
- Misses 34964 51636 +16672
+ Partials 7060 5522 -1538
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <ø> (-16.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123735711
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.17% -20.22%
+ Complexity 27505 16289 -11216
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53261 -37641
- Misses 34964 51753 +16789
+ Partials 7060 5546 -1514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.82% <ø> (-14.88%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123752142
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.29%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.29% -20.09%
+ Complexity 27505 16332 -11173
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53399 -37503
- Misses 34964 51636 +16672
+ Partials 7060 5525 -1535
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <ø> (-16.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124095723
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.35%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.35% -23.03%
+ Complexity 27505 15395 -12110
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13901 -2099
=============================================
- Hits 90902 50148 -40754
- Misses 34964 55078 +20114
+ Partials 7060 5334 -1726
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4124102073
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.20%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddc24b5`](https://app.codecov.io/gh/apache/hudi/commit/ddc24b5d0fdc0eb637abde75f4c597d69fac941d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (ddc24b5). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (ddc24b5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.20% -20.19%
+ Complexity 27505 16304 -11201
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13901 -2099
=============================================
- Hits 90902 53295 -37607
- Misses 34964 51729 +16765
+ Partials 7060 5536 -1524
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <ø> (-15.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4120815792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* d481a60fde89534f6ca64b07a66d57bb45f8b09e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101733015
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.06%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.46% 45.06% -23.41%
+ Complexity 27472 8427 -19045
=============================================
Files 2427 1192 -1235
Lines 132655 61236 -71419
Branches 15994 6541 -9453
=============================================
- Hits 90820 27593 -63227
+ Misses 34784 30636 -4148
+ Partials 7051 3007 -4044
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2028 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101913943
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.17%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (967e456) and HEAD (e7393cc). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (967e456) | HEAD (e7393cc) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 61.17% -7.30%
+ Complexity 27472 24133 -3339
============================================
Files 2427 2400 -27
Lines 132655 130499 -2156
Branches 15994 15399 -595
============================================
- Hits 90820 79830 -10990
- Misses 34784 44117 +9333
+ Partials 7051 6552 -499
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.03% <ø> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <ø> (-11.78%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [558 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4101919997
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.05882%` with `378 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.27%. Comparing base ([`967e456`](https://app.codecov.io/gh/apache/hudi/commit/967e456cc4569e85d20724f49631eac73561c422?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7393cc`](https://app.codecov.io/gh/apache/hudi/commit/e7393ccf29eb0a248bdde4da3e27ddc36da93e15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 5.86% | [366 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.46% 68.27% -0.19%
- Complexity 27472 27492 +20
============================================
Files 2427 2429 +2
Lines 132655 133067 +412
Branches 15994 16024 +30
============================================
+ Hits 90820 90856 +36
- Misses 34784 35157 +373
- Partials 7051 7054 +3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <11.05%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <ø> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.64% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `94.11% <100.00%> (+9.50%)` | :arrow_up: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `5.86% <5.86%> (ø)` | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108049240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* e7393ccf29eb0a248bdde4da3e27ddc36da93e15 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742)
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4108294268
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.24138%` with `384 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.41%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`315776c`](https://app.codecov.io/gh/apache/hudi/commit/315776c04ec79cbfb7fbbe012f574a2b72b722f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 6.51% | [368 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.41% -0.97%
+ Complexity 27505 27221 -284
============================================
Files 2428 2430 +2
Lines 132926 133378 +452
Branches 16000 16038 +38
============================================
- Hits 90902 89922 -980
- Misses 34964 36339 +1375
- Partials 7060 7117 +57
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.26% <17.24%> (-0.09%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.21% <ø> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <ø> (-3.65%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.59% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.98% <0.00%> (-1.03%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `6.51% <6.51%> (ø)` | |
... and [131 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129833670
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.75%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 65.75% -2.63%
+ Complexity 27573 26567 -1006
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 87932 -3190
- Misses 35093 38525 +3432
- Partials 7053 7272 +219
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <ø> (-16.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-0.29%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [366 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129875104
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.37%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 67.37% -1.00%
+ Complexity 27573 27280 -293
============================================
Files 2433 2435 +2
Lines 133268 133729 +461
Branches 16034 16071 +37
============================================
- Hits 91122 90103 -1019
- Misses 35093 36505 +1412
- Partials 7053 7121 +68
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <ø> (-3.69%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.49% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128551450
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.35%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.35% -23.03%
+ Complexity 27505 15398 -12107
=============================================
Files 2428 1994 -434
Lines 132926 110580 -22346
Branches 16000 13904 -2096
=============================================
- Hits 90902 50155 -40747
- Misses 34964 55092 +20128
+ Partials 7060 5333 -1727
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128536817
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.37%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 46.37% -22.02%
+ Complexity 27505 15037 -12468
=============================================
Files 2428 1948 -480
Lines 132926 105604 -27322
Branches 16000 12756 -3244
=============================================
- Hits 90902 48970 -41932
- Misses 34964 51556 +16592
+ Partials 7060 5078 -1982
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.06% <ø> (-12.35%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1582 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128507202
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.17% -14.22%
+ Complexity 27505 12184 -15321
=============================================
Files 2428 1422 -1006
Lines 132926 70019 -62907
Branches 16000 7802 -8198
=============================================
- Hits 90902 37933 -52969
+ Misses 34964 28722 -6242
+ Partials 7060 3364 -3696
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1780 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128665266
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.01057%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.26%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.38% 67.26% -1.12%
+ Complexity 27505 27236 -269
============================================
Files 2428 2435 +7
Lines 132926 133713 +787
Branches 16000 16069 +69
============================================
- Hits 90902 89948 -954
- Misses 34964 36639 +1675
- Partials 7060 7126 +66
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.01%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <ø> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <ø> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.52% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <0.00%> (-1.63%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [186 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131765846
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `15.36842%` with `402 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.16%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | 3.94% | [385 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | 93.54% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
============================================
- Coverage 68.37% 68.16% -0.21%
- Complexity 27573 27593 +20
============================================
Files 2433 2435 +2
Lines 133268 133743 +475
Branches 16034 16073 +39
============================================
+ Hits 91122 91171 +49
- Misses 35093 35505 +412
- Partials 7053 7067 +14
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.24% <15.36%> (-0.11%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <ø> (-0.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <ø> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/hudi/source/split/HoodieCdcSourceSplit.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieCdcSourceSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNkY1NvdXJjZVNwbGl0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../hudi/source/split/HoodieContinuousSplitBatch.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieContinuousSplitBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZUNvbnRpbnVvdXNTcGxpdEJhdGNoLmphdmE=) | `97.36% <100.00%> (+12.75%)` | :arrow_up: |
| [.../hudi/table/format/mor/MergeOnReadInputFormat.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadInputFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZElucHV0Rm9ybWF0LmphdmE=) | `90.62% <ø> (ø)` | |
| [...e/hudi/table/format/mor/MergeOnReadTableState.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fformat%2Fmor%2FMergeOnReadTableState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvZm9ybWF0L21vci9NZXJnZU9uUmVhZFRhYmxlU3RhdGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...hudi/source/split/HoodieSourceSplitSerializer.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Fsplit%2FHoodieSourceSplitSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3NwbGl0L0hvb2RpZVNvdXJjZVNwbGl0U2VyaWFsaXplci5qYXZh) | `98.36% <93.54%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/hudi/table/HoodieTableSource.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVTb3VyY2UuamF2YQ==) | `57.38% <16.66%> (-1.42%)` | :arrow_down: |
| [.../reader/function/HoodieCdcSplitReaderFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18361?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsource%2Freader%2Ffunction%2FHoodieCdcSplitReaderFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc291cmNlL3JlYWRlci9mdW5jdGlvbi9Ib29kaWVDZGNTcGxpdFJlYWRlckZ1bmN0aW9uLmphdmE=) | `3.94% <3.94%> (ø)` | |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129166655
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.36%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.36% -23.03%
+ Complexity 27505 15394 -12111
=============================================
Files 2428 1994 -434
Lines 132926 110566 -22360
Branches 16000 13904 -2096
=============================================
- Hits 90902 50158 -40744
- Misses 34964 55075 +20111
+ Partials 7060 5333 -1727
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1549 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129625404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 6012c92f145bff09f68e559267900b1ed252d307 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835)
* e76ad6569ed2a38e27941c288c3f6a0355fc9942 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839)
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4130091300
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa09b8fc3e1a02b872a596fedad42be9adcb8a58",
"triggerType" : "PUSH"
}, {
"hash" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12742",
"triggerID" : "e7393ccf29eb0a248bdde4da3e27ddc36da93e15",
"triggerType" : "PUSH"
}, {
"hash" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a50dd5580cf75c4e0a2a04b1152deef26055b40c",
"triggerType" : "PUSH"
}, {
"hash" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c026cc52826cfbb62a9a3aa66edfa8529b9da2d4",
"triggerType" : "PUSH"
}, {
"hash" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12779",
"triggerID" : "315776c04ec79cbfb7fbbe012f574a2b72b722f6",
"triggerType" : "PUSH"
}, {
"hash" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12804",
"triggerID" : "d481a60fde89534f6ca64b07a66d57bb45f8b09e",
"triggerType" : "PUSH"
}, {
"hash" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12817",
"triggerID" : "18d4c27fe8487962d47633cc38c0765c04b96c63",
"triggerType" : "PUSH"
}, {
"hash" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12820",
"triggerID" : "09af38b4d894ca0f90833697a71e64bf50453e03",
"triggerType" : "PUSH"
}, {
"hash" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aba869f120c7258d6fcdcabb01f5f88d4992c2e1",
"triggerType" : "PUSH"
}, {
"hash" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12824",
"triggerID" : "ddc24b5d0fdc0eb637abde75f4c597d69fac941d",
"triggerType" : "PUSH"
}, {
"hash" : "6012c92f145bff09f68e559267900b1ed252d307",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12835",
"triggerID" : "6012c92f145bff09f68e559267900b1ed252d307",
"triggerType" : "PUSH"
}, {
"hash" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12839",
"triggerID" : "e76ad6569ed2a38e27941c288c3f6a0355fc9942",
"triggerType" : "PUSH"
}, {
"hash" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841",
"triggerID" : "07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa09b8fc3e1a02b872a596fedad42be9adcb8a58 UNKNOWN
* a50dd5580cf75c4e0a2a04b1152deef26055b40c UNKNOWN
* c026cc52826cfbb62a9a3aa66edfa8529b9da2d4 UNKNOWN
* aba869f120c7258d6fcdcabb01f5f88d4992c2e1 UNKNOWN
* 07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12841)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "HuangZhenQiu (via GitHub)" <gi...@apache.org>.
HuangZhenQiu commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4130292777
@cshuo @danny0405 Thanks for the kind review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129775604
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`07cbc1c`](https://app.codecov.io/gh/apache/hudi/commit/07cbc1c4a82328ca0ed57052f89426b5cfb3b0fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (07cbc1c). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (07cbc1c) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 45.85% -22.52%
+ Complexity 27573 15204 -12369
=============================================
Files 2433 1965 -468
Lines 133268 108037 -25231
Branches 16034 13357 -2677
=============================================
- Hits 91122 49542 -41580
- Misses 35093 53314 +18221
+ Partials 7053 5181 -1872
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <ø> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <ø> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128568990
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.22%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.22% -20.17%
+ Complexity 27505 16317 -11188
=============================================
Files 2428 1994 -434
Lines 132926 110594 -22332
Branches 16000 13906 -2094
=============================================
- Hits 90902 53329 -37573
- Misses 34964 51734 +16770
+ Partials 7060 5531 -1529
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.43% <ø> (-15.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4128569986
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.22%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6012c92`](https://app.codecov.io/gh/apache/hudi/commit/6012c92f145bff09f68e559267900b1ed252d307?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (6012c92). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (6012c92) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.22% -20.17%
+ Complexity 27505 16317 -11188
=============================================
Files 2428 1994 -434
Lines 132926 110594 -22332
Branches 16000 13906 -2094
=============================================
- Hits 90902 53329 -37573
- Misses 34964 51734 +16770
+ Partials 7060 5531 -1529
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.36%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.43% <ø> (-15.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4129184439
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.21%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e76ad65`](https://app.codecov.io/gh/apache/hudi/commit/e76ad6569ed2a38e27941c288c3f6a0355fc9942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (e76ad65). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (e76ad65) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.21% -20.18%
+ Complexity 27505 16308 -11197
=============================================
Files 2428 1994 -434
Lines 132926 110580 -22346
Branches 16000 13906 -2094
=============================================
- Hits 90902 53316 -37586
- Misses 34964 51732 +16768
+ Partials 7060 5532 -1528
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.46% <ø> (-15.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4131674796
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.94%. Comparing base ([`69fa35b`](https://app.codecov.io/gh/apache/hudi/commit/69fa35b1015fcc39e762c29b03bef8fa2ec59d58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05b0641`](https://app.codecov.io/gh/apache/hudi/commit/05b0641891737e38a469b3c23688ea6dd249346e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (69fa35b) and HEAD (05b0641). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (69fa35b) | HEAD (05b0641) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.37% 46.94% -21.43%
+ Complexity 27573 14871 -12702
=============================================
Files 2433 1931 -502
Lines 133268 103272 -29996
Branches 16034 12257 -3777
=============================================
- Hits 91122 48486 -42636
- Misses 35093 49848 +14755
+ Partials 7053 4938 -2115
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (ø)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.34% <ø> (-12.04%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1593 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123329625
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.30%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.30% -20.09%
+ Complexity 27505 16335 -11170
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53402 -37500
- Misses 34964 51636 +16672
+ Partials 7060 5522 -1538
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <ø> (-16.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123302700
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 48.18% -20.20%
+ Complexity 27505 16301 -11204
=============================================
Files 2428 1994 -434
Lines 132926 110560 -22366
Branches 16000 13903 -2097
=============================================
- Hits 90902 53277 -37625
- Misses 34964 51741 +16777
+ Partials 7060 5542 -1518
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.89% <ø> (-14.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1501 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123271248
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.86%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18d4c27`](https://app.codecov.io/gh/apache/hudi/commit/18d4c27fe8487962d47633cc38c0765c04b96c63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (18d4c27). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (18d4c27) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 45.86% -22.53%
+ Complexity 27505 15202 -12303
=============================================
Files 2428 1965 -463
Lines 132926 108001 -24925
Branches 16000 13354 -2646
=============================================
- Hits 90902 49534 -41368
- Misses 34964 53290 +18326
+ Partials 7060 5177 -1883
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <ø> (+0.07%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <ø> (-12.53%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add Flink source reader function for cdc splits [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18361:
URL: https://github.com/apache/hudi/pull/18361#issuecomment-4123671685
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.17%. Comparing base ([`817b3ad`](https://app.codecov.io/gh/apache/hudi/commit/817b3ad7de92602ae301c0b1d1931e016f1261a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`09af38b`](https://app.codecov.io/gh/apache/hudi/commit/09af38b4d894ca0f90833697a71e64bf50453e03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (817b3ad) and HEAD (09af38b). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (817b3ad) | HEAD (09af38b) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18361 +/- ##
=============================================
- Coverage 68.38% 54.17% -14.21%
+ Complexity 27505 12184 -15321
=============================================
Files 2428 1422 -1006
Lines 132926 70013 -62913
Branches 16000 7801 -8199
=============================================
- Hits 90902 37932 -52970
+ Misses 34964 28717 -6247
+ Partials 7060 3364 -3696
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <ø> (+0.10%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <ø> (+0.35%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1781 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org