You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/15 18:22:46 UTC
[GitHub] [cordova-windows] brodybits commented on a change in pull request
#264: [WIP] Win10 only
brodybits commented on a change in pull request #264: [WIP] Win10 only
URL: https://github.com/apache/cordova-windows/pull/264#discussion_r303571911
##########
File path: cordova-js-src/splashscreen.js
##########
@@ -19,15 +19,14 @@
*
*/
-var isWp81 = navigator.appVersion.indexOf("Windows Phone 8.1") !== -1;
var isWp10 = navigator.appVersion.indexOf("Windows Phone 10") !== -1;
-var isPhoneDevice = isWp81 || isWp10;
+var isPhoneDevice = isWp10;
Review comment:
I would vote to drop `isWp*` and `isPhone*`, we just check if we are dealing with UWP, appx-web, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org