[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3513: refactor(e2e): add e2e diversity

["warren830 (via GitHub)" <gi...@apache.org>]

warren830 commented on code in PR #3513:
URL: https://github.com/apache/incubator-devlake/pull/3513#discussion_r1143289012


##########
backend/helpers/e2ehelper/data_flow_tester_test.go:
##########
@@ -208,3 +208,70 @@ func TestGetTableMetaData(t *testing.T) {
 		}
 	})
 }
+
+func TestCheckDiversity(t *testing.T) {
+	// Define test cases using a struct that contains input values and expected output.
+	testCases := []struct {
+		name            string
+		rows            *[]map[string]interface{}
+		minUniqueValues int
+		fieldNames      []string

Review Comment:
   fixed



##########
backend/helpers/e2ehelper/data_flow_tester.go:
##########
@@ -491,6 +501,10 @@ func (t *DataFlowTester) VerifyTableWithOptions(dst schema.Tabler, opts TableOpt
 	if err != nil {
 		panic(err)
 	}
+	err = checkDiversity(dbRows, 3)

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org