[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3762: [Memory Engine] MemTablet creation and compatibility handling in BE

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#discussion_r437093426



##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -1374,16 +1482,29 @@ TabletSharedPtr TabletManager::_get_tablet_unlocked(TTabletId tablet_id, SchemaH
 
     VLOG(3) << "fail to get tablet. tablet_id=" << tablet_id << ", schema_hash=" << schema_hash;
     // Return nullptr tablet if fail
-    TabletSharedPtr tablet;
+    BaseTabletSharedPtr tablet;

Review comment:
       You can return nullptr directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org