[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6949: SegmentDirectoryLoader interface and local impl

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-pinot/pull/6949#discussion_r636440713



##########
File path: pinot-broker/src/test/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerTest.java
##########
@@ -34,7 +34,7 @@
 import org.apache.helix.model.IdealState;
 import org.apache.helix.store.zk.ZkHelixPropertyStore;
 import org.apache.pinot.common.metadata.ZKMetadataProvider;
-import org.apache.pinot.common.metadata.segment.ColumnPartitionMetadata;
+import org.apache.pinot.segment.spi.partition.ColumnPartitionMetadata;

Review comment:
       why create a package for partition? may be put this in column package or metadata package




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org