You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/06/12 13:58:05 UTC
[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request
#475: nimble/ll: Fix PHY transition on LL_PHY_UPDATE_IND
rymanluk commented on a change in pull request #475: nimble/ll: Fix PHY transition on LL_PHY_UPDATE_IND
URL: https://github.com/apache/mynewt-nimble/pull/475#discussion_r292928460
##########
File path: nimble/controller/src/ble_ll_conn.c
##########
@@ -3697,7 +3697,13 @@ ble_ll_conn_rx_isr_end(uint8_t *rxbuf, struct ble_mbuf_hdr *rxhdr)
#if (BLE_LL_BT5_PHY_SUPPORTED == 1)
if (is_ctrl && (connsm->conn_role == BLE_LL_CONN_ROLE_SLAVE)
&& (opcode == BLE_LL_CTRL_PHY_UPDATE_IND)) {
- connsm->phy_tx_transition = rxbuf[3];
+ if (rxbuf[3] & BLE_PHY_MASK_1M) {
Review comment:
We might move ble_ll_ctrl_phy_from_phy_mask() to ble_ll_utils
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services