You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/05/05 01:28:30 UTC
[jira] Commented: (HADOOP-5596) Make ObjectWritable support EnumSet
[ https://issues.apache.org/jira/browse/HADOOP-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705823#action_12705823 ]
Hadoop QA commented on HADOOP-5596:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406845/Hadoop-5596-2009-04-30-3.patch
against trunk revision 771231.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/287/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/287/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/287/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/287/console
This message is automatically generated.
> Make ObjectWritable support EnumSet
> -----------------------------------
>
> Key: HADOOP-5596
> URL: https://issues.apache.org/jira/browse/HADOOP-5596
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: Hadoop-5596-2009-03-31.patch, Hadoop-5596-2009-04-03.patch, Hadoop-5596-2009-04-15-2.patch, Hadoop-5596-2009-04-15.patch, Hadoop-5596-2009-04-24.patch, Hadoop-5596-2009-04-30-1.patch, Hadoop-5596-2009-04-30-3.patch, Hadoop-5596-2009-04-30.patch
>
>
> This is a demand for Hadoop-5438.
> Also another small improvement is that i saw that in the beginning of readObject, it tries to get the class from PRIMITIVE_NAMES and then conf. Maybe it is better to add a direct load after them if the delaredClass is still null. Like this:
> {code}
> String className = UTF8.readString(in);
> Class<?> declaredClass = PRIMITIVE_NAMES.get(className);
> if (declaredClass == null) {
> try {
> declaredClass = conf.getClassByName(className);
> } catch (Exception e) {
> }
> }
>
> if(declaredClass == null) {
> try {
> declaredClass = Class.forName(className);
> } catch (ClassNotFoundException e) {
> throw new RuntimeException("readObject can't find class " + className, e);
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.