You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/19 11:56:58 UTC
[jira] [Created] (BOOKKEEPER-469) Remove System.out.println from
TestLedgerManager
Ivan Kelly created BOOKKEEPER-469:
-------------------------------------
Summary: Remove System.out.println from TestLedgerManager
Key: BOOKKEEPER-469
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-469
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
TestLedgerManager has a System.out.println in it. Tests should only ever go through slf4j.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-469) Remove System.out.println from
TestLedgerManager
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-469:
----------------------------------
Attachment: 0004-Remove-System.out.println-from-tests.patch
> Remove System.out.println from TestLedgerManager
> ------------------------------------------------
>
> Key: BOOKKEEPER-469
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-469
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0004-Remove-System.out.println-from-tests.patch
>
>
> TestLedgerManager has a System.out.println in it. Tests should only ever go through slf4j.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-469) Remove System.out.println from
TestLedgerManager
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504552#comment-13504552 ]
Flavio Junqueira commented on BOOKKEEPER-469:
---------------------------------------------
This patch is trivial. The only comment I have is that in my understanding of the behavior of assertTrue, we won't be logging the exception if it is not what we expected. It might be a good idea to log it in the case the assertion fails. Otherwise it is great to remove the System.out.println statement.
> Remove System.out.println from TestLedgerManager
> ------------------------------------------------
>
> Key: BOOKKEEPER-469
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-469
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0004-Remove-System.out.println-from-tests.patch
>
>
> TestLedgerManager has a System.out.println in it. Tests should only ever go through slf4j.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-469) Remove System.out.println from
TestLedgerManager
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504556#comment-13504556 ]
Hadoop QA commented on BOOKKEEPER-469:
--------------------------------------
Testing JIRA BOOKKEEPER-469
WARNING: Running test-patch on a dirty local svn workspace
> Remove System.out.println from TestLedgerManager
> ------------------------------------------------
>
> Key: BOOKKEEPER-469
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-469
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0004-Remove-System.out.println-from-tests.patch
>
>
> TestLedgerManager has a System.out.println in it. Tests should only ever go through slf4j.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira