You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/26 02:56:43 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

wu-sheng opened a new pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570

If you are familiar with the latest OAP core, you will know, we register id for the endpoint. But this design has the following issues
1. The register has low performance as it can't be run in parral even we have clustering OAP. Even worse, in the cluster mode, the register is slower
2. The ID is designed as an integer, it could be run out in some time. We don't have good idea to restore or extend it.
3. Endpoint including the parameter(such as, inside the URI) is always an issue, and could only be improved in the agent plugin, but never could be fixed.

The new changes are
1. Use `EndpointTraffic` to replace `EndpointInventory`. EndpointTraffic is a manual metrics, not a register inventory.
2. ID register would not happen, and service_id + base64(endpoint name) will be used as the entity id.
3. EndpointTraffic also keeps the time series feature like all other metrics, so it could be removed by TTL.
4. EndpointRelation follows the changes of EndpointInevntory removal. It keeps the source-service_id + base64(source endpoint name) and dest-service_id + base64(dest endpoint name).

- The Endpoint_Traffic looks like this
![image](https://user-images.githubusercontent.com/5441976/77605518-17779080-6f50-11ea-88df-de2e6e98e357.png)

- The Endpoint* metrics, such as endpoint_sla. It is wider than before, because of entity_id format changed.
![image](https://user-images.githubusercontent.com/5441976/77605598-50176a00-6f50-11ea-9194-348487b654ba.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `1.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.14%   +0.14%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28890     -181     
     Branches     3990     3940      -50     
   ==========================================
   - Hits         7556     7552       -4     
   + Misses      20822    20645     -177     
     Partials      693      693              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...7945c98](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

wu-sheng merged pull request #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/509b20e7cee9e5969a7dadd86fdedc17a2f263a2&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `1.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.11%   +0.11%     
   ==========================================
     Files        1250     1247       -3     
     Lines       29071    28922     -149     
     Branches     3990     3941      -49     
   ==========================================
   - Hits         7557     7552       -5     
   + Misses      20822    20677     -145     
   - Partials      692      693       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [509b20e...906cd37](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.15%`.
   > The diff coverage is `1.70%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.14%   +0.15%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28888     -183     
     Branches     3990     3939      -51     
   ==========================================
   - Hits         7556     7552       -4     
   + Misses      20822    20643     -179     
     Partials      693      693              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...173949e](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1bc408282176363e6d98b3969be12810dfcded72&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `5.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   26.17%   26.25%   +0.08%     
   ==========================================
     Files        1257     1253       -4     
     Lines       29265    28984     -281     
     Branches     4027     3950      -77     
   ==========================================
   - Hits         7659     7610      -49     
   + Misses      20899    20685     -214     
   + Partials      707      689      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commands/executor/ServiceResetCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvU2VydmljZVJlc2V0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `12.50% <0.00%> (+1.38%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `72.41% <ø> (+1.44%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `60.71% <ø> (+5.87%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `55.55% <ø> (+1.98%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `69.56% <ø> (+14.30%)` | :arrow_up: |
   | [...g/apm/agent/core/dictionary/DictionaryManager.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `100.00% <ø> (ø)` | |
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [1bc4082...e93f3bd](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06d30f15564f2326f7435fa1701371e1c769002d&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4570   +/-   ##
   =======================================
     Coverage   26.40%   26.40%           
   =======================================
     Files        1253     1253           
     Lines       28989    28989           
     Branches     3952     3952           
   =======================================
     Hits         7655     7655           
     Misses      20630    20630           
     Partials      704      704           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [06d30f1...06d30f1](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/509b20e7cee9e5969a7dadd86fdedc17a2f263a2&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `1.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.11%   +0.11%     
   ==========================================
     Files        1250     1247       -3     
     Lines       29071    28920     -151     
     Branches     3990     3941      -49     
   ==========================================
   - Hits         7557     7552       -5     
   + Misses      20822    20675     -147     
   - Partials      692      693       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [79 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [509b20e...fac4615](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9c62e4f52dbfa42ac3fbcc94ce0518dc89cbc165&el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `5.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   26.14%   26.22%   +0.07%     
   ==========================================
     Files        1257     1253       -4     
     Lines       29265    28991     -274     
     Branches     4027     3951      -76     
   ==========================================
   - Hits         7651     7602      -49     
   + Misses      20906    20699     -207     
   + Partials      708      690      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commands/executor/ServiceResetCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvU2VydmljZVJlc2V0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `12.50% <0.00%> (+1.38%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `72.41% <ø> (+1.44%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `60.71% <ø> (+5.87%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `55.55% <ø> (+1.98%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `69.56% <ø> (+14.30%)` | :arrow_up: |
   | [...g/apm/agent/core/dictionary/DictionaryManager.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `100.00% <ø> (ø)` | |
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [06d30f1...06d30f1](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#discussion_r398330528
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/MySQLTableInstaller.java
 ##########
 @@ -111,7 +111,7 @@ protected void createIndexes(JDBCHikariCPClient client, Model model) throws Stor
             case SERVICE_INVENTORY:
             case SERVICE_INSTANCE_INVENTORY:
             case NETWORK_ADDRESS:
-            case ENDPOINT_INVENTORY:
+            case ENDPOINT_TRAFFIC:
                 createInventoryIndexes(client, model);
 
 Review comment:
   Removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `1.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.13%   +0.14%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28892     -179     
     Branches     3990     3942      -48     
   ==========================================
   - Hits         7556     7552       -4     
   + Misses      20822    20647     -175     
     Partials      693      693              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...7945c98](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `1.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.13%   +0.14%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28890     -181     
     Branches     3990     3939      -51     
   ==========================================
   - Hits         7556     7550       -6     
   + Misses      20822    20645     -177     
   - Partials      693      695       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [78 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...7af8f1a](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cb5ff88d95155218226f9984289bed029d1a783b&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `1.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   26.01%   26.10%   +0.08%     
   ==========================================
     Files        1250     1247       -3     
     Lines       29071    28925     -146     
     Branches     3990     3942      -48     
   ==========================================
   - Hits         7564     7552      -12     
   + Misses      20815    20680     -135     
   - Partials      692      693       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [cb5ff88...aee87e3](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7abb1326f0c1ea5bbc919308958af27cf962335f&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4570   +/-   ##
   =======================================
     Coverage   26.22%   26.22%           
   =======================================
     Files        1253     1253           
     Lines       28991    28991           
     Branches     3951     3951           
   =======================================
     Hits         7602     7602           
     Misses      20699    20699           
     Partials      690      690           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [7abb132...7abb132](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1bc408282176363e6d98b3969be12810dfcded72&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `5.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   26.17%   26.22%   +0.05%     
   ==========================================
     Files        1257     1253       -4     
     Lines       29265    28984     -281     
     Branches     4027     3950      -77     
   ==========================================
   - Hits         7659     7602      -57     
   + Misses      20899    20692     -207     
   + Partials      707      690      -17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commands/executor/ServiceResetCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvU2VydmljZVJlc2V0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `12.50% <0.00%> (+1.38%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `72.41% <ø> (+1.44%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `60.71% <ø> (+5.87%)` | :arrow_up: |
   | [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `55.55% <ø> (+1.98%)` | :arrow_up: |
   | [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0.00% <ø> (ø)` | |
   | [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `69.56% <ø> (+14.30%)` | :arrow_up: |
   | [...g/apm/agent/core/dictionary/DictionaryManager.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `100.00% <ø> (ø)` | |
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [1bc4082...09f0a74](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on a change in pull request #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#discussion_r398319719
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/MySQLTableInstaller.java
 ##########
 @@ -111,7 +111,7 @@ protected void createIndexes(JDBCHikariCPClient client, Model model) throws Stor
             case SERVICE_INVENTORY:
             case SERVICE_INSTANCE_INVENTORY:
             case NETWORK_ADDRESS:
-            case ENDPOINT_INVENTORY:
+            case ENDPOINT_TRAFFIC:
                 createInventoryIndexes(client, model);
 
 Review comment:
   `EndpointTraffic` is not `RegisterSource` type, but creating `InventoryIndexes` needs a `sequence` column, which is defined in `RegisterSource`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.15%`.
   > The diff coverage is `1.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.14%   +0.15%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28888     -183     
     Branches     3990     3939      -51     
   ==========================================
   - Hits         7556     7552       -4     
   + Misses      20822    20643     -179     
     Partials      693      693              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...ecbdefd](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cb5ff88d95155218226f9984289bed029d1a783b&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `1.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   26.01%   26.10%   +0.08%     
   ==========================================
     Files        1250     1247       -3     
     Lines       29071    28925     -146     
     Branches     3990     3942      -48     
   ==========================================
   - Hits         7564     7552      -12     
   + Misses      20815    20680     -135     
   - Partials      692      693       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [cb5ff88...aee87e3](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
   > Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.17%`.
   > The diff coverage is `1.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4570/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4570      +/-   ##
   ==========================================
   + Coverage   25.99%   26.16%   +0.17%     
   ==========================================
     Files        1250     1246       -4     
     Lines       29071    28888     -183     
     Branches     3990     3939      -51     
   ==========================================
   + Hits         7556     7559       +3     
   + Misses      20822    20636     -186     
     Partials      693      693              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
   | [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [78 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...ecbdefd](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services