You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/05/02 04:49:29 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3857: [ISSUE #3832]Do some code optimization.[storage ProducerImpl]
harshithasudhakar opened a new pull request, #3857:
URL: https://github.com/apache/eventmesh/pull/3857
Fixes #3832
### Modifications
Added `final` to line 47.
Added `Objects.requireNonNull()` to avoid NPE at line 110
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3857: [ISSUE #3832]Do some code optimization.[storage ProducerImpl]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3857:
URL: https://github.com/apache/eventmesh/pull/3857#issuecomment-1535833436
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3857](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f423f9) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **increase** coverage by `0.01%`.
> The diff coverage is `3.84%`.
> :exclamation: Current head 8f423f9 differs from pull request most recent head b811bfa. Consider uploading reports for the commit b811bfa to get more accurate results
```diff
@@ Coverage Diff @@
## master #3857 +/- ##
============================================
+ Coverage 13.77% 13.78% +0.01%
Complexity 1290 1290
============================================
Files 571 571
Lines 29129 29079 -50
Branches 2837 2829 -8
============================================
- Hits 4012 4009 -3
+ Misses 24745 24698 -47
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...olver/http/SendMessageBatchV2ProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlQmF0Y2hWMlByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...olver/http/SendMessageRequestProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlUmVxdWVzdFByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sh/runtime/admin/handler/ConfigurationHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQ29uZmlndXJhdGlvbkhhbmRsZXIuamF2YQ==) | `11.32% <0.00%> (ø)` | |
| [.../eventmesh/runtime/admin/handler/EventHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRXZlbnRIYW5kbGVyLmphdmE=) | `6.25% <0.00%> (ø)` | |
| [...tmesh/runtime/admin/handler/GrpcClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvR3JwY0NsaWVudEhhbmRsZXIuamF2YQ==) | `4.59% <0.00%> (ø)` | |
| [...tmesh/runtime/admin/handler/HTTPClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvSFRUUENsaWVudEhhbmRsZXIuamF2YQ==) | `5.00% <0.00%> (ø)` | |
| [...entmesh/runtime/admin/handler/RegistryHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVnaXN0cnlIYW5kbGVyLmphdmE=) | `7.40% <0.00%> (ø)` | |
| [.../eventmesh/runtime/admin/handler/TopicHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVG9waWNIYW5kbGVyLmphdmE=) | `7.14% <0.00%> (+0.89%)` | :arrow_up: |
| [...ocol/tcp/client/session/push/ClientAckContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvQ2xpZW50QWNrQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mesh/storage/kafka/consumer/KafkaConsumerImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9rYWZrYS9jb25zdW1lci9LYWZrYUNvbnN1bWVySW1wbC5qYXZh) | `9.09% <ø> (ø)` | |
| ... and [10 more](https://app.codecov.io/gh/apache/eventmesh/pull/3857?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3857/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3857: [ISSUE #3832]Do some code optimization.[storage ProducerImpl]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3857:
URL: https://github.com/apache/eventmesh/pull/3857#discussion_r1184485363
##########
eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/java/org/apache/eventmesh/storage/kafka/producer/ProducerImpl.java:
##########
@@ -107,7 +107,7 @@ public void sendOneway(CloudEvent message) {
public void sendAsync(CloudEvent cloudEvent, SendCallback sendCallback) {
try {
- this.producer.send(new ProducerRecord<>(cloudEvent.getSubject(), cloudEvent), (metadata, exception) -> {
+ this.producer.send(new ProducerRecord<>(Objects.requireNonNull(cloudEvent.getSubject(), cloudEvent), (metadata, exception) -> {
Review Comment:
![image](https://user-images.githubusercontent.com/91315508/236098658-b2212e3f-f715-4e54-8b53-431090f1cf33.png)
Need to add a `)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3857: [ISSUE #3832]Do some code optimization.[storage ProducerImpl]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3857:
URL: https://github.com/apache/eventmesh/pull/3857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org