[GitHub] [cordova-android] breautek opened a new pull request #815: Bugfix: Fixes clean command

[GitBox <gi...@apache.org>]

breautek opened a new pull request #815: Bugfix: Fixes clean command
URL: https://github.com/apache/cordova-android/pull/815
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Fixes the `cordova clean` command, a reprecussion bug from https://github.com/apache/cordova-android/pull/764
   Fixes https://github.com/apache/cordova-android/issues/813
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Due to some code style refactoring, it became possible for the `buildCmd` to stay `undefined`, when it used to default to the incoming parameter `cmd` value. This fixes `ProjectBuilder.getArgs` to fallback to `cmd` value if it doesn't enter in any `if` conditions.
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   `npm test` & manually testing.
   
   Note that at the time of working on this issue, master currently did not pass `npm test`. So I have "all new and existing tests pass" checkbox unchecked and checking that box is blocked by https://github.com/apache/cordova-android/issues/814
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org