You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/02/11 19:29:03 UTC

[jira] Created: (HBASE-1195) If HBase directory exisits but version file is inexistent, still proceed with bootstrapping

If HBase directory exisits but version file is inexistent, still proceed with bootstrapping
-------------------------------------------------------------------------------------------

                 Key: HBASE-1195
                 URL: https://issues.apache.org/jira/browse/HBASE-1195
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: master
            Reporter: Jean-Daniel Cryans
            Assignee: Jean-Daniel Cryans
            Priority: Minor
             Fix For: 0.20.0


On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:

{quote}
Yes. In fact, its probably safe-to-do now we've left far behind the
pre-history versions of hbase where there was no hbase.version file in the
hbase.rootdir.  If absent, lets proceed and just write it rather than treat
it as a non-migrated instance
{quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Evgeny Ryabitskiy reassigned HBASE-1195:
----------------------------------------

    Assignee: Evgeny Ryabitskiy  (was: Jean-Daniel Cryans)

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-1195:
---------------------------------

    Comment: was deleted

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672737#action_12672737 ] 

Jim Kellerman commented on HBASE-1195:
--------------------------------------

Found and fixed 156,342 bad timestamps.

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Evgeny Ryabitskiy updated HBASE-1195:
-------------------------------------

    Attachment: HBASE-1195.patch

Fixed FSUtils.checkVersion(fs, rootdir, true);

Changes:
 * If root dir empty (no version file and no ROOT Region dir), just create new version file
 * But if there exists ROOT Region dir and no Version file, should be required migration.

Not changed:
 * if version not matched ask for

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1195.patch
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-1195:
--------------------------------------

    Summary: If HBase directory exists but version file is inexistent, still proceed with bootstrapping  (was: If HBase directory exisits but version file is inexistent, still proceed with bootstrapping)

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701877#action_12701877 ] 

Evgeny Ryabitskiy edited comment on HBASE-1195 at 4/23/09 3:11 AM:
-------------------------------------------------------------------

Fixed FSUtils.checkVersion(fs, rootdir, true);

Changes:
 * If root dir empty (no version file and no ROOT Region dir), just create new version file
 * But if there exists ROOT Region dir and no Version file, should be required migration.

Not changed:
 * if version not matched ask for migration

      was (Author: apparition):
    Fixed FSUtils.checkVersion(fs, rootdir, true);

Changes:
 * If root dir empty (no version file and no ROOT Region dir), just create new version file
 * But if there exists ROOT Region dir and no Version file, should be required migration.

Not changed:
 * if version not matched ask for
  
> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1195.patch
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672710#action_12672710 ] 

Jim Kellerman commented on HBASE-1195:
--------------------------------------

This is probably safe to do now. 

In the (very early) days, there was no version file, so that signaled a need to upgrade to the first release that had a version file.

Since we've had them ever since, shouldn't be a problem unless root or meta regions already exist.

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1195) If HBase directory exists but version file is inexistent, still proceed with bootstrapping

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1195.
--------------------------

    Resolution: Fixed

Committed (after testing).  Thanks for the patch Evgeny.

> If HBase directory exists but version file is inexistent, still proceed with bootstrapping
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1195
>                 URL: https://issues.apache.org/jira/browse/HBASE-1195
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1195.patch
>
>
> On the dev list I suggested we change the way we manage the empty HBase directory case. Stack answered:
> {quote}
> Yes. In fact, its probably safe-to-do now we've left far behind the
> pre-history versions of hbase where there was no hbase.version file in the
> hbase.rootdir.  If absent, lets proceed and just write it rather than treat
> it as a non-migrated instance
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.