[jira] [Comment Edited] (CALCITE-883) RESPECT NULLS, IGNORE NULLS option for LEAD, LAG window functions

["Chunwei Lei (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797756#comment-16797756 ] 

Chunwei Lei edited comment on CALCITE-883 at 3/21/19 2:52 AM:
--------------------------------------------------------------

I am sorry that I don't mention the conflict in the PR. It is because I am convinced to your point that when you are calling a function and asking it to ignore nulls, you are not creating a new operator, but are creating a new call to an existing operator.

I also thought about  make RESPECT | IGNORE NULLS clause an individual operator like FILTER / WITHIN GROUP. But I gave up after finding some problems such as breaking the assumption that the operator in the first operand of SqlOverOperator should be aggregate function.

 As far as I can see,  the latest PR is more reasonable though it changes lots of files. Any other opinion will be welcomed.



was (Author: chunwei lei):
I am sorry that I don't mention the conflict in the PR. It is because I am convinced to your point that when you are calling a function and asking it to ignore nulls, you are not creating a new operator, but are creating a new call to an existing operator.

I also thought about  make { RESPECT | IGNORE } NULLS clause an individual operator like FILTER / WITHIN GROUP. But I gave up after finding some problems such as breaking the assumption that the operator in the first operand of SqlOverOperator should be aggregate function.

 As far as I can see,  the latest PR is more reasonable though it changes lots of files. Any other opinion will be welcomed.


> RESPECT NULLS, IGNORE NULLS option for LEAD, LAG window functions
> -----------------------------------------------------------------
>
>                 Key: CALCITE-883
>                 URL: https://issues.apache.org/jira/browse/CALCITE-883
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Sean Hsuan-Yi Chu
>            Assignee: Sean Hsuan-Yi Chu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This issue was brought up in Drill community: (https://issues.apache.org/jira/browse/DRILL-3597)
> For convenience, I copied and pasted the reporter Khurram Faraaz's description here:
> "The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead, lag, first_value, and last_value window functions."
> In Calcite, we should have been able to recognized this option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)