[GitHub] [airflow] uranusjr commented on a diff in pull request #27689: Add option to add arguments to PSRP hook and operator

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #27689:
URL: https://github.com/apache/airflow/pull/27689#discussion_r1060269541


##########
airflow/providers/microsoft/psrp/operators/psrp.py:
##########
@@ -56,8 +56,11 @@ class PsrpOperator(BaseOperator):
     :param cmdlet:
         cmdlet to execute on remote host (templated). Also used as the default
         value for `task_id`.
+    :param arguments:
+        When using the `cmdlet` or `powershell` option, use `arguments` to
+        provide arguments (templated).
     :param parameters:
-        When using the `cmdlet` or `powershell` arguments, use this parameter to
+        When using the `cmdlet` or `powershell` option, use `parameters` to
         provide parameters (templated). Note that a parameter with a value of `None`
         becomes an *argument* (i.e., switch).

Review Comment:
   I’m assuming users fluent with Powershell would understand the difference between these? I wonder if we should add a link to some documentation about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org