You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/17 09:15:18 UTC

[GitHub] [hudi] YannByron opened a new pull request #4619: [HUDI-3213] compaction do not change commit metadata

YannByron opened a new pull request #4619:
URL: https://github.com/apache/hudi/pull/4619


   This pr will remote the config on whether preserve commit metadata when compaction and do not change commit metadata any more.
   
   https://github.com/apache/hudi/pull/4428#issuecomment-1011700454


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1029584974


   @nsivabalan If the conclusion is to keep this `hoodie.compaction.preserve.commit.metadata` parameter and just set the default value to `true`, I will change pr in this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction do not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014305417


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014507083


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014422498


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037173667


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037171633






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1015007698


   > @YannByron : Can we just mark the default value for config to true. Just incase anyone has requirement or if we had any bugs we have a way to revert it.
   
   This would make the definition of `compaction` unclear. If anyone has this requirement, he should expand the scope of `incremental query`.
   But, in terms of compatibility, maybe yes. And also, indicates the config is  about to be deprecated.
   There is a trade-off between compatibility and correcting misbehavior. IMO, i prefer to remove this config.
   
   @nsivabalan @vinothchandar @xushiyan need some thought to decide this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1031938602


   @xushiyan : Can we jam on this sometime. lets see how we can make progress here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014507083


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014507083






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037215592


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1035865062


   @YannByron : we also need to make a minor fix. When preserve commit metadata is enabled, we need to retain every meta field except filename. File name has to be overriden. guess I missed it when I added preserve commit metadata for compaction. Fix should go in [here](https://github.com/apache/hudi/blob/ba4e732ba75e12a02d07c09f2662678bdcafbdc2/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java#L297). 
   
   You can check out the [fix](https://github.com/apache/hudi/blob/ba4e732ba75e12a02d07c09f2662678bdcafbdc2/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java#L144) we did for clustering for clustering preserve commit metadata. 
   
   If you are occupied, let me know. I can push changes or put up a new patch. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037215592


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037231412


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1016021165


   > synced up with Vinoth on this. This is a large enough change and we want to be cautious on how to go about this. May not pick it up for 0.10.1.
   
   yep, pick it into 0.11.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037216569


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014906761


   @YannByron : Can we just mark the default value for config to true. Just incase anyone has requirement or if we had any bugs we have a way to revert it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1015883363


   synced up with Vinoth on this. This is a large enough change and we want to be cautious on how to go about this. May not pick it up for 0.10.1. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron edited a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron edited a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1029584974


   @nsivabalan If the conclusion is to keep this `hoodie.compaction.preserve.commit.metadata` parameter and just set the default value to `true`, I will change pr in this way. wait for your confirmation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037171633


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014422498


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014371841


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1029520504


   @YannByron : any updates on this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037173667


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037171633


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037216569


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan closed pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #4619:
URL: https://github.com/apache/hudi/pull/4619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1032728655


   @YannByron : yes. lets go w/ what you have suggested. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037213608


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037213044


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037213044






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1051109074


   closing this in favor of https://github.com/apache/hudi/pull/4811
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction do not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014302447


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014371841


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014424894


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4619: [HUDI-3213] compaction do not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014302447


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014305417


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014424894


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * faa427973613cacc0239e5ba4bb65923823992cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293) 
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan edited a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
nsivabalan edited a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1014906761


   @YannByron : Can we just mark the default value for config to true. Just incase anyone has requirement or if we had any bugs we have a way to revert it. 
   We are changing a behavior that has been working one way for the past 3 years or so. Just being cautious. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037238663


   @nsivabalan there are something i am not familiar to, so i need to your help to solve the failure of CI indeed. push changes or open a new patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] YannByron commented on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1036981010


   @nsivabalan i'll try to fix this asap. if have any problems, i'll let you know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4619: [HUDI-3213] compaction should not change commit metadata

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4619:
URL: https://github.com/apache/hudi/pull/4619#issuecomment-1037213608


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5293",
       "triggerID" : "faa427973613cacc0239e5ba4bb65923823992cb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296",
       "triggerID" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947",
       "triggerID" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "250b33f8afa8b5c5512e70e4dd298d3f3bd85eba",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b0e134ea32ef9b1ecd547c0cfea973b7229386c6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949",
       "triggerID" : "1037213044",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 250b33f8afa8b5c5512e70e4dd298d3f3bd85eba Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5296) 
   * b0e134ea32ef9b1ecd547c0cfea973b7229386c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5947) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5949) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org