[GitHub] rmn36 commented on a change in pull request #4332: [AIRFLOW-3522] Add support for sending Slack attachments

[GitBox <gi...@apache.org>]

rmn36 commented on a change in pull request #4332: [AIRFLOW-3522] Add support for sending Slack attachments
URL: https://github.com/apache/incubator-airflow/pull/4332#discussion_r242217009
 
 

 ##########
 File path: airflow/contrib/hooks/slack_webhook_hook.py
 ##########
 @@ -38,6 +38,8 @@ class SlackWebhookHook(HttpHook):
     :type webhook_token: str
     :param message: The message you want to send on Slack
     :type message: str
+    :param attachments: The attachments you want to send on Slack
+    :type attachments: list
 
 Review comment:
   Can you be more specific about what this is a list of? List of strings, list of dict, list of? And what those objects represent? I'm assuming it's a list of strings that are filenames you want to attach but that should be explicitly stated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services