You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by SergeVil <gi...@git.apache.org> on 2016/06/07 17:22:29 UTC
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
GitHub user SergeVil opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/333
if there is no edge label in the GraphML file, then use Edge.DEFAULT
As per suggestion in https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/gremlin-users/56CI2PTWueg
I'm commiting the change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SergeVil/incubator-tinkerpop tp31-graphml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #333
----
commit 73427e2e4e99d5332cc82e6e1f67295a91df05b6
Author: Serge Vilvovsky <se...@ll.mit.edu>
Date: 2016-06-07T17:17:55Z
if there is no edge label in the GraphML file, then use Edge.DEFAULT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Note that your PR is failing for Travis:
https://travis-ci.org/apache/incubator-tinkerpop/builds/135940598#L6936
Any idea what's wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Travis still seems to be having a problem. You can see the "red X" on the Travis job in github - just click the "Details" link next to it to see the problem being reported.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66296879
--- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java ---
@@ -721,14 +732,18 @@ public static void assertCrewGraph(final Graph g1, final boolean lossyForId) {
}
public static void assertClassicGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, false);
+ assertToyGraph(g1, assertDouble, lossyForId, false, true);
+ }
+
+ public static void assertNoEdgeGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
+ assertToyGraph(g1, assertDouble, lossyForId, false, false);
}
public static void assertModernGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, true);
+ assertToyGraph(g1, assertDouble, lossyForId, true, true);
}
- private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel) {
+ private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel, final boolean assertEdgeLabel) {
--- End diff --
right - but you've modified a core piece of code with `assertToyGraph` by adding logic that really doesn't generally apply to anything else that would use that logic besides `shouldReadGraphMLWithNoEdgeLabels` which is testing a version of "toy graph" that is not even a legitimate representation of our toy graph because it has no labels.
I would prefer that you simplify your `shouldReadGraphMLWithNoEdgeLabels` test to read some graphml with just two vertices and an edge with no label and then assert that entirely within that test method. Then your test and changes are isolated specifically to just `shouldReadGraphMLWithNoEdgeLabels` and that core logic remains unchanged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66295517
--- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java ---
@@ -721,14 +732,18 @@ public static void assertCrewGraph(final Graph g1, final boolean lossyForId) {
}
public static void assertClassicGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, false);
+ assertToyGraph(g1, assertDouble, lossyForId, false, true);
+ }
+
+ public static void assertNoEdgeGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
+ assertToyGraph(g1, assertDouble, lossyForId, false, false);
}
public static void assertModernGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, true);
+ assertToyGraph(g1, assertDouble, lossyForId, true, true);
}
- private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel) {
+ private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel, final boolean assertEdgeLabel) {
--- End diff --
That is basically what I do - I produce tinkerpop-no-edge-labels.xml. The assert function needs to know if it should check the particular labels values or just to assume that they have default values and check them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66292909
--- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java ---
@@ -721,14 +732,18 @@ public static void assertCrewGraph(final Graph g1, final boolean lossyForId) {
}
public static void assertClassicGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, false);
+ assertToyGraph(g1, assertDouble, lossyForId, false, true);
+ }
+
+ public static void assertNoEdgeGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
+ assertToyGraph(g1, assertDouble, lossyForId, false, false);
}
public static void assertModernGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId) {
- assertToyGraph(g1, assertDouble, lossyForId, true);
+ assertToyGraph(g1, assertDouble, lossyForId, true, true);
}
- private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel) {
+ private static void assertToyGraph(final Graph g1, final boolean assertDouble, final boolean lossyForId, final boolean assertSpecificLabel, final boolean assertEdgeLabel) {
--- End diff --
I'm sorry, but I don't think I like that you altered this assertion method. The toy graph has important meaning in TinkerPop and there really is no valid version of it that does not have edge labels. It essentially ceases to be the "toy graph" without those labels. Your test graph for "GraphML with no edges" really doesn't need to validate the entire toy graph to be effective in what it is testing. It just needs to validate that a default edge label is used when the label isn't supplied.
I would much prefer to see you produce a new simple "tinkerpop-no-edge-labels.xml" (you could even just take the existing toy graph and strip out all but two vertices and an edge) and just assert that in your test method itself. I think that would be preferable to altering `assertToyGraph()` in a way that no other test would really have benefit in using.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Sorry, I did not push it correct, I believe. Thank you for your help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66120086
--- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReader.java ---
@@ -187,7 +187,9 @@ public void readGraph(final InputStream graphInputStream, final Graph graphToWri
} else if (elementName.equals(GraphMLTokens.EDGE)) {
final Object[] propsAsArray = edgeProps.entrySet().stream().flatMap(e -> Stream.of(e.getKey(), e.getValue())).toArray();
final Object[] propsReady = edgeFeatures.willAllowId(edgeId) ? ElementHelper.upsert(propsAsArray, T.id, edgeId) : propsAsArray;
- edgeOutVertex.addEdge(edgeLabel, edgeInVertex, propsReady);
+
+ final String currentEdgeLabel = Optional.ofNullable(edgeLabel).orElse(Edge.DEFAULT_LABEL);
--- End diff --
Why waste the object creation using `Optional`? Instead, in one line, do:
```
edgeOutVertex.addEdge(null == edgeLabel ? Edge.DEFAULT_LABEL : edgeLabel, edgeInVertex, propsReady);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
> Why waste the object creation using Optional? Instead, in one line, do:
> edgeOutVertex.addEdge(null == edgeLabel ? Edge.DEFAULT_LABEL : edgeLabel, edgeInVertex, propsReady);
Pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
This looks much better to me - thanks. If you could just clean up the git history now a little bit as we've had a lot of back and forth to get this right. Let's squash all of your commits into one:
```text
git rebase -i tp31-graphml
```
You should get a summary of all your commits listed. The instructions explain what to do, but basically, just change all but the first "pick" entry to "squash" and all of those ones you mark with "squash" will fold into the remaining "pick". so it looks like you have just once nice commit. After you do that, you can adjust the commit message for the squash to have just one good message that describes your change. You might want to review a tutorial or two on `squash` before you pull the trigger if you aren't familiar:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
Then you push:
```text
git push your-remote tp31-graphml --force
```
Note that "your-remote" should be the name of the git remote for your repo which i assume is "origin" and further note, that you need `--force` because you are re-writing history on that branch (i.e. 7 commits becoming 1). Once you do that, i would think the PR should auto-update and travis will fire off again. Should be good from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Please add an entry to CHANGELOG to briefly summarize your change:
https://github.com/apache/incubator-tinkerpop/blob/tp31/CHANGELOG.asciidoc
Nice to see that you got the tests all passing with travis now btw. Ultimately, I may ask you to squash your commits before we finally merge this - the commit log is getting a bit untidy at this point (i can help you with specific instructions if you are unfamiliar with what i mean by that).
By the way, we've made some pretty big improvements to our "how to contribute" documentation:
http://tinkerpop.apache.org/docs/3.2.1-SNAPSHOT/dev/developer/#_contributing
Anyway, looks like your PR is coming together - thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Sorry - it's still not quite right. You've got 9 commits on this PR and there should only be 1. Not sure if my instructions were bad, but doesn't really matter. I pulled the changes from your fork to a branch in our repo and did the squash myself:
https://github.com/apache/incubator-tinkerpop/commits/graphml-default-edge-label
Please review to make sure it all looks good from your end.
Reviewers, please note that the VOTE will be on the branch I referenced above and not this PR - however the contents should ultimately be identical - the commit history will just be different.
I tested that branch locally with `mvn clean install`. Note that travis is building that branch now here:
https://travis-ci.org/apache/incubator-tinkerpop/builds/136263671
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
> I may ask you to squash your commits before we finally merge this
Let me know how I should implement it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
I see that some commits have been disappeared in my history, I believe they are merged altogether. The last commit that I see is 863872a. Getting back to my work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66293053
--- Diff: data/tinkerpop-no-edge-labels.xml ---
@@ -0,0 +1 @@
+<?xml version="1.0" ?><graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.1/graphml.xsd"><key id="labelV" for="node" attr.name="labelV" attr.type="string"></key><key id="name" for="node" attr.name="name" attr.type="string"></key><key id="lang" for="node" attr.name="lang" attr.type="string"></key><key id="age" for="node" attr.name="age" attr.type="int"></key><key id="weight" for="edge" attr.name="weight" attr.type="float"></key><graph id="G" edgedefault="directed"><node id="1"><data key="labelV">vertex</data><data key="name">marko</data><data key="age">29</data></node><node id="2"><data key="labelV">vertex</data><data key="name">vadas</data><data key="age">27</data></node><node id="3"><data key="labelV">vertex</data><data key="name">lop</data><data key="lang">java</data></node><node id="4"><data key="labelV">vertex</data><data
key="name">josh</data><data key="age">32</data></node><node id="5"><data key="labelV">vertex</data><data key="name">ripple</data><data key="lang">java</data></node><node id="6"><data key="labelV">vertex</data><data key="name">peter</data><data key="age">35</data></node><edge id="7" source="1" target="2"><data key="weight">0.5</data></edge><edge id="8" source="1" target="4"><data key="weight">1.0</data></edge><edge id="9" source="1" target="3"><data key="weight">0.4</data></edge><edge id="10" source="4" target="5"><data key="weight">1.0</data></edge><edge id="11" source="4" target="3"><data key="weight">0.4</data></edge><edge id="12" source="6" target="3"><data key="weight">0.2</data></edge></graph></graphml>
--- End diff --
I think you can remove this file. We don't need to include that in our distributions. We really only need it for unit testing purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
I copied the xml file to a new name and added the test that processes a new xml. Recompiled everything, and I see this file in three places:
(incubator-tinkerpop)$ find .. -name tinkerpop-no-edge-labels.xml
../incubator-tinkerpop/data/tinkerpop-no-edge-labels.xml
../incubator-tinkerpop/gremlin-console/target/apache-gremlin-console-3.1.3-SNAPSHOT-standalone/data/tinkerpop-no-edge-labels.xml
../incubator-tinkerpop/gremlin-server/target/apache-gremlin-server-3.1.3-SNAPSHOT-standalone/data/tinkerpop-no-edge-labels.xml
But when I run the test, it cannot find a new xml file. It seems to be some configuration issue, but I do not understand what exactly.
The exception trace is bellow:
org.xml.sax.SAXParseException: schema_reference.4: Failed to read schema document 'http://graphml.graphdrawing.org/xmlns/1.1/graphml-structure.xsd', because 1) could not find the document; 2) the document could not be read; 3) the root element of the document is not <xsd:schema>.
at java.net.PlainSocketImpl.socketConnect(Native Method)
at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at java.net.Socket.connect(Socket.java:538)
at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:432)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:527)
at sun.net.www.http.HttpClient.<init>(HttpClient.java:211)
at sun.net.www.http.HttpClient.New(HttpClient.java:308)
at sun.net.www.http.HttpClient.New(HttpClient.java:326)
at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1169)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1105)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:999)
at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:933)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1513)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:647)
at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:189)
at com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaParsingConfig.parse(SchemaParsingConfig.java:582)
at com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaParsingConfig.parse(SchemaParsingConfig.java:685)
at com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaDOMParser.parse(SchemaDOMParser.java:530)
at com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.getSchemaDocument(XSDHandler.java:2171)
at com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.resolveSchema(XSDHandler.java:2092)
at com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.constructTrees(XSDHandler.java:1096)
at com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.parseSchema(XSDHandler.java:616)
at com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaLoader.loadSchema(XMLSchemaLoader.java:613)
at com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaLoader.loadGrammar(XMLSchemaLoader.java:572)
at com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaLoader.loadGrammar(XMLSchemaLoader.java:538)
at com.sun.org.apache.xerces.internal.jaxp.validation.XMLSchemaFactory.newSchema(XMLSchemaFactory.java:255)
at javax.xml.validation.SchemaFactory.newSchema(SchemaFactory.java:638)
at javax.xml.validation.SchemaFactory.newSchema(SchemaFactory.java:670)
at org.apache.tinkerpop.gremlin.structure.io.IoTest.validateXmlAgainstGraphMLXsd(IoTest.java:971)
at org.apache.tinkerpop.gremlin.structure.io.IoTest.access$200(IoTest.java:94)
at org.apache.tinkerpop.gremlin.structure.io.IoTest$GraphMLTest.shouldProperlyEncodeWithGraphML(IoTest.java:245)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Does it seem to be correct now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...
Posted by SergeVil <gi...@git.apache.org>.
Github user SergeVil commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Will take a look
On Tue, Jun 7, 2016 at 2:18 PM, stephen mallette <no...@github.com>
wrote:
> Note that your PR is failing for Travis:
>
> https://travis-ci.org/apache/incubator-tinkerpop/builds/135940598#L6936
>
> Any idea what's wrong?
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-tinkerpop/pull/333#issuecomment-224368287>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/ABnsJ5-eP5uxKsF_q3PqDiqQ7vIz1CF6ks5qJbX4gaJpZM4IwKSt>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---