You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Alan Gates (JIRA)" <ji...@apache.org> on 2008/07/22 17:17:31 UTC
[jira] Created: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
testShellFuncSingle/Multiple fail in TestBuiltin
------------------------------------------------
Key: PIG-327
URL: https://issues.apache.org/jira/browse/PIG-327
Project: Pig
Issue Type: Bug
Affects Versions: types_branch
Reporter: Alan Gates
Fix For: types_branch
Testcase: testShellFuncSingle took 7.152 sec
FAILED
null expected:<{[(f00)]}> but was:<{[]}>
junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
Testcase: testShellFuncMultiple took 6.68 sec
Caused an ERROR
null
java.lang.NullPointerException
at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-327:
-------------------------------
Priority: Minor (was: Major)
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Priority: Minor
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich reassigned PIG-327:
----------------------------------
Assignee: Shravan Matthur Narayanamurthy
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627790#action_12627790 ]
Alan Gates commented on PIG-327:
--------------------------------
Why do we still ship ShellBagEvalFunc as a builtin UDF? It looks like it was an early version of streaming. Now that we really have streaming can we just drop it?
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Shravan Matthur Narayanamurthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shravan Matthur Narayanamurthy updated PIG-327:
-----------------------------------------------
Attachment: 327.patch
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-327:
---------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
As of patch 693303, ShellBagEvalFunc has been removed from the types branch. It's functionality has been replaced by the streaming functionality that was added several releases ago.
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Priority: Minor
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628482#action_12628482 ]
Olga Natkovich commented on PIG-327:
------------------------------------
I think it is fine to get rid of it
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-327) testShellFuncSingle/Multiple fail in
TestBuiltin
Posted by "Shravan Matthur Narayanamurthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shravan Matthur Narayanamurthy updated PIG-327:
-----------------------------------------------
Status: Patch Available (was: Open)
Had to fix src/org/apache/pig/impl/builtin/ShellBagEvalFunc.java. I thought the earlier code looked fine as it uses the os.flush() method to signal the shell cmd to compute the output. However, this did not seem to work. So added a call to the finish() method where we explictly close the stream. Also for it to work for other inputs, we also need to set the reference to os to null. This fixes it.
So this reduces the 2 errors & 1 failure in TestBuiltin to 1 error in testSumFinal
Please take a look at the patch. The only thing is we create the process for every input tuple. I feel that the earlier code should have worked but somehow the flush is not doing its function. Only an explicit close starts the process going.
> testShellFuncSingle/Multiple fail in TestBuiltin
> ------------------------------------------------
>
> Key: PIG-327
> URL: https://issues.apache.org/jira/browse/PIG-327
> Project: Pig
> Issue Type: Bug
> Affects Versions: types_branch
> Reporter: Alan Gates
> Assignee: Shravan Matthur Narayanamurthy
> Fix For: types_branch
>
> Attachments: 327.patch
>
>
> Testcase: testShellFuncSingle took 7.152 sec
> FAILED
> null expected:<{[(f00)]}> but was:<{[]}>
> junit.framework.ComparisonFailure: null expected:<{[(f00)]}> but was:<{[]}>
> at org.apache.pig.test.TestBuiltin.testShellFuncSingle(TestBuiltin.java:900)
> Testcase: testShellFuncMultiple took 6.68 sec
> Caused an ERROR
> null
> java.lang.NullPointerException
> at org.apache.pig.test.TestBuiltin.testShellFuncMultiple(TestBuiltin.java:933)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.