You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/10 02:54:18 UTC
[GitHub] [dolphinscheduler] cheneychoi opened a new pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
cheneychoi opened a new pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331
修复了全局参数优先级的问题，globalParam>varpool>localParam
#8330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] cheneychoi commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
cheneychoi commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036068009
@zhongjiajie 这个问题我是从2.0.2-release切出的分支修改的，完成后打算合回2.0.2-release，我这样做对吗。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036166243
@cheneychoi FYI, we have a discussion in https://github.com/apache/dolphinscheduler/issues/8329#issuecomment-1036163170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1066288383
So, is this PR ready to go now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036121248
<img width="989" alt="image" src="https://user-images.githubusercontent.com/15820530/153585555-cd2609eb-bde9-4972-b8ff-24f0d70df092.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] cheneychoi commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
cheneychoi commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036127915
@zhongjiajie finished
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1066290491
Hi @cheneychoi, I change to base to dev and it seem they are lots of conflict, could you please solve it locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036120270
@cheneychoi Please change describe from Chinese to English first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1066290862
BTW, you should also change our docs later, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1066242017
> @zhongjiajie I modified this problem ,checkout from 2.0.2-release and plan to merge back to 2.0.2-release after completion. Am I doing this right?
Sorry for late review. You should fix in dev branch first, and then we will cherry-pick to next 2.0.x version. I don't understand the original design of the `parameter priority`, @wangxj3 @lenboo PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng edited a comment on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
caishunfeng edited a comment on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1066242017
> @zhongjiajie I modified this problem ,checkout from 2.0.2-release and plan to merge back to 2.0.2-release after completion. Am I doing this right?
Sorry for late review. @cheneychoi You should fix in dev branch first, and then we will cherry-pick to next 2.0.x version. I don't understand the original design of the `parameter priority`, @wangxj3 @lenboo PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] cheneychoi edited a comment on pull request #8331: [Bug][Parameter Context] The problem of global parameter priority
Posted by GitBox <gi...@apache.org>.
cheneychoi edited a comment on pull request #8331:
URL: https://github.com/apache/dolphinscheduler/pull/8331#issuecomment-1036068009
@zhongjiajie I modified this problem ,checkout from 2.0.2-release and plan to merge back to 2.0.2-release after completion. Am I doing this right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org