You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2011/07/05 22:33:28 UTC

svn commit: r1143197 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Author: markt
Date: Tue Jul  5 20:33:28 2011
New Revision: 1143197

URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
Log:
Not just this test failing. Need a better solution. Revert r1143126.

Modified:
    tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java?rev=1143197&r1=1143196&r2=1143197&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java (original)
+++ tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java Tue Jul  5 20:33:28 2011
@@ -67,11 +67,7 @@ public class TestGroupChannelMemberArriv
             };
             threads[i] = t;
         }
-        for (int i=0; i<threads.length; i++ ) {
-            threads[i].start();
-            // Delay prevents binding errors on linux for BIO & APR
-            Thread.sleep(10);
-        }
+        for (int i=0; i<threads.length; i++ ) threads[i].start();
         for (int i=0; i<threads.length; i++ ) threads[i].join();
         Thread.sleep(2000);
         System.out.println("All channels started.");



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1143197 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Posted by Mark Thomas <ma...@apache.org>.
On 05/07/2011 22:04, Mark Thomas wrote:
> On 05/07/2011 21:38, Mark Thomas wrote:
>> On 05/07/2011 21:33, markt@apache.org wrote:
>>> Author: markt
>>> Date: Tue Jul  5 20:33:28 2011
>>> New Revision: 1143197
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
>>> Log:
>>> Not just this test failing. Need a better solution. Revert r1143126.
>>
>> There is something odd going on with these tests and my Linux test VM.
>> It looks like something is going wrong at the JVM level. An update to
>> 1.6.0_26 seems to have helped but hasn't fully fixed this.
>>
>> The common factor across all of the failures is that they go wrong in
>> o.a.c.tribes.transport.ReceiverBase.bind in the recursive re-try calls
>> (essentially all the retires fail even though there are ports available).
>>
>> I am going to experiment with different re-try approaches, probably
>> introducing a little delay since it looks like a timing issue.
>>
>> I've tried and failed to produce a simple test case that recreates the
>> bind failure.
> 
> OK, with a silly amount of concurrency, I can reproduce this on Windows.
> Next step, getting the test case to use ReceiverBase.

Or maybe not. Looks like I was hitting some sort of limit for open
server sockets. Odd number though - 598. Anyway, I'm experimenting with
some alternative ReceiverBase implementations. I may have something
tomorrow.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1143197 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Posted by Mark Thomas <ma...@apache.org>.
On 05/07/2011 21:38, Mark Thomas wrote:
> On 05/07/2011 21:33, markt@apache.org wrote:
>> Author: markt
>> Date: Tue Jul  5 20:33:28 2011
>> New Revision: 1143197
>>
>> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
>> Log:
>> Not just this test failing. Need a better solution. Revert r1143126.
> 
> There is something odd going on with these tests and my Linux test VM.
> It looks like something is going wrong at the JVM level. An update to
> 1.6.0_26 seems to have helped but hasn't fully fixed this.
> 
> The common factor across all of the failures is that they go wrong in
> o.a.c.tribes.transport.ReceiverBase.bind in the recursive re-try calls
> (essentially all the retires fail even though there are ports available).
> 
> I am going to experiment with different re-try approaches, probably
> introducing a little delay since it looks like a timing issue.
> 
> I've tried and failed to produce a simple test case that recreates the
> bind failure.

OK, with a silly amount of concurrency, I can reproduce this on Windows.
Next step, getting the test case to use ReceiverBase.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1143197 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelMemberArrival.java

Posted by Mark Thomas <ma...@apache.org>.
On 05/07/2011 21:33, markt@apache.org wrote:
> Author: markt
> Date: Tue Jul  5 20:33:28 2011
> New Revision: 1143197
> 
> URL: http://svn.apache.org/viewvc?rev=1143197&view=rev
> Log:
> Not just this test failing. Need a better solution. Revert r1143126.

There is something odd going on with these tests and my Linux test VM.
It looks like something is going wrong at the JVM level. An update to
1.6.0_26 seems to have helped but hasn't fully fixed this.

The common factor across all of the failures is that they go wrong in
o.a.c.tribes.transport.ReceiverBase.bind in the recursive re-try calls
(essentially all the retires fail even though there are ports available).

I am going to experiment with different re-try approaches, probably
introducing a little delay since it looks like a timing issue.

I've tried and failed to produce a simple test case that recreates the
bind failure.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org