You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/01/16 03:18:45 UTC
Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Bugs: AMBARI-9167
https://issues.apache.org/jira/browse/AMBARI-9167
Repository: ambari
Description
-------
Enable full smoke tests. Involved changes to the upgrade pack:
Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
Diff: https://reviews.apache.org/r/29956/diff/
Testing
-------
Pending
Thanks,
Nate Cole
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
> On Jan. 19, 2015, 8:55 a.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 196
> > <https://reviews.apache.org/r/29956/diff/4/?file=824381#file824381line196>
> >
> > Just a thought ... instead of these instance checks could we have a method on Grouping that gets overridden by ClusterGrouping and ServiceCheckGrouping?
Was considering that, but was trying to avoid groupings having to know too much about clusters. I'll make a JIRA for that.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68600
-----------------------------------------------------------
On Jan. 17, 2015, 8:52 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 8:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68600
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/29956/#comment112917>
Just a thought ... instead of these instance checks could we have a method on Grouping that gets overridden by ClusterGrouping and ServiceCheckGrouping?
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
<https://reviews.apache.org/r/29956/#comment112918>
Doc needed?
- Tom Beerbower
On Jan. 17, 2015, 1:52 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:52 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
> On Jan. 19, 2015, 9:53 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java, line 76
> > <https://reviews.apache.org/r/29956/diff/4/?file=824382#file824382line76>
> >
> > Doc that this method does some index kung-fu to reverse groups in a particular way. I'm also wondering if this could be simplified a little. Instead of trying to build the reverse list, could you instead just `Collections.reverse` the original, and then walked the reversed list, swapping indexes when you encounter a service group? Why special case ClusterGrouping?
I started going down the Collections.reverse, but the ClusterGrouping stuff got in the way since they must always be first/last. So it's the case where I would reverse and have to go over the items anyway to find those wonk ServiceCheck things.
> On Jan. 19, 2015, 9:53 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line 187
> > <https://reviews.apache.org/r/29956/diff/4/?file=824381#file824381line187>
> >
> > Could we do a switch here instead where the subclass returns its type? That way you could also have default behavior instead of adding another empty else to indicate that something went wrong.
Future. See comment to Tom.
> On Jan. 19, 2015, 9:53 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java, line 56
> > <https://reviews.apache.org/r/29956/diff/4/?file=824384#file824384line56>
> >
> > It's probably part of the requirements, but I dislike `true` elements that cause major behavioral changes. I suppose I'd rather see this be `false` and have the XML more verbose and explicit in stating when a `service-check` is to be run.
> >
> > But the requirements probably said they always have to run, so it was easier to make it `true`.
I was trying to strike the balance of having annoying xml vs logical defaults; also follows the pattern Tom set forth with <skippable />.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68603
-----------------------------------------------------------
On Jan. 17, 2015, 8:52 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 8:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68603
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/29956/#comment112927>
Could we do a switch here instead where the subclass returns its type? That way you could also have default behavior instead of adding another empty else to indicate that something went wrong.
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
<https://reviews.apache.org/r/29956/#comment112928>
Maybe an `else` here to log/exception that the type didn't match and there's probably a problem?
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
<https://reviews.apache.org/r/29956/#comment112923>
Doc that this method does some index kung-fu to reverse groups in a particular way. I'm also wondering if this could be simplified a little. Instead of trying to build the reverse list, could you instead just `Collections.reverse` the original, and then walked the reversed list, swapping indexes when you encounter a service group? Why special case ClusterGrouping?
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
<https://reviews.apache.org/r/29956/#comment112926>
It's probably part of the requirements, but I dislike `true` elements that cause major behavioral changes. I suppose I'd rather see this be `false` and have the XML more verbose and explicit in stating when a `service-check` is to be run.
But the requirements probably said they always have to run, so it was easier to make it `true`.
- Jonathan Hurley
On Jan. 17, 2015, 8:52 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 8:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/
-----------------------------------------------------------
(Updated Jan. 17, 2015, 8:52 a.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Changes
-------
Removed leftover xml element
Bugs: AMBARI-9167
https://issues.apache.org/jira/browse/AMBARI-9167
Repository: ambari
Description
-------
Enable full smoke tests. Involved changes to the upgrade pack:
Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
Diff: https://reviews.apache.org/r/29956/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:47.403s
[INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
[INFO] Final Memory: 31M/337M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 7:30 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Changes
-------
Fixed issue with service checks and groups. Please re-review. Thanks for your patience!
Bugs: AMBARI-9167
https://issues.apache.org/jira/browse/AMBARI-9167
Repository: ambari
Description
-------
Enable full smoke tests. Involved changes to the upgrade pack:
Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 1662baa
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 325df21
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java cf191d5
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
Diff: https://reviews.apache.org/r/29956/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:47.403s
[INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
[INFO] Final Memory: 31M/337M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
> On Jan. 15, 2015, 10:17 p.m., Alejandro Fernandez wrote:
> > Interesting, this will do service checks first for the priority, then for the remaining services.
> > If the "service_check" bool is set to false, then it uses the new logic? Otherwise, it only runs service checks for the items in that group?
Correct. I think I found a bug though, so please hold off on further review. Tom and Jonathan take note. Please hold off on review for now.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68405
-----------------------------------------------------------
On Jan. 15, 2015, 9:52 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 9:52 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/#review68405
-----------------------------------------------------------
Interesting, this will do service checks first for the priority, then for the remaining services.
If the "service_check" bool is set to false, then it uses the new logic? Otherwise, it only runs service checks for the items in that group?
- Alejandro Fernandez
On Jan. 16, 2015, 2:52 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29956/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 2:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-9167
> https://issues.apache.org/jira/browse/AMBARI-9167
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Enable full smoke tests. Involved changes to the upgrade pack:
>
> Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29956/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.403s
> [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
> [INFO] Final Memory: 31M/337M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 29956: Enable Running All Service Smoke Tests at
various check points in upgrade pack
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29956/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 9:52 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Changes
-------
Update diff for tests
Bugs: AMBARI-9167
https://issues.apache.org/jira/browse/AMBARI-9167
Repository: ambari
Description
-------
Enable full smoke tests. Involved changes to the upgrade pack:
Each group runs it's own service check. Need to be able to turn them off such that the next group (a service-check one) that runs full checks doesn't re-run ones it just did. For example. Full service checks happen after each of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on CORE_MASTER when running them all right after anyway.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java cdecac6
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 1b957da
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java b4a75ae
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 26e1546
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java cf2de93
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml PRE-CREATION
Diff: https://reviews.apache.org/r/29956/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:47.403s
[INFO] Finished at: Thu Jan 15 21:44:24 EST 2015
[INFO] Final Memory: 31M/337M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole