You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/29 08:22:42 UTC
[GitHub] [calcite] beyond1920 opened a new pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
beyond1920 opened a new pull request #2664:
URL: https://github.com/apache/calcite/pull/2664
## What is the purpose of the change
The pr aims to support SQL hints for temporal table join.
## Brief change log
- Extends `Correlate` to be a `Hintable`
- Add a hint predicate in `HintPredicates`
## Verifying this change
- Add tests in `SqlHintsConverterTest` to validate the hint could be propagated to `Correlate`
- Add tests in `RelBuilderTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] beyond1920 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r785583739
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,30 +786,49 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, withFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, withFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.and(HintPredicates.JOIN, withFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
- /** Returns a {@link HintPredicate} for join with specified table references. */
- private static HintPredicate joinWithFixedTableName() {
+ /** Returns a {@link HintPredicate} for join or correlate with specified table references. */
+ private static HintPredicate withFixedTableName() {
return (hint, rel) -> {
- if (!(rel instanceof LogicalJoin)) {
+ if (!(rel instanceof LogicalJoin || rel instanceof LogicalCorrelate)) {
return false;
}
- LogicalJoin join = (LogicalJoin) rel;
final List<String> tableNames = hint.listOptions;
- final List<String> inputTables = join.getInputs().stream()
- .filter(input -> input instanceof TableScan)
- .map(scan -> Util.last(scan.getTable().getQualifiedName()))
- .collect(Collectors.toList());
+ final List<String> inputTables = new TableNameVisitor().run(rel);
return equalsStringList(tableNames, inputTables);
};
}
+ /**
+ * Implementation of RelVisitor to extract input table names.
+ */
+ private static class TableNameVisitor extends RelVisitor {
+ private List<String> names = new ArrayList<>();
+
+ List<String> run(RelNode input) {
+ go(input);
+ return names;
+ }
+
+ @Override public void visit(RelNode node, int ordinal, @Nullable RelNode parent) {
+ if (node instanceof TableScan) {
+ RelOptTable table = node.getTable();
+ String tableName = Util.last(table.getQualifiedName());
Review comment:
Hi danny, I updated the logical to extract table names. Please have a look at the pr again, thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] beyond1920 commented on pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#issuecomment-1003670067
@danny0405 Thanks for review. I've updated the pr based on you comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r785614419
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,14 +788,42 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, temporalJoinWithFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
+ /** Returns a {@link HintPredicate} for temporal join with specified table references. */
+ private static HintPredicate temporalJoinWithFixedTableName() {
+ return (hint, rel) -> {
+ if (!(rel instanceof LogicalCorrelate)) {
+ return false;
+ }
+ LogicalCorrelate correlate = (LogicalCorrelate) rel;
+ RelNode leftInput = correlate.getLeft();
+ if (!(leftInput instanceof TableScan)) {
+ return false;
+ }
+ RelNode rightInput = correlate.getRight();
+ boolean rightIsFilterOnSnapshot = rightInput instanceof Filter
+ && ((Filter) rightInput).getInput() instanceof Snapshot
+ && ((Snapshot) ((Filter) rightInput).getInput()).getInput() instanceof TableScan;
+ if (!rightIsFilterOnSnapshot) {
+ return false;
+ }
+ String leftTableName = getTableNameOfScan(leftInput);
+ String rightTableName = getTableNameOfScan(
+ ((Snapshot) ((Filter) rightInput).getInput()).getInput());
+ final List<String> tableNames = hint.listOptions;
+ return tableNames.contains(leftTableName) && tableNames.contains(rightTableName);
+ };
Review comment:
Can we use `equalsStringList` here ? And there must have a filter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r785290869
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,30 +786,49 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, withFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, withFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.and(HintPredicates.JOIN, withFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
- /** Returns a {@link HintPredicate} for join with specified table references. */
- private static HintPredicate joinWithFixedTableName() {
+ /** Returns a {@link HintPredicate} for join or correlate with specified table references. */
+ private static HintPredicate withFixedTableName() {
return (hint, rel) -> {
- if (!(rel instanceof LogicalJoin)) {
+ if (!(rel instanceof LogicalJoin || rel instanceof LogicalCorrelate)) {
return false;
}
- LogicalJoin join = (LogicalJoin) rel;
final List<String> tableNames = hint.listOptions;
- final List<String> inputTables = join.getInputs().stream()
- .filter(input -> input instanceof TableScan)
- .map(scan -> Util.last(scan.getTable().getQualifiedName()))
- .collect(Collectors.toList());
+ final List<String> inputTables = new TableNameVisitor().run(rel);
return equalsStringList(tableNames, inputTables);
};
}
+ /**
+ * Implementation of RelVisitor to extract input table names.
+ */
+ private static class TableNameVisitor extends RelVisitor {
+ private List<String> names = new ArrayList<>();
+
+ List<String> run(RelNode input) {
+ go(input);
+ return names;
+ }
+
+ @Override public void visit(RelNode node, int ordinal, @Nullable RelNode parent) {
+ if (node instanceof TableScan) {
+ RelOptTable table = node.getTable();
+ String tableName = Util.last(table.getQualifiedName());
Review comment:
Should we use a visitor here ? The original logic force equals only when the join inputs are both direct table reference, but now it is not, which is not for our purpose ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] beyond1920 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r786439435
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,14 +788,42 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, temporalJoinWithFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
+ /** Returns a {@link HintPredicate} for temporal join with specified table references. */
+ private static HintPredicate temporalJoinWithFixedTableName() {
+ return (hint, rel) -> {
+ if (!(rel instanceof LogicalCorrelate)) {
+ return false;
+ }
+ LogicalCorrelate correlate = (LogicalCorrelate) rel;
+ RelNode leftInput = correlate.getLeft();
+ if (!(leftInput instanceof TableScan)) {
+ return false;
+ }
+ RelNode rightInput = correlate.getRight();
+ boolean rightIsFilterOnSnapshot = rightInput instanceof Filter
+ && ((Filter) rightInput).getInput() instanceof Snapshot
+ && ((Snapshot) ((Filter) rightInput).getInput()).getInput() instanceof TableScan;
+ if (!rightIsFilterOnSnapshot) {
+ return false;
+ }
+ String leftTableName = getTableNameOfScan(leftInput);
+ String rightTableName = getTableNameOfScan(
+ ((Snapshot) ((Filter) rightInput).getInput()).getInput());
+ final List<String> tableNames = hint.listOptions;
+ return tableNames.contains(leftTableName) && tableNames.contains(rightTableName);
+ };
Review comment:
> And there must have a filter ?
Yes for temporal join. Because there must a filter which contain join condition.
> Can we use equalsStringList here ?
I'm not sure if there is necessary here to build a list which contain leftTableName and rightTableName, then call equalsStringList. Because we have already get leftTableName and rightTableName separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r777164438
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -392,29 +392,39 @@ RelNode createJoin(RelNode left, RelNode right, List<RelHint> hints,
* <p>The result is typically a {@link Correlate}.
*/
public interface CorrelateFactory {
+
/**
* Creates a correlate.
*
* @param left Left input
* @param right Right input
+ * @param hints Hints
* @param correlationId Variable name for the row of left input
* @param requiredColumns Required columns
* @param joinType Join type
*/
- RelNode createCorrelate(RelNode left, RelNode right,
+ RelNode createCorrelate(RelNode left, RelNode right, List<RelHint> hints,
CorrelationId correlationId, ImmutableBitSet requiredColumns,
JoinRelType joinType);
+
+ @Deprecated // to be removed before 1.23
+ default RelNode createCorrelate(RelNode left, RelNode right,
+ CorrelationId correlationId, ImmutableBitSet requiredColumns,
Review comment:
No need to add this default impl, `createCorrelate` is kind of internal API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 closed pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #2664:
URL: https://github.com/apache/calcite/pull/2664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] beyond1920 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r786439435
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,14 +788,42 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, temporalJoinWithFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
+ /** Returns a {@link HintPredicate} for temporal join with specified table references. */
+ private static HintPredicate temporalJoinWithFixedTableName() {
+ return (hint, rel) -> {
+ if (!(rel instanceof LogicalCorrelate)) {
+ return false;
+ }
+ LogicalCorrelate correlate = (LogicalCorrelate) rel;
+ RelNode leftInput = correlate.getLeft();
+ if (!(leftInput instanceof TableScan)) {
+ return false;
+ }
+ RelNode rightInput = correlate.getRight();
+ boolean rightIsFilterOnSnapshot = rightInput instanceof Filter
+ && ((Filter) rightInput).getInput() instanceof Snapshot
+ && ((Snapshot) ((Filter) rightInput).getInput()).getInput() instanceof TableScan;
+ if (!rightIsFilterOnSnapshot) {
+ return false;
+ }
+ String leftTableName = getTableNameOfScan(leftInput);
+ String rightTableName = getTableNameOfScan(
+ ((Snapshot) ((Filter) rightInput).getInput()).getInput());
+ final List<String> tableNames = hint.listOptions;
+ return tableNames.contains(leftTableName) && tableNames.contains(rightTableName);
+ };
Review comment:
> And there must have a filter ?
Good catch.
For current temporal join there must a filter which contain join condition. But for temporal cross join, there is not filter node.
> Can we use equalsStringList here ?
Of course.
But I'm not sure if there is necessary here to build a list which contain leftTableName and rightTableName, then call equalsStringList. Because we have already get leftTableName and rightTableName separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] beyond1920 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r786439435
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,14 +788,42 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, temporalJoinWithFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
+ /** Returns a {@link HintPredicate} for temporal join with specified table references. */
+ private static HintPredicate temporalJoinWithFixedTableName() {
+ return (hint, rel) -> {
+ if (!(rel instanceof LogicalCorrelate)) {
+ return false;
+ }
+ LogicalCorrelate correlate = (LogicalCorrelate) rel;
+ RelNode leftInput = correlate.getLeft();
+ if (!(leftInput instanceof TableScan)) {
+ return false;
+ }
+ RelNode rightInput = correlate.getRight();
+ boolean rightIsFilterOnSnapshot = rightInput instanceof Filter
+ && ((Filter) rightInput).getInput() instanceof Snapshot
+ && ((Snapshot) ((Filter) rightInput).getInput()).getInput() instanceof TableScan;
+ if (!rightIsFilterOnSnapshot) {
+ return false;
+ }
+ String leftTableName = getTableNameOfScan(leftInput);
+ String rightTableName = getTableNameOfScan(
+ ((Snapshot) ((Filter) rightInput).getInput()).getInput());
+ final List<String> tableNames = hint.listOptions;
+ return tableNames.contains(leftTableName) && tableNames.contains(rightTableName);
+ };
Review comment:
> And there must have a filter ?
Good catch.
For current temporal join there must a filter which contain join condition. But for temporal cross join, there is not filter node.
> Can we use equalsStringList here ?
Of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r785614419
##########
File path: core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java
##########
@@ -771,14 +788,42 @@ static HintStrategyTable createHintStrategies(HintStrategyTable.Builder builder)
+ "allowed options: [ONE_PHASE, TWO_PHASE]",
hint.hintName)).build())
.hintStrategy("use_hash_join",
- HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
+ HintPredicates.or(
+ HintPredicates.and(HintPredicates.CORRELATE, temporalJoinWithFixedTableName()),
+ HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName())))
.hintStrategy("use_merge_join",
HintStrategy.builder(
HintPredicates.and(HintPredicates.JOIN, joinWithFixedTableName()))
.excludedRules(EnumerableRules.ENUMERABLE_JOIN_RULE).build())
.build();
}
+ /** Returns a {@link HintPredicate} for temporal join with specified table references. */
+ private static HintPredicate temporalJoinWithFixedTableName() {
+ return (hint, rel) -> {
+ if (!(rel instanceof LogicalCorrelate)) {
+ return false;
+ }
+ LogicalCorrelate correlate = (LogicalCorrelate) rel;
+ RelNode leftInput = correlate.getLeft();
+ if (!(leftInput instanceof TableScan)) {
+ return false;
+ }
+ RelNode rightInput = correlate.getRight();
+ boolean rightIsFilterOnSnapshot = rightInput instanceof Filter
+ && ((Filter) rightInput).getInput() instanceof Snapshot
+ && ((Snapshot) ((Filter) rightInput).getInput()).getInput() instanceof TableScan;
+ if (!rightIsFilterOnSnapshot) {
+ return false;
+ }
+ String leftTableName = getTableNameOfScan(leftInput);
+ String rightTableName = getTableNameOfScan(
+ ((Snapshot) ((Filter) rightInput).getInput()).getInput());
+ final List<String> tableNames = hint.listOptions;
+ return tableNames.contains(leftTableName) && tableNames.contains(rightTableName);
+ };
Review comment:
Can we use `equalsStringList` here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2664: [CALCITE-4967] Support SQL hints for temporal table join
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r777164619
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalCorrelate.java
##########
@@ -86,26 +107,38 @@ public LogicalCorrelate(RelInput input) {
}
/** Creates a LogicalCorrelate. */
- public static LogicalCorrelate create(RelNode left, RelNode right,
+ public static LogicalCorrelate create(RelNode left, RelNode right, List<RelHint> hints,
CorrelationId correlationId, ImmutableBitSet requiredColumns,
JoinRelType joinType) {
final RelOptCluster cluster = left.getCluster();
final RelTraitSet traitSet = cluster.traitSetOf(Convention.NONE);
- return new LogicalCorrelate(cluster, traitSet, left, right, correlationId,
+ return new LogicalCorrelate(cluster, traitSet, hints, left, right, correlationId,
requiredColumns, joinType);
}
+ @Deprecated // to be removed before 1.23
+ public static LogicalCorrelate create(RelNode left, RelNode right,
Review comment:
Do you mean 'to be removed before 2.0' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org