[GitHub] [james-project] vttranlina commented on a change in pull request #538: Scala checkstyle

[GitBox <gi...@apache.org>]

vttranlina commented on a change in pull request #538:
URL: https://github.com/apache/james-project/pull/538#discussion_r670217501



##########
File path: .scalafix.conf
##########
@@ -1,9 +1,27 @@
 rules = [
-    RemoveUnused
+    RemoveUnused,
+    DisableSyntax,
+    ProcedureSyntax,
+    NoValInForComprehension,
+    LeakingImplicitClassVal
 ]
 
 RemoveUnused.imports = true
 RemoveUnused.privates = false
 RemoveUnused.locals = true
 RemoveUnused.patternvars = false
 RemoveUnused.implicits = false
+
+DisableSyntax.noVars = false
+DisableSyntax.noThrows = false
+DisableSyntax.noNulls = false
+DisableSyntax.noReturns = false
+DisableSyntax.noWhileLoops = false
+DisableSyntax.noAsInstanceOf = false
+DisableSyntax.noIsInstanceOf = false
+DisableSyntax.noXml = false
+DisableSyntax.noDefaultArgs = false
+DisableSyntax.noFinalVal = true
+DisableSyntax.noFinalize = true
+DisableSyntax.noValPatterns = false
+DisableSyntax.noUniversalEquality = false

Review comment:
       I tried to enable some config, but the result is not my expectations. It makes James code wrong. 
   So I think the first shoot is a simple config. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org