You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/11 08:06:34 UTC
[GitHub] [flink-ml] gaoyunhaii opened a new pull request #31: [FLINK-24842][iteration] Make outputs depends on tails for the iteration body
gaoyunhaii opened a new pull request #31:
URL: https://github.com/apache/flink-ml/pull/31
This PR forces that the outputs depends on all the tails.
If we want to allow users to use table api with the output of the iteration, since the table api would crop the stream graph and only leave the operators that the output depends on. However, for the iteration we always required the whole iteration participate for alignement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] guoweiM commented on a change in pull request #31: [FLINK-24842][iteration] Make outputs depends on tails for the iteration body
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #31:
URL: https://github.com/apache/flink-ml/pull/31#discussion_r748980501
##########
File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/Iterations.java
##########
@@ -367,6 +377,8 @@ private static void addCriteriaStream(
// Now we notify all the head operators to count the criteria stream.
Review comment:
criteria streams?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] guoweiM commented on a change in pull request #31: [FLINK-24842][iteration] Make outputs depends on tails for the iteration body
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #31:
URL: https://github.com/apache/flink-ml/pull/31#discussion_r748977842
##########
File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/Iterations.java
##########
@@ -252,29 +253,38 @@ private static DataStreamList createIteration(
headStreams.get(i).getParallelism()));
}
+ List<DataStream<?>> tailsAndCriteriaTails = new ArrayList<>();
Review comment:
Maybe this line could move to 263 line and change to
` List<DataStream<?>> tailsAndCriteriaTails = new ArrayList<>(tails.getDataStreams());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] gaoyunhaii closed pull request #31: [FLINK-24842][iteration] Make outputs depends on tails for the iteration body
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #31:
URL: https://github.com/apache/flink-ml/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org