You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/07/06 12:17:23 UTC
[GitHub] brooklyn-server pull request #234: Fix Entities.UNCHANGED marker, for rebind
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/234
Fix Entities.UNCHANGED marker, for rebind
Previously, after rebind then enrichers using this would have their
own copy of their object (due to xstream deserialisation). Instead,
use an enum.
This does not fix the problem for existing persisted state of enrichers
that have their own object!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/rebind-unchanged-marker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit 1455bbefabf610132c60c2f89a1c3e78a3d45f8e
Author: Aled Sage <al...@gmail.com>
Date: 2016-07-06T12:16:29Z
Fix Entities.UNCHANGED marker, for rebind
Previously, after rebind then enrichers using this would have their
own copy of their object (due to xstream deserialisation). Instead,
use an enum.
This does not fix the problem for existing persisted state of enrichers
that have their own object!
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #234: Fix Entities.UNCHANGED marker, for rebind
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/234
@ahgittin we persist them as part of the enricher returned by `ServiceNotUpLogic.newEnricherForServiceUpIfNotUpIndicatorsEmpty()`. The default value in the computing function is `Entities.UNCHANGED`. So it might be in customer persisted state :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #234: Fix Entities.UNCHANGED marker, for rebind
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #234: Fix Entities.UNCHANGED marker, for rebind
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/234
very nice fix. i should think in most cases we don't persist these values, they are intermediate returns to determine whether to change. but there might be a few cases where we do, eg initial values, however in those cases they should get the real value as soon as the enricher runs, so worth keeping an eye out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---