You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/03/19 19:00:14 UTC
Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT
call in IOSwitchboard.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.
Bugs: MESOS-8545
https://issues.apache.org/jira/browse/MESOS-8545
Repository: mesos
Description
-------
Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
due to immediate termination of IOSwitchboard process after termination
of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
of sending all responses back to the agent, the agent received
disconnection error. To fix the issue, this commit adds finalization
of libprocess before returning from IOSwitchboard's main function.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b
Diff: https://reviews.apache.org/r/66147/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
Andrei Budnik
Re: Review Request 66147: Fixed disconnection for
ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/#review199472
-----------------------------------------------------------
PASS: Mesos patch 66147 was successfully built and tested.
Reviews applied: `['66147']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66147
- Mesos Reviewbot Windows
On March 19, 2018, noon, Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66147/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, noon)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
> due to immediate termination of IOSwitchboard process after termination
> of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
> of sending all responses back to the agent, the agent received
> disconnection error. To fix the issue, this commit adds finalization
> of libprocess before returning from IOSwitchboard's main function.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b
>
>
> Diff: https://reviews.apache.org/r/66147/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66147: Fixed disconnection for
ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/#review200181
-----------------------------------------------------------
I have reverted this patch for now:
https://github.com/apache/mesos/commit/5984cb72589415402f769190b124e172f72cfb39
See MESOS-8545 and MESOS-8729.
- Alexander Rukletsov
On March 19, 2018, 9:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66147/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 9:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
> due to immediate termination of IOSwitchboard process after termination
> of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
> of sending all responses back to the agent, the agent received
> disconnection error. To fix the issue, this patch adds finalization
> of libprocess before returning from IOSwitchboard's main function.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b
>
>
> Diff: https://reviews.apache.org/r/66147/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66147: Fixed disconnection for
ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/#review199479
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 19, 2018, 9:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66147/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 9:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
> due to immediate termination of IOSwitchboard process after termination
> of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
> of sending all responses back to the agent, the agent received
> disconnection error. To fix the issue, this patch adds finalization
> of libprocess before returning from IOSwitchboard's main function.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b
>
>
> Diff: https://reviews.apache.org/r/66147/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66147: Fixed disconnection for
ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66147/
-----------------------------------------------------------
(Updated March 19, 2018, 9:41 p.m.)
Review request for mesos, Alexander Rukletsov, Joseph Wu, and Kevin Klues.
Bugs: MESOS-8545
https://issues.apache.org/jira/browse/MESOS-8545
Repository: mesos
Description (updated)
-------
Previously, http response for ATTACH_CONTAINER_INPUT call could be lost
due to immediate termination of IOSwitchboard process after termination
of IOSwitchboard actor. Since IOSwitchboard didn't wait for completion
of sending all responses back to the agent, the agent received
disconnection error. To fix the issue, this patch adds finalization
of libprocess before returning from IOSwitchboard's main function.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard_main.cpp 0ff58e1b9dd7cddfebaf5d45c0562da1dcabf11b
Diff: https://reviews.apache.org/r/66147/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
Andrei Budnik